Skip to content

[Due for payment 2026-10-13] [$175] [Insights][R1][App] Handle the empty states #100654

Closed

Description

@cristipaval

Implement this section of the design doc: https://docs.google.com/document/d/1w3bjKnKt_yzulhzRko6wwejySVvqB2tHkFWJn1O5h7w/edit?tab=t.0#heading=h.b2x06sz73tlg

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit

Activity

  1. melvin-bot commented on Sep 14, 2026

    @melvin-bot

    @mhawryluk Huh... This is 4 days overdue. Who can take care of this?

  2. cristipaval commented on Sep 15, 2026

    @cristipaval
    ContributorAuthor

    R1 is wip

  3. melvin-bot commented on Sep 18, 2026

    @melvin-bot

    @cristipaval, @luacmartins, @mhawryluk, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. 26 remaining items

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 13, 2026
  6. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Current assignee @truph01 is eligible for the External assigner, not assigning anyone new.

  7. changed the title [-][Insights][R1][App] Handle the empty states[/-] [+][$175] [Insights][R1][App] Handle the empty states[/+] on Oct 13, 2026
  8. melvin-bot commented on Oct 13, 2026

    @melvin-bot
  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 13, 2026
  10. changed the title [-][$175] [Insights][R1][App] Handle the empty states[/-] [+][Due for payment 2026-10-13] [$175] [Insights][R1][App] Handle the empty states[/+] on Oct 13, 2026
  11. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  13. truph01 commented on Oct 14, 2026

    @truph01
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    1. Enable the insightsPage beta.
    2. Open the Insights tab.
    3. Verify the graphs show as loading (per graph spinners) while we fetch data and there's no data fetched already.
    4. Verify the dashboard renders graphs when the data arrives from the backend.
    5. Verify there are 4* charts: Spend over time, Top merchants, Top spenders*, Top categories and that they look correct.
    6. Verify the chart shows data for the default filters: year-to-date, all workspaces, default workspace's currency, group-by: month (for Spend over time).
    7. Verify there is no Top spenders chart when the user is not an admin/approver/auditor of any workspace or that workspace has only one member.
    8. Verify clicking on a point/bar/slice on a chart navigates to Spend and shows a table of expenses for that clicked group.
    9. Click on the three dot menu on the insights widget and click "View on Spend".
    10. Verify we're navigated to the Spend tab and we show groups of that particular chart, but in a table view and with no limit of the number of rows.
    11. Simulate failing network in troubleshoot, verify there is an error message on the insights page and clicking the retry button refetches the backend query.
    12. Log in to an account that has no expenses at all. Verify there is a dedicated empty state in the Insights page with a CTA button for creating an expense.
    13. Create an expense, but set its date to last year. Verify there is a different empty state on the Insights page with no CTA button.

    Test:

    Do we agree 👍 or 👎

  14. truph01 commented on Oct 14, 2026

    @truph01
    Contributor

    @mallenexpensify This is part of https://github.com/orgs/Expensify/projects/317. As we can see, a few completed issues were paid at the old rate of $250.

  15. mallenexpensify commented on Oct 15, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @truph01 ∂ddd due $250 via NewDot

  16. garrettmknight commented on Oct 19, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions