Skip to content

[Due for payment 2026-09-22] [Design polish] Use one-color Concierge icon in top right #100827

Closed

Description

@shawnborton

We want to implement a one-color Concierge icon that matches the other icons that are typically found in the top right of all of our app's page header bars. We are going to soon be placing an account avatar in the top right, and this will help us maintain a difference between what's your own account avatar vs other app actions you might take.

Image

We want to style this component exactly like the current search icon, just swapping the icon for a one-color Concierge svg. That svg can be found here:

concierge.svg.zip

Tracking issue: #100792

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. shawnborton commented on Sep 10, 2026

    @shawnborton
    ContributorAuthor

    @MelvinBot please implement this. You can overwrite the existing Concierge icon that we have in the repo for this.

  2. MelvinBot commented on Sep 10, 2026

    @MelvinBot
    Contributor

    Done — draft PR: #100832

    What changed

    1. Overwrote assets/images/concierge.svg with the one-color SVG from the zip (run through the repo's svgo; renders pixel-identically to the export).
    2. SidePanelButtonBase.tsx:39 and index.native.tsx:47 now render Concierge instead of ConciergeAvatar, with fill={theme.icon} and the explicit width/height of 28 dropped. That leaves it byte-for-byte the same styling as SearchButton: same 40x40 pressable, 20x20 icon, theme.icon fill.

    Because SidePanelButton is shared, this lands everywhere it appears — TopBar, HeaderWithBackButton, HeaderWithBackButtonComposed, and the inbox HeaderView. The one-color icon also now shows in the report action context menu's "Explain" item, which already used Expensicons.Concierge.

    One-color Concierge icon next to the search icon in the page header, light and dark themes

    ⚠️ That image is a headless-Chrome render of the committed SVG at the real component sizes and theme colors — not a screenshot of the running app. The web test session went blank part way through this run and I couldn't recover it, so this has not been verified in a live build. Please eyeball it in the app before marking the PR ready for review.

    Checks that did run
    Check Result
    npm run lint-changed pass
    npm run typecheck pass
    npm run spell-changed pass
    npm run react-compiler-compliance-check check <changed files> pass
    Jest — tests/unit/components/SidePanel, useSidePanelContext, useConciergeSidePanelReportActions, AvatarTest pass, 37 tests

    The full Jest suite was not run, only the suites covering the changed components.

    Please mark the PR as "Ready for review" when it's ready.


    view run · no recording available

  3. melvin-bot commented on Sep 11, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  4. changed the title [-][Design polish] Use one-color Concierge icon in top right[/-] [+][Due for payment 2026-09-22] [Design polish] Use one-color Concierge icon in top right[/+] on Sep 15, 2026
  5. melvin-bot commented on Sep 15, 2026

    @melvin-bot

    @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.78-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-09-22. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  6. huult commented on Sep 16, 2026

    @huult
    Contributor

    We’re handling the payment in #100813, so we can close this ticket after 7 days.

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 16, 2026
  8. melvin-bot commented on Sep 21, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  9. melvin-bot commented on Sep 21, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  10. grgia commented on Sep 24, 2026

    @grgia
    Contributor

    closing payment in parent issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions