You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-29] Not-found page and unexpected welcome modal after Clear cache and restart #100860
Sign in with an account eligible for the migrated-user welcome flow that has already dismissed the welcome modal.
Go to Account > Troubleshoot.
Select Clear cache and restart, then confirm Reset and refresh.
Expected Result
The app reloads on Troubleshoot without showing the migrated-user welcome modal.
Actual Result
The app lands on the "Hmm... it's not here" not-found page, and the migrated-user welcome modal can reappear even though it was already dismissed.
Root Cause
Two independent problems combine during Clear cache and restart:
Transient partially-cleared state.src/libs/actions/App.ts:956 (clearOnyxAndResetApp) clears account-scoped Onyx data before IS_LOADING_APP is set. Guards subscribed to those keys observe a window where the account data is gone but the app is not marked as loading, so they act on state that is about to be replaced by the following OpenApp response.
Invalid dynamic modal base route. The migrated-user welcome guard built its modal route on top of whatever Navigation.getActiveRoute() returned. After the reset, the active route is /settings/troubleshoot, which is not one of DYNAMIC_ROUTES.MIGRATED_USER_WELCOME.entryScreens. Stacking the dynamic modal suffix onto a non-entry screen resolves to the not-found page on every platform. SubmitPlanWelcomeModalGuard already had a local workaround for the same class of bug.
Proposed Fix
Seed IS_LOADING_APP=true in the same Onyx operation that clears account-scoped data, so no consumer can observe the intermediate state and no new Onyx subscription is needed.
Extract the entry-screen validation into a shared getValidDynamicRouteBasePath helper that returns the active route only when it can host the dynamic modal, and falls back to Home otherwise. Use it from both MigratedUserWelcomeModalGuard and SubmitPlanWelcomeModalGuard.
@NicolasBonet since you've been overseeing this issue i'd kindly ask you to review my PR for this issue too 🙌🏼 Feel free to unassign yourself again if somebody else should take it
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.2-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
I can't trigger the payment flow myself. It starts when an internal assignee adds the Awaiting Payment label, and nobody added it here.
Fix not-found page after clearing cache reached production in 9.5.2-4 on 2026-10-05. The 7-day regression period ended around 2026-10-12. The issue was then closed on 2026-10-19 without the label.
NicolasBonet, could you add Awaiting Payment and handle the payment summary for the C+ review?
changed the title [-]Not-found page and unexpected welcome modal after Clear cache and restart[/-][+][Due for payment 2026-10-29] Not-found page and unexpected welcome modal after Clear cache and restart[/+]on Oct 29, 2026
Activity
chrispader commentedon Sep 21, 2026
@NicolasBonet since you've been overseeing this issue i'd kindly ask you to review my PR for this issue too 🙌🏼 Feel free to unassign yourself again if somebody else should take it
@MelvinBot please assign @NicolasBonet to this issue and #100859, and request a review
MelvinBot commentedon Sep 21, 2026
Done —
NicolasBonetis now assigned to this issue and to Fix not-found page after clearing cache, with a review requested on the PR.NicolasBonetNicolasBonet+ review requestedabdulrahuman5196still has an open review request on the PR.view run
NicolasBonet commentedon Sep 21, 2026
@chrispader I simply helped close the issue based on the reports in Slack, wasn't overseeing it, but i gave it a review.
NicolasBonet commentedon Sep 28, 2026
Waiting on the contributor's checklist.
NicolasBonet commentedon Oct 1, 2026
Still waiting on the contributor, if not done today will re-assign.
melvin-bot commentedon Oct 5, 2026
@NicolasBonet @chrispader
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.2-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
3 remaining items
NicolasBonet commentedon Oct 19, 2026
Merged two weeks ago, closing cc @chrispader
abdulrahuman5196 commentedon Oct 29, 2026
@NicolasBonet This issue is closed before triggering the payment flow. Reopening the issue.
abdulrahuman5196 commentedon Oct 29, 2026
@MelvinBot could you trigger the payment workflow? Seems it didn't automatically happen for this issue.
MelvinBot commentedon Oct 29, 2026
I can't trigger the payment flow myself. It starts when an internal assignee adds the
Awaiting Paymentlabel, and nobody added it here.Fix not-found page after clearing cache reached production in 9.5.2-4 on 2026-10-05. The 7-day regression period ended around 2026-10-12. The issue was then closed on 2026-10-19 without the label.
NicolasBonet, could you addAwaiting Paymentand handle the payment summary for the C+ review?view run
abdulrahuman5196 commentedon Oct 29, 2026
@NicolasBonet Could you kindly apply the label mentioned here - #100860 (comment)
[-]Not-found page and unexpected welcome modal after Clear cache and restart[/-][+][Due for payment 2026-10-29] Not-found page and unexpected welcome modal after Clear cache and restart[/+]NicolasBonet commentedon Oct 29, 2026
Done @abdulrahuman5196
melvin-bot commentedon Oct 29, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mallenexpensify commentedon Oct 30, 2026
Payment Summary
Contributor+: @abdulrahuman5196 due $250 via NewDot