You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Payment - "You appears to be offline" is duplicated #10087
"You appears to be offline" - must be displayed once
Actual Result:
"You appears to be offline" message is duplicated
Workaround:
Unknown
Platform:
Where is this issue occurring?
iOS
Android
Mobile Web
Version Number: 1.1.86-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): any Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Ah, yeah, I think you're right. The OfflineIndicator is shown on small screens on the ScreenWrapper (added in #9895) but the OfflineIndicator was also added to the BasePaymentsPage in #9589 so it'll end up showing twice on that page.
Hmm, ok. Now looks like there's no offline indicator whatsoever since it's been removed from both ScreenWrapper and BasePaymentsPage.
@jasperhuangg@MariaHCD since you both worked on the offline indicator for these pages and there's been some crossed wires, what do you want to do going forward? I think we should add back in OfflineIndicator to BasePaymentsPage while we're waiting for the v2 of #9895. Thoughts?
Either way I don't think this is a blocker anymore since there's no duplication of the offline indicator anymore. Going to adjust the labels appropriately and keep it assigned.
Activity
OSBotify commentedon Jul 25, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Jul 25, 2022
Triggered auto assignment to @NikkiWines (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.NikkiWines commentedon Jul 26, 2022
Oops sorry, missed my assignment to this - was catching up from being OOO. Looking into it now
jasperhuangg commentedon Jul 26, 2022
@NikkiWines I have a feeling it could be related to #9895, which I'm about to revert. Will let you know if this fixes the problem!
NikkiWines commentedon Jul 26, 2022
Ah, yeah, I think you're right. The
OfflineIndicatoris shown on small screens on theScreenWrapper(added in #9895) but theOfflineIndicatorwas also added to theBasePaymentsPagein #9589 so it'll end up showing twice on that page.NikkiWines commentedon Jul 26, 2022
Looks like a revert PR for #9895 has been merged and deployed to staging. Testing now to see if I can reproduce the original error
NikkiWines commentedon Jul 26, 2022
Hmm, ok. Now looks like there's no offline indicator whatsoever since it's been removed from both ScreenWrapper and BasePaymentsPage.
@jasperhuangg @MariaHCD since you both worked on the offline indicator for these pages and there's been some crossed wires, what do you want to do going forward? I think we should add back in
OfflineIndicatortoBasePaymentsPagewhile we're waiting for the v2 of #9895. Thoughts?NikkiWines commentedon Jul 26, 2022
Either way I don't think this is a blocker anymore since there's no duplication of the offline indicator anymore. Going to adjust the labels appropriately and keep it assigned.
luacmartins commentedon Jul 26, 2022
So right now we have no
You appear to be offlinemessage? It seems ok to remove the blocker status, but we should fix this soon.MariaHCD commentedon Jul 27, 2022
This sounds good to me!