Skip to content

Payment - "You appears to be offline" is duplicated  #10087

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #9895

Action Performed:

  1. Sign into an account on NewDot.
  2. Turn on your wifi.
  3. Go to settings > Payment

Expected Result:

"You appears to be offline" - must be displayed once

Actual Result:

"You appears to be offline" message is duplicated

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

Version Number: 1.1.86-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5662761_ios_9896-video.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Jul 25, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jul 25, 2022

    @melvin-bot

    Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. NikkiWines commented on Jul 26, 2022

    @NikkiWines
    Contributor

    Oops sorry, missed my assignment to this - was catching up from being OOO. Looking into it now

  4. jasperhuangg commented on Jul 26, 2022

    @jasperhuangg
    Contributor

    @NikkiWines I have a feeling it could be related to #9895, which I'm about to revert. Will let you know if this fixes the problem!

  5. NikkiWines commented on Jul 26, 2022

    @NikkiWines
    Contributor

    Ah, yeah, I think you're right. The OfflineIndicator is shown on small screens on the ScreenWrapper (added in #9895) but the OfflineIndicator was also added to the BasePaymentsPage in #9589 so it'll end up showing twice on that page.

  6. NikkiWines commented on Jul 26, 2022

    @NikkiWines
    Contributor

    Looks like a revert PR for #9895 has been merged and deployed to staging. Testing now to see if I can reproduce the original error

  7. NikkiWines commented on Jul 26, 2022

    @NikkiWines
    Contributor

    Hmm, ok. Now looks like there's no offline indicator whatsoever since it's been removed from both ScreenWrapper and BasePaymentsPage.

    @jasperhuangg @MariaHCD since you both worked on the offline indicator for these pages and there's been some crossed wires, what do you want to do going forward? I think we should add back in OfflineIndicator to BasePaymentsPage while we're waiting for the v2 of #9895. Thoughts?

  8. NikkiWines commented on Jul 26, 2022

    @NikkiWines
    Contributor

    Either way I don't think this is a blocker anymore since there's no duplication of the offline indicator anymore. Going to adjust the labels appropriately and keep it assigned.

  9. added
    ImprovementItem broken or needs improvement.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 26, 2022
  10. luacmartins commented on Jul 26, 2022

    @luacmartins
    Contributor

    So right now we have no You appear to be offline message? It seems ok to remove the blocker status, but we should fix this soon.

  11. MariaHCD commented on Jul 27, 2022

    @MariaHCD
    Contributor

    I think we should add back in OfflineIndicator to BasePaymentsPage while we're waiting for the v2 of #9895. Thoughts?

    This sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions