You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-14] Expense - Referral Banner hides behind keyboard when creating expense #101035
The two screens wrap the same referral banner in two differently-configured ScreenWrappers, and only the Start Chat one is set up to keep its fixed footer above the Android keyboard.
The banner itself is wired identically on both screens — it is passed as footerContent to SelectionListWithSections, which renders it as a non-scrolling sibling pinned below the list (src/components/SelectionList/components/Footer.tsx:27-35). SelectionList has no keyboard logic of its own; whether that footer clears the keyboard is decided entirely by the enclosing ScreenWrapper.
What changes do you think we should make in order to solve the problem?
Make the Create expense participant picker use the same edge-to-edge keyboard setup as Start Chat:
Add enableEdgeToEdgeBottomSafeAreaPadding (and optionally keyboardVerticalOffset) to StepScreenWrapperProps and forward them to the inner ScreenWrapper in StepScreenWrapper.tsx:70-78.
Switching to edge-to-edge mode flips addBottomSafeAreaPadding to true on the list, which is already handled and commented at ParticipantSearchResults.tsx:177-181 — verify the footer doesn't then sit under the system nav bar.
DynamicWorkspaceInvitePage.tsx:253-257 is the reference: it's another footerContent picker that sets both shouldEnableMaxHeight and enableEdgeToEdgeBottomSafeAreaPadding plus an explicit addBottomSafeAreaPadding.
Whoever picks this up should confirm on a real Android device which of the two settings actually moves the banner, since this is native layout behavior.
What alternative solutions did you explore? (Optional)
Alternatives considered and ruled out
The Activity / AlwaysPaintedView wrappers around the selector break the flex chain. Ruled out — the inner view carries styles.flex1 (src/components/AlwaysPaintedView/index.native.tsx), so layout is preserved.
The banner is wired differently (list footer vs fixed footer). Ruled out — both screens pass it as footerContent and it lands in the same FixedFooter.
shouldEnablePickerAvoiding differs. Ruled out — PickerAvoidingView is a no-op on Android, so it can't cause an Android-only symptom.
A recent PR regressed this. No evidence — nothing in recent history of StepScreenWrapper.tsx, DynamicIOURequestStepParticipants.tsx, or ParticipantSelectorFooter.tsx touches keyboard avoidance or footer placement. This looks like a longstanding gap between the two flows.
Confidence: medium. The configuration difference is confirmed in code. I did not run an Android device repro, so I can't prove from source alone which of enableEdgeToEdgeBottomSafeAreaPadding vs shouldEnableMaxHeight is the one that pushes the banner fully behind the keyboard.
Related issues: a quick scan of open Expensify/App issues found no duplicate or closely related report.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/101035) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Please re-state the problem that we are trying to solve in this issue.
When creating an expense on Android, tapping the "To" field opens the software keyboard, causing the Referral Banner (ooterContent in SelectionList) to be hidden behind the keyboard, whereas in the "Start Chat" flow the banner correctly pushes up and stays visible above the keyboard.
What is the root cause of that problem?
In NewChatPage (src/pages/NewChatPage/index.tsx), the screen passes enableEdgeToEdgeBottomSafeAreaPadding={true} to ScreenWrapper. In ScreenWrapper, when enableEdgeToEdgeBottomSafeAreaPadding is enabled, shouldKeyboardOffsetBottomSafeAreaPadding evaluates to rue, which applies the correct bottom inset offset in KeyboardAvoidingView and keeps pinned ooterContent above the Android keyboard.
In contrast, the Create Expense flow wraps its participant selector in StepScreenWrapper (src/pages/iou/request/step/StepScreenWrapper.tsx), which currently does not accept or forward enableEdgeToEdgeBottomSafeAreaPadding to the inner ScreenWrapper. As a result, ScreenWrapper defaults to enableEdgeToEdgeBottomSafeAreaPadding = false, disabling the keyboard offset calculation on Android and allowing the keyboard to render on top of the fixed footer banner.
What changes do you think we should make in order to solve the problem?
In src/pages/iou/request/step/StepScreenWrapper.tsx:
Extend StepScreenWrapperProps to accept optional enableEdgeToEdgeBottomSafeAreaPadding?: boolean and keyboardVerticalOffset?: number.
Forward enableEdgeToEdgeBottomSafeAreaPadding and keyboardVerticalOffset to the rendered .
In src/pages/iou/request/step/DynamicIOURequestStepParticipants.tsx (and IOURequestStepParticipants.tsx):
Pass enableEdgeToEdgeBottomSafeAreaPadding={true} to .
In src/pages/iou/request/ParticipantSearchResults.tsx:
Ensure �ddBottomSafeAreaPadding aligns with enableEdgeToEdgeBottomSafeAreaPadding (matching the pattern in DynamicWorkspaceInvitePage.tsx) so that the banner respects system navigation bars when the keyboard is dismissed.
This aligns the Create Expense participant selection flow with NewChatPage and DynamicWorkspaceInvitePage, properly hoisting the footer banner above the Android keyboard.
What alternative solutions did you explore? (Optional)
Wrapping ParticipantSelectorFooter in an additional custom KeyboardAvoidingView: Rejected because ScreenWrapper already encapsulates KeyboardAvoidingView and manages window/safe-area insets centrally; duplicating keyboard handlers causes layout jumping.
Modifying SelectionList's internal footer container: Rejected because keyboard avoidance is the responsibility of the screen-level container, not the generic list component.
I think Melvin’s root cause is wrong, issue occurred in ParticipantPicker/BaseParticipantPicker, not DynamicIOURequestStepParticipants/StepScreenWrapper missing edge-to-edge.
@paulnjs I cloned the repo and read the code before commenting. BaseParticipantPicker is not used in the Create Expense flow at all. DynamicIOURequestStepParticipants.tsx:150 renders <StepScreenWrapper>, not <BaseParticipantPicker>. You can verify this yourself:
src/pages/iou/request/step/DynamicIOURequestStepParticipants.tsx:39 import StepScreenWrapper from './StepScreenWrapper';
src/pages/iou/request/step/DynamicIOURequestStepParticipants.tsx:150 return (<StepScreenWrapper ...>
BaseParticipantPicker (src/components/ParticipantPicker/BaseParticipantPicker.tsx:57-60) is a standalone modal picker used in contact/group flows. It already has enableEdgeToEdgeBottomSafeAreaPadding set — that is precisely why it works correctly. The bug is not there.
The actual problem is that StepScreenWrapperProps (line 18-48 of StepScreenWrapper.tsx) does not expose enableEdgeToEdgeBottomSafeAreaPadding as a prop, so DynamicIOURequestStepParticipants has no mechanism to pass it through to the inner <ScreenWrapper> at line 71. Without that flag, shouldKeyboardOffsetBottomSafeAreaPadding at ScreenWrapper/index.tsx:135-141 evaluates to false, and the KeyboardAvoidingView applies zero bottom inset on Android, leaving the banner behind the keyboard.
The fix is adding one prop to StepScreenWrapperProps and forwarding it — no other file needs to change its architecture.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Log in with a new account that has a Control workspace
Tap FAB > Create expense
Tap the "To" field, then close and reopen the keyboard
Verify the referral banner shows above the keyboard
Close the keyboard and verify the banner is back at the bottom
Tap FAB > Start chat > "To" field and verify the banner behaves the same way
@brunovjk@jasperhuangg Melvin couldn't solve this one, so I did with my proposal (#102196). Under the current flow, an issue gets Help Wanted when Melvin can't fix it, so I think this should be paid like a Help Wanted issue at $250. What do you think?
Activity
applause-bot commentedon Sep 13, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e66847894153a30d3c3ee6f4ec089c95a0145b3b3fc6344bb535bbe72bdae044
MelvinBot commentedon Sep 13, 2026
Proposal
What is the root cause of that problem?
The two screens wrap the same referral banner in two differently-configured
ScreenWrappers, and only the Start Chat one is set up to keep its fixed footer above the Android keyboard.The banner itself is wired identically on both screens — it is passed as
footerContenttoSelectionListWithSections, which renders it as a non-scrolling sibling pinned below the list (src/components/SelectionList/components/Footer.tsx:27-35).SelectionListhas no keyboard logic of its own; whether that footer clears the keyboard is decided entirely by the enclosingScreenWrapper.Start Chat sets
enableEdgeToEdgeBottomSafeAreaPaddingand an explicitkeyboardVerticalOffset(src/pages/NewChatPage/index.tsx:404-414).Create expense goes through
StepScreenWrapper, which sets neither, and instead setsshouldEnableMaxHeight={canUseTouchScreen()}(src/pages/iou/request/step/StepScreenWrapper.tsx:70-78).StepScreenWrapper's prop type doesn't even acceptenableEdgeToEdgeBottomSafeAreaPaddingorkeyboardVerticalOffset, soDynamicIOURequestStepParticipants.tsx:150-155has no way to pass them.Because
enableEdgeToEdgeBottomSafeAreaPaddingis left undefined, the screen falls into legacy mode, which also turns offshouldKeyboardOffsetBottomSafeAreaPadding(src/components/ScreenWrapper/index.tsx:135-141), which is the input that feeds the keyboard-avoiding offset (src/components/KeyboardAvoidingView/index.tsx:12-15). The footer ends up under the keyboard.What changes do you think we should make in order to solve the problem?
Make the Create expense participant picker use the same edge-to-edge keyboard setup as Start Chat:
enableEdgeToEdgeBottomSafeAreaPadding(and optionallykeyboardVerticalOffset) toStepScreenWrapperPropsand forward them to the innerScreenWrapperinStepScreenWrapper.tsx:70-78.enableEdgeToEdgeBottomSafeAreaPaddingfromDynamicIOURequestStepParticipants.tsx:150-155.addBottomSafeAreaPaddingtotrueon the list, which is already handled and commented atParticipantSearchResults.tsx:177-181— verify the footer doesn't then sit under the system nav bar.DynamicWorkspaceInvitePage.tsx:253-257is the reference: it's anotherfooterContentpicker that sets bothshouldEnableMaxHeightandenableEdgeToEdgeBottomSafeAreaPaddingplus an explicitaddBottomSafeAreaPadding.Whoever picks this up should confirm on a real Android device which of the two settings actually moves the banner, since this is native layout behavior.
What alternative solutions did you explore? (Optional)
Alternatives considered and ruled out
Activity/AlwaysPaintedViewwrappers around the selector break the flex chain. Ruled out — the inner view carriesstyles.flex1(src/components/AlwaysPaintedView/index.native.tsx), so layout is preserved.footerContentand it lands in the sameFixedFooter.shouldEnablePickerAvoidingdiffers. Ruled out —PickerAvoidingViewis a no-op on Android, so it can't cause an Android-only symptom.StepScreenWrapper.tsx,DynamicIOURequestStepParticipants.tsx, orParticipantSelectorFooter.tsxtouches keyboard avoidance or footer placement. This looks like a longstanding gap between the two flows.DynamicRoomInvitePage.tsx:228-231andDynamicReportParticipantsInvitePage.tsx:190-193use the same legacy-mode shape, so they may show the same thing.Confidence: medium. The configuration difference is confirmed in code. I did not run an Android device repro, so I can't prove from source alone which of
enableEdgeToEdgeBottomSafeAreaPaddingvsshouldEnableMaxHeightis the one that pushes the banner fully behind the keyboard.Related issues: a quick scan of open
Expensify/Appissues found no duplicate or closely related report.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/101035)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run · no recording available
melvin-bot commentedon Sep 13, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (
External)melvin-bot commentedon Sep 13, 2026
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
Mister124x commentedon Sep 14, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When creating an expense on Android, tapping the "To" field opens the software keyboard, causing the Referral Banner (ooterContent in SelectionList) to be hidden behind the keyboard, whereas in the "Start Chat" flow the banner correctly pushes up and stays visible above the keyboard.
What is the root cause of that problem?
In NewChatPage (src/pages/NewChatPage/index.tsx), the screen passes enableEdgeToEdgeBottomSafeAreaPadding={true} to ScreenWrapper. In ScreenWrapper, when enableEdgeToEdgeBottomSafeAreaPadding is enabled, shouldKeyboardOffsetBottomSafeAreaPadding evaluates to rue, which applies the correct bottom inset offset in KeyboardAvoidingView and keeps pinned ooterContent above the Android keyboard.
In contrast, the Create Expense flow wraps its participant selector in StepScreenWrapper (src/pages/iou/request/step/StepScreenWrapper.tsx), which currently does not accept or forward enableEdgeToEdgeBottomSafeAreaPadding to the inner ScreenWrapper. As a result, ScreenWrapper defaults to enableEdgeToEdgeBottomSafeAreaPadding = false, disabling the keyboard offset calculation on Android and allowing the keyboard to render on top of the fixed footer banner.
What changes do you think we should make in order to solve the problem?
In src/pages/iou/request/step/StepScreenWrapper.tsx:
In src/pages/iou/request/step/DynamicIOURequestStepParticipants.tsx (and IOURequestStepParticipants.tsx):
In src/pages/iou/request/ParticipantSearchResults.tsx:
This aligns the Create Expense participant selection flow with NewChatPage and DynamicWorkspaceInvitePage, properly hoisting the footer banner above the Android keyboard.
What alternative solutions did you explore? (Optional)
paulnjs commentedon Sep 15, 2026
I think Melvin’s root cause is wrong, issue occurred in
ParticipantPicker/BaseParticipantPicker, notDynamicIOURequestStepParticipants/StepScreenWrappermissing edge-to-edge.Mister124x commentedon Sep 15, 2026
Proposal Update
@paulnjs I cloned the repo and read the code before commenting.
BaseParticipantPickeris not used in the Create Expense flow at all.DynamicIOURequestStepParticipants.tsx:150renders<StepScreenWrapper>, not<BaseParticipantPicker>. You can verify this yourself:BaseParticipantPicker(src/components/ParticipantPicker/BaseParticipantPicker.tsx:57-60) is a standalone modal picker used in contact/group flows. It already hasenableEdgeToEdgeBottomSafeAreaPaddingset — that is precisely why it works correctly. The bug is not there.The actual problem is that
StepScreenWrapperProps(line 18-48 ofStepScreenWrapper.tsx) does not exposeenableEdgeToEdgeBottomSafeAreaPaddingas a prop, soDynamicIOURequestStepParticipantshas no mechanism to pass it through to the inner<ScreenWrapper>at line 71. Without that flag,shouldKeyboardOffsetBottomSafeAreaPaddingatScreenWrapper/index.tsx:135-141evaluates tofalse, and theKeyboardAvoidingViewapplies zero bottom inset on Android, leaving the banner behind the keyboard.The fix is adding one prop to
StepScreenWrapperPropsand forwarding it — no other file needs to change its architecture.melvin-bot commentedon Sep 16, 2026
@brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!
fix(keyboard): accept and forward enableEdgeToEdgeBottomSafeAreaPaddi…
29 remaining items
melvin-bot commentedon Oct 13, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 13, 2026
Payment Summary
Resolving PRs:
Enable keyboard avoidance in ParticipantPicker so referral banner sta… #102196
Assignee: @yusufdeveloper2903 requires payment (Needs manual offer from BZ)
Reviewer: @brunovjk owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
brunovjk commentedon Oct 14, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: Feat: Manual expense flow UI refactor - r3 #87920 (comment)
Link to the comment on the Issue: [Due for payment 2026-08-12] Replace push rows with inline text inputs in manual expense create/edit flow #82586 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Do we agree 👍 or 👎
brunovjk commentedon Oct 14, 2026
C+ Summary
Fix: PR #102196 updates keyboard avoidance, bottom inset handling, and maxHeight in the recipient picker to keep the referral banner visible.
People involved: @yusufdeveloper2903 implemented the fix; @brunovjk reviewed and provided platform testing evidence, and @jasperhuangg reviewed and approved.
Production deployment: Deployed on 2026-10-07 in version 9.5.4-3: production confirmation and deployment checklist #103248.
Regressions and follow-ups: No regressions, reverts, or corrective follow-ups attributable to this fix were identified in the GitHub sources reviewed.
Suggested payment: $175
cc: @mallenexpensify.
yusufdeveloper2903 commentedon Oct 14, 2026
@brunovjk @jasperhuangg Melvin couldn't solve this one, so I did with my proposal (#102196). Under the current flow, an issue gets
Help Wantedwhen Melvin can't fix it, so I think this should be paid like aHelp Wantedissue at $250. What do you think?mallenexpensify commentedon Oct 16, 2026
Payment Summary
Contributor: @yusufdeveloper2903 paid $250 via Upwork
Contributor+: @brunovjk due $250 via NewDot
@yusufdeveloper2903 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022111158368132222502
yusufdeveloper2903 commentedon Oct 16, 2026
@mallenexpensify Thanks! I've accepted the job offer on Upwork
mallenexpensify commentedon Oct 16, 2026
@yusufdeveloper2903 paid, summary updated above. Thx.
laurenreidexpensify commentedon Oct 20, 2026
Approved @brunovjk $250 via New Expensify