Skip to content

[Due for payment 2026-10-14] Expense - Referral Banner hides behind keyboard when creating expense #101035

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.77-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/73545242/folder/54000978/41237494/1749949684
Email or phone of affected tester (no customers): bannertest@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Realme C21Y / Android 11
App Component: Money Requests

Action Performed:

Precondition : New account is created with control WS

  1. Open App > Click on FAB > "Start Chat"
  2. Tap on To field > Close and open keyboard
  3. Close the modal
  4. Tap on FAB > "Create expense"
  5. Tap on the "To" field > Close and open keyboard

Expected Result:

Banner appearing behavior should be same on both places.
Banner should be visible above the keyboard on both places.

Actual Result:

Referral Banner hides behind keyboard when creating expense

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7258022_1789225040863.XRecorder_20260912_03.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7258022

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. applause-bot commented on Sep 13, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/e66847894153a30d3c3ee6f4ec089c95a0145b3b3fc6344bb535bbe72bdae044

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 13, 2026
  3. MelvinBot commented on Sep 13, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The two screens wrap the same referral banner in two differently-configured ScreenWrappers, and only the Start Chat one is set up to keep its fixed footer above the Android keyboard.

    The banner itself is wired identically on both screens — it is passed as footerContent to SelectionListWithSections, which renders it as a non-scrolling sibling pinned below the list (src/components/SelectionList/components/Footer.tsx:27-35). SelectionList has no keyboard logic of its own; whether that footer clears the keyboard is decided entirely by the enclosing ScreenWrapper.

    Start Chat sets enableEdgeToEdgeBottomSafeAreaPadding and an explicit keyboardVerticalOffset (src/pages/NewChatPage/index.tsx:404-414).

    Create expense goes through StepScreenWrapper, which sets neither, and instead sets shouldEnableMaxHeight={canUseTouchScreen()} (src/pages/iou/request/step/StepScreenWrapper.tsx:70-78). StepScreenWrapper's prop type doesn't even accept enableEdgeToEdgeBottomSafeAreaPadding or keyboardVerticalOffset, so DynamicIOURequestStepParticipants.tsx:150-155 has no way to pass them.

    Because enableEdgeToEdgeBottomSafeAreaPadding is left undefined, the screen falls into legacy mode, which also turns off shouldKeyboardOffsetBottomSafeAreaPadding (src/components/ScreenWrapper/index.tsx:135-141), which is the input that feeds the keyboard-avoiding offset (src/components/KeyboardAvoidingView/index.tsx:12-15). The footer ends up under the keyboard.

    What changes do you think we should make in order to solve the problem?

    Make the Create expense participant picker use the same edge-to-edge keyboard setup as Start Chat:

    1. Add enableEdgeToEdgeBottomSafeAreaPadding (and optionally keyboardVerticalOffset) to StepScreenWrapperProps and forward them to the inner ScreenWrapper in StepScreenWrapper.tsx:70-78.
    2. Pass enableEdgeToEdgeBottomSafeAreaPadding from DynamicIOURequestStepParticipants.tsx:150-155.
    3. Switching to edge-to-edge mode flips addBottomSafeAreaPadding to true on the list, which is already handled and commented at ParticipantSearchResults.tsx:177-181 — verify the footer doesn't then sit under the system nav bar.

    DynamicWorkspaceInvitePage.tsx:253-257 is the reference: it's another footerContent picker that sets both shouldEnableMaxHeight and enableEdgeToEdgeBottomSafeAreaPadding plus an explicit addBottomSafeAreaPadding.

    Whoever picks this up should confirm on a real Android device which of the two settings actually moves the banner, since this is native layout behavior.

    What alternative solutions did you explore? (Optional)

    Alternatives considered and ruled out
    • The Activity / AlwaysPaintedView wrappers around the selector break the flex chain. Ruled out — the inner view carries styles.flex1 (src/components/AlwaysPaintedView/index.native.tsx), so layout is preserved.
    • The banner is wired differently (list footer vs fixed footer). Ruled out — both screens pass it as footerContent and it lands in the same FixedFooter.
    • shouldEnablePickerAvoiding differs. Ruled out — PickerAvoidingView is a no-op on Android, so it can't cause an Android-only symptom.
    • A recent PR regressed this. No evidence — nothing in recent history of StepScreenWrapper.tsx, DynamicIOURequestStepParticipants.tsx, or ParticipantSelectorFooter.tsx touches keyboard avoidance or footer placement. This looks like a longstanding gap between the two flows.
    • Likely also affected: DynamicRoomInvitePage.tsx:228-231 and DynamicReportParticipantsInvitePage.tsx:190-193 use the same legacy-mode shape, so they may show the same thing.

    Confidence: medium. The configuration difference is confirmed in code. I did not run an Android device repro, so I can't prove from source alone which of enableEdgeToEdgeBottomSafeAreaPadding vs shouldEnableMaxHeight is the one that pushes the banner fully behind the keyboard.

    Related issues: a quick scan of open Expensify/App issues found no duplicate or closely related report.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/101035) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run · no recording available

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 13, 2026
  5. melvin-bot commented on Sep 13, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

  6. melvin-bot commented on Sep 13, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  7. Mister124x commented on Sep 14, 2026

    @Mister124x

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When creating an expense on Android, tapping the "To" field opens the software keyboard, causing the Referral Banner ( ooterContent in SelectionList) to be hidden behind the keyboard, whereas in the "Start Chat" flow the banner correctly pushes up and stays visible above the keyboard.

    What is the root cause of that problem?

    In NewChatPage (src/pages/NewChatPage/index.tsx), the screen passes enableEdgeToEdgeBottomSafeAreaPadding={true} to ScreenWrapper. In ScreenWrapper, when enableEdgeToEdgeBottomSafeAreaPadding is enabled, shouldKeyboardOffsetBottomSafeAreaPadding evaluates to rue, which applies the correct bottom inset offset in KeyboardAvoidingView and keeps pinned ooterContent above the Android keyboard.

    In contrast, the Create Expense flow wraps its participant selector in StepScreenWrapper (src/pages/iou/request/step/StepScreenWrapper.tsx), which currently does not accept or forward enableEdgeToEdgeBottomSafeAreaPadding to the inner ScreenWrapper. As a result, ScreenWrapper defaults to enableEdgeToEdgeBottomSafeAreaPadding = false, disabling the keyboard offset calculation on Android and allowing the keyboard to render on top of the fixed footer banner.

    What changes do you think we should make in order to solve the problem?

    1. In src/pages/iou/request/step/StepScreenWrapper.tsx:

      • Extend StepScreenWrapperProps to accept optional enableEdgeToEdgeBottomSafeAreaPadding?: boolean and keyboardVerticalOffset?: number.
      • Forward enableEdgeToEdgeBottomSafeAreaPadding and keyboardVerticalOffset to the rendered .
    2. In src/pages/iou/request/step/DynamicIOURequestStepParticipants.tsx (and IOURequestStepParticipants.tsx):

      • Pass enableEdgeToEdgeBottomSafeAreaPadding={true} to .
    3. In src/pages/iou/request/ParticipantSearchResults.tsx:

      • Ensure �ddBottomSafeAreaPadding aligns with enableEdgeToEdgeBottomSafeAreaPadding (matching the pattern in DynamicWorkspaceInvitePage.tsx) so that the banner respects system navigation bars when the keyboard is dismissed.

    This aligns the Create Expense participant selection flow with NewChatPage and DynamicWorkspaceInvitePage, properly hoisting the footer banner above the Android keyboard.

    What alternative solutions did you explore? (Optional)

    • Wrapping ParticipantSelectorFooter in an additional custom KeyboardAvoidingView: Rejected because ScreenWrapper already encapsulates KeyboardAvoidingView and manages window/safe-area insets centrally; duplicating keyboard handlers causes layout jumping.
    • Modifying SelectionList's internal footer container: Rejected because keyboard avoidance is the responsibility of the screen-level container, not the generic list component.
  8. paulnjs commented on Sep 15, 2026

    @paulnjs
    Contributor

    I think Melvin’s root cause is wrong, issue occurred in ParticipantPicker/BaseParticipantPicker, not DynamicIOURequestStepParticipants/StepScreenWrapper missing edge-to-edge.

  9. Mister124x commented on Sep 15, 2026

    @Mister124x

    Proposal Update

    @paulnjs I cloned the repo and read the code before commenting. BaseParticipantPicker is not used in the Create Expense flow at all. DynamicIOURequestStepParticipants.tsx:150 renders <StepScreenWrapper>, not <BaseParticipantPicker>. You can verify this yourself:

    src/pages/iou/request/step/DynamicIOURequestStepParticipants.tsx:39  import StepScreenWrapper from './StepScreenWrapper';
    src/pages/iou/request/step/DynamicIOURequestStepParticipants.tsx:150 return (<StepScreenWrapper ...>
    

    BaseParticipantPicker (src/components/ParticipantPicker/BaseParticipantPicker.tsx:57-60) is a standalone modal picker used in contact/group flows. It already has enableEdgeToEdgeBottomSafeAreaPadding set — that is precisely why it works correctly. The bug is not there.

    The actual problem is that StepScreenWrapperProps (line 18-48 of StepScreenWrapper.tsx) does not expose enableEdgeToEdgeBottomSafeAreaPadding as a prop, so DynamicIOURequestStepParticipants has no mechanism to pass it through to the inner <ScreenWrapper> at line 71. Without that flag, shouldKeyboardOffsetBottomSafeAreaPadding at ScreenWrapper/index.tsx:135-141 evaluates to false, and the KeyboardAvoidingView applies zero bottom inset on Android, leaving the banner behind the keyboard.

    The fix is adding one prop to StepScreenWrapperProps and forwarding it — no other file needs to change its architecture.

  10. melvin-bot commented on Sep 16, 2026

    @melvin-bot

    @brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. 29 remaining items

  12. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  14. brunovjk commented on Oct 14, 2026

    @brunovjk
    Contributor

    Contributor+ Checklist:

    Regression Test Proposal

    Test:

    1. Log in with a new account that has a Control workspace
    2. Tap FAB > Create expense
    3. Tap the "To" field, then close and reopen the keyboard
    4. Verify the referral banner shows above the keyboard
    5. Close the keyboard and verify the banner is back at the bottom
    6. Tap FAB > Start chat > "To" field and verify the banner behaves the same way

    Do we agree 👍 or 👎

  15. brunovjk commented on Oct 14, 2026

    @brunovjk
    Contributor

    C+ Summary

    • Fix: PR #102196 updates keyboard avoidance, bottom inset handling, and maxHeight in the recipient picker to keep the referral banner visible.

    • People involved: @yusufdeveloper2903 implemented the fix; @brunovjk reviewed and provided platform testing evidence, and @jasperhuangg reviewed and approved.

    • Production deployment: Deployed on 2026-10-07 in version 9.5.4-3: production confirmation and deployment checklist #103248.

    • Regressions and follow-ups: No regressions, reverts, or corrective follow-ups attributable to this fix were identified in the GitHub sources reviewed.

    • Suggested payment: $175

    cc: @mallenexpensify.

  16. yusufdeveloper2903 commented on Oct 14, 2026

    @yusufdeveloper2903
    Contributor

    @brunovjk @jasperhuangg Melvin couldn't solve this one, so I did with my proposal (#102196). Under the current flow, an issue gets Help Wanted when Melvin can't fix it, so I think this should be paid like a Help Wanted issue at $250. What do you think?

  17. mallenexpensify commented on Oct 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @yusufdeveloper2903 paid $250 via Upwork
    Contributor+: @brunovjk due $250 via NewDot

    @yusufdeveloper2903 can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022111158368132222502

  18. yusufdeveloper2903 commented on Oct 16, 2026

    @yusufdeveloper2903
    Contributor

    @mallenexpensify Thanks! I've accepted the job offer on Upwork

  19. mallenexpensify commented on Oct 16, 2026

    @mallenexpensify
    Contributor

    @yusufdeveloper2903 paid, summary updated above. Thx.

  20. laurenreidexpensify commented on Oct 20, 2026

    @laurenreidexpensify
    Contributor

    Approved @brunovjk $250 via New Expensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions