You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-05] Support Enter in the search filters popover #101595
changed the title [-]Support `Enter` in the search filters popover[/-][+][Due for payment 2026-10-05] Support `Enter` in the search filters popover[/+]on Sep 28, 2026
⚠️ Looks like this issue was linked to a Deploy Blocker #102192
@aimane-chnaif this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
Melvin investigation linked this issue as evidence that the PR from this issue is not the culprit behind the linked Deploy Blocker.
No other PR in the checklist touches the natural-language search path. #101575 (Search query resolution) and #101759 (Enter-to-submit) touch Search, but neither introduces the describe/parse flow — #101759 merged at 13:57Z, after the staging build was cut.
Can we find a way so Melvin won't link many unrelated PR's on their investigation to avoid this false DB alert? 😅
(I think adding www to the link won't link the issue)
Also, the Deploy Blocker comment can be hidden until we press Load more. What about when an issue is linked to a Deploy Blocker, a new label is applied to the issue, so C+ know there is something to address, then after they address them all, they can manually take the label off.
I know melvin-bot and MelvinBot is completely different workflow.
I think we can safely replace that melvin-bot automation with MelvinBot because Melvin now assigns correct people after investigating deploy blockers. We can let MelvinBot post on the linked issue instead after he confirmed the offending PR.
@MelvinBot review this comment above, it's triggered from this comment on another issue. We want to update the process so that the comments, like the one on this issue, are only posted on this issue if the "Causing PR" is linked, no other links in that post. Is that possible? If so, what's needed?
melvin-bot saw the PR link and posted the warning here. It does not check whether the link is the Causing PR.
You can fix this in one of two ways:
Change the summary format (small change). Update MelvinBot's deploy-blocker summary template so the Causing PR is the only link. Other PRs and issues become plain, unlinked text, for example \#101759. The trade-off is that readers can't click through to those references.
Change the melvin-bot trigger. Make it act only on the PR in the **Causing PR**: line. This logic is internal, so an internal engineer needs to change it.
The first option fixes MelvinBot's summaries only. If a person pastes PR links into a deploy blocker, the warning still fires. Only the second option fixes that. If you want the first option, I can open a PR for it.
Change the melvin-bot trigger. Make it act only on the PR in the Causing PR: line. This logic is internal, so an internal engineer needs to change it.
@MelvinBot It's possible that the other links are helpful so I think the above is best. Create an issue with E/E and provide additional details that might be helpful that should only be shared internally.
Done. I created an internal issue for changing the melvin-bot trigger and put the internal-only details there.
One more finding: the warning goes to every linked issue, not just the issues behind linked PRs. That's why the issues under "Related Issues" and the deploy checklist on the deploy blocker also got the warning.
Activity
bernhardoj commentedon Sep 20, 2026
@JS00001 Does this apply to a text-input-based filter (e.g., merchant, description) only?
JS00001 commentedon Sep 21, 2026
I believe so, yes
bernhardoj commentedon Sep 21, 2026
Cool, PR is ready
cc: @aimane-chnaif
melvin-bot commentedon Sep 24, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Support `Enter` in the search filters popover[/-][+][Due for payment 2026-10-05] Support `Enter` in the search filters popover[/+]10 remaining items
melvin-bot commentedon Oct 4, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 4, 2026
Payment Summary
Resolving PRs:
Add enter shortcut to submit text-based search filters #101759
Reviewer: @bernhardoj owed $175 via NewDot
Reviewer: @aimane-chnaif owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 6, 2026
@aimane-chnaif this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
bernhardoj commentedon Oct 7, 2026
Can I help answer it?
It was not a regression.
Melvin investigation linked this issue as evidence that the PR from this issue is not the culprit behind the linked Deploy Blocker.
Here is the comment: #102192 (comment)
Can we find a way so Melvin won't link many unrelated PR's on their investigation to avoid this false DB alert? 😅
(I think adding
wwwto the link won't link the issue)Also, the Deploy Blocker comment can be hidden until we press Load more. What about when an issue is linked to a Deploy Blocker, a new label is applied to the issue, so C+ know there is something to address, then after they address them all, they can manually take the label off.
aimane-chnaif commentedon Oct 7, 2026
I know
melvin-botandMelvinBotis completely different workflow.I think we can safely replace that
melvin-botautomation withMelvinBotbecause Melvin now assigns correct people after investigating deploy blockers. We can let MelvinBot post on the linked issue instead after he confirmed the offending PR.mallenexpensify commentedon Oct 7, 2026
@MelvinBot review this comment above, it's triggered from this comment on another issue. We want to update the process so that the comments, like the one on this issue, are only posted on this issue if the "Causing PR" is linked, no other links in that post. Is that possible? If so, what's needed?
MelvinBot commentedon Oct 7, 2026
Yes, this is possible. The warning landed here by mistake, through this chain:
melvin-botsaw the PR link and posted the warning here. It does not check whether the link is the Causing PR.You can fix this in one of two ways:
\#101759. The trade-off is that readers can't click through to those references.melvin-bottrigger. Make it act only on the PR in the**Causing PR**:line. This logic is internal, so an internal engineer needs to change it.The first option fixes MelvinBot's summaries only. If a person pastes PR links into a deploy blocker, the warning still fires. Only the second option fixes that. If you want the first option, I can open a PR for it.
mallenexpensify commentedon Oct 8, 2026
@MelvinBot It's possible that the other links are helpful so I think the above is best. Create an issue with E/E and provide additional details that might be helpful that should only be shared internally.
mallenexpensify commentedon Oct 8, 2026
Payment Summary
Contributor: @bernhardoj due $250 via NewDot
Contributor+: @aimane-chnaif due $250 via NewDot
MelvinBot commentedon Oct 8, 2026
Done. I created an internal issue for changing the
melvin-bottrigger and put the internal-only details there.One more finding: the warning goes to every linked issue, not just the issues behind linked PRs. That's why the issues under "Related Issues" and the deploy checklist on the deploy blocker also got the warning.
flaviadefaria commentedon Oct 9, 2026
Approved: @bernhardoj due $250 via NewDot
garrettmknight commentedon Oct 12, 2026
$250 approved for @aimane-chnaif