Skip to content

[Due for payment 2026-10-05] Support Enter in the search filters popover #101595

Closed

Description

@JS00001

Coming from https://expensify.slack.com/archives/C05LX9D6E07/p1789743257762129, lets support pressing Enter when you are in a search input within the a specific filters' popover. Pressing enter should close the popover and apply the filter to the query

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. bernhardoj commented on Sep 20, 2026

    @bernhardoj
    Contributor

    @JS00001 Does this apply to a text-input-based filter (e.g., merchant, description) only?

  2. JS00001 commented on Sep 21, 2026

    @JS00001
    ContributorAuthor

    I believe so, yes

  3. bernhardoj commented on Sep 21, 2026

    @bernhardoj
    Contributor

    Cool, PR is ready

    cc: @aimane-chnaif

  4. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  5. changed the title [-]Support `Enter` in the search filters popover[/-] [+][Due for payment 2026-10-05] Support `Enter` in the search filters popover[/+] on Sep 28, 2026
  6. 10 remaining items

  7. melvin-bot commented on Oct 4, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  8. melvin-bot commented on Oct 4, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  9. mallenexpensify commented on Oct 6, 2026

    @mallenexpensify
    Contributor

    ⚠️ Looks like this issue was linked to a Deploy Blocker #102192

    @aimane-chnaif this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.

  10. bernhardoj commented on Oct 7, 2026

    @bernhardoj
    Contributor

    Can I help answer it?

    It was not a regression.

    Melvin investigation linked this issue as evidence that the PR from this issue is not the culprit behind the linked Deploy Blocker.

    No other PR in the checklist touches the natural-language search path. #101575 (Search query resolution) and #101759 (Enter-to-submit) touch Search, but neither introduces the describe/parse flow — #101759 merged at 13:57Z, after the staging build was cut.

    Here is the comment: #102192 (comment)

    Can we find a way so Melvin won't link many unrelated PR's on their investigation to avoid this false DB alert? 😅
    (I think adding www to the link won't link the issue)

    Also, the Deploy Blocker comment can be hidden until we press Load more. What about when an issue is linked to a Deploy Blocker, a new label is applied to the issue, so C+ know there is something to address, then after they address them all, they can manually take the label off.

  11. aimane-chnaif commented on Oct 7, 2026

    @aimane-chnaif
    Contributor

    I know melvin-bot and MelvinBot is completely different workflow.
    I think we can safely replace that melvin-bot automation with MelvinBot because Melvin now assigns correct people after investigating deploy blockers. We can let MelvinBot post on the linked issue instead after he confirmed the offending PR.

  12. mallenexpensify commented on Oct 7, 2026

    @mallenexpensify
    Contributor

    @MelvinBot review this comment above, it's triggered from this comment on another issue. We want to update the process so that the comments, like the one on this issue, are only posted on this issue if the "Causing PR" is linked, no other links in that post. Is that possible? If so, what's needed?

  13. MelvinBot commented on Oct 7, 2026

    @MelvinBot
    Contributor

    Yes, this is possible. The warning landed here by mistake, through this chain:

    1. My summary on Describe search - Oops... Something went wrong shown when searching on Reports linked Add enter shortcut to submit text-based search filters, but only to rule it out as the cause.
    2. That PR lists this issue under "Fixed Issues."
    3. melvin-bot saw the PR link and posted the warning here. It does not check whether the link is the Causing PR.

    You can fix this in one of two ways:

    • Change the summary format (small change). Update MelvinBot's deploy-blocker summary template so the Causing PR is the only link. Other PRs and issues become plain, unlinked text, for example \#101759. The trade-off is that readers can't click through to those references.
    • Change the melvin-bot trigger. Make it act only on the PR in the **Causing PR**: line. This logic is internal, so an internal engineer needs to change it.

    The first option fixes MelvinBot's summaries only. If a person pastes PR links into a deploy blocker, the warning still fires. Only the second option fixes that. If you want the first option, I can open a PR for it.

  14. mallenexpensify commented on Oct 8, 2026

    @mallenexpensify
    Contributor

    Change the melvin-bot trigger. Make it act only on the PR in the Causing PR: line. This logic is internal, so an internal engineer needs to change it.

    @MelvinBot It's possible that the other links are helpful so I think the above is best. Create an issue with E/E and provide additional details that might be helpful that should only be shared internally.

  15. mallenexpensify commented on Oct 8, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @bernhardoj due $250 via NewDot
    Contributor+: @aimane-chnaif due $250 via NewDot

  16. MelvinBot commented on Oct 8, 2026

    @MelvinBot
    Contributor

    Done. I created an internal issue for changing the melvin-bot trigger and put the internal-only details there.

    One more finding: the warning goes to every linked issue, not just the issues behind linked PRs. That's why the issues under "Related Issues" and the deploy checklist on the deploy blocker also got the warning.

  17. flaviadefaria commented on Oct 9, 2026

    @flaviadefaria
    Contributor

    Approved: @bernhardoj due $250 via NewDot

  18. garrettmknight commented on Oct 12, 2026

    @garrettmknight
    Contributor

    $250 approved for @aimane-chnaif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions