You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-23] MARKED_REIMBURSED sibling PAY check does not use the Search snapshot's report actions #102105
Search takes a different path. getReportActionsSections iterates report actions out of the SearchResults.data snapshot and calls isReportActionVisible with them:
That snapshot is never passed down to the sibling lookup. So for a CHAT search result whose report timeline has not been loaded into the normal Onyx collection, getAllReportActions returns an empty collection, the helper returns false early, and the redundant MARKED_REIMBURSED row still renders next to its PAY sibling in search results.
Proposed fix
Thread the caller's report-action collection into hasSiblingPayReportAction (and through isReportActionVisible / shouldReportActionBeVisible) instead of relying solely on the global Onyx connection, so the search snapshot is used when present.
Notes
This is not a regression — before the PR the duplicate showed everywhere, so search is no worse than the original bug. It's only the one surface the new check doesn't cover yet.
🤖 Draft PR created: #103301
Please mark it as "Ready for review" or ask me to do that for you when it is ready for review.
What changed: The MARKED_REIMBURSED sibling PAY check now uses the Search snapshot's report actions when the report's timeline isn't loaded into Onyx. Reports already loaded into Onyx behave as before.
hasSiblingPayReportAction takes an optional fallback collection and uses it only when the action isn't in Onyx.
shouldReportActionBeVisible and isReportActionVisible forward an optional reportActions argument.
getReportActionsSections passes the snapshot's report actions for each report.
Tests: I added two unit tests. They fail without the fix and pass with it. Lint, typecheck, format, spellcheck, and the related test suites pass. I didn't run a manual UI check. Reproducing it needs a report with a stale OldDot MARKED_REIMBURSED plus a PAY action, which isn't available on a dev account. The human co-author still needs to fill in the Tests and QA sections.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
As a workspace admin, go to Workspace > Workflows and set up Payments with a verified business bank account.
As an employee, submit an expense to the workspace.
As the admin, approve the report, then pay it with Pay $X as a business using the workspace business bank account.
Open the report and verify it shows the "paid with bank account XXXX" report action comment.
Go to Account > Troubleshoot > Clear cache and restart > Reset and refresh.
Without opening the report, go to Spend > Filters > Type > Chat.
Verify that the paid report shows only the "paid with bank account XXXX" row, with no extra "marked as paid" row next to it.
Activity
huult commentedon Oct 2, 2026
@roryabraham Could you take a look at this PR when you have time?
roryabraham commentedon Oct 5, 2026
Issue seems reasonable @huult. I don't see a PR yet
huult commentedon Oct 6, 2026
@roryabraham Just to confirm, would you like me to open a PR for this issue?
roryabraham commentedon Oct 6, 2026
yes
huult commentedon Oct 7, 2026
@MelvinBot Please implement this ticket.
MelvinBot commentedon Oct 7, 2026
🤖 Draft PR created: #103301
Please mark it as "Ready for review" or ask me to do that for you when it is ready for review.
What changed: The
MARKED_REIMBURSEDsiblingPAYcheck now uses the Search snapshot's report actions when the report's timeline isn't loaded into Onyx. Reports already loaded into Onyx behave as before.hasSiblingPayReportActiontakes an optional fallback collection and uses it only when the action isn't in Onyx.shouldReportActionBeVisibleandisReportActionVisibleforward an optionalreportActionsargument.getReportActionsSectionspasses the snapshot's report actions for each report.Tests: I added two unit tests. They fail without the fix and pass with it. Lint, typecheck, format, spellcheck, and the related test suites pass. I didn't run a manual UI check. Reproducing it needs a report with a stale OldDot
MARKED_REIMBURSEDplus aPAYaction, which isn't available on a dev account. The human co-author still needs to fill in the Tests and QA sections.7 remaining items
ikevin127 commentedon Oct 17, 2026
BugZero Checklist
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/95015/changes#diff-b8041d6cb129cc7b8a6223f8ffa570e79c326d8ea4affbad35c33cf6c8ea660dR1897
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Do we agree 👍 or 👎.
melvin-bot commentedon Oct 22, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 22, 2026
Payment Summary
Resolving PRs:
[No QA] fix: hide redundant MARKED_REIMBURSED row in Search when sibling PAY #103418
Reviewer: @huult owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 26, 2026
Payment Summary
Contributor: @huult due $175 via NewDot
Contributor+: @ikevin127 due $175 via NewDot
ikevin127 commentedon Oct 26, 2026
@mallenexpensify Huult was author, I was reviewer, we're both due payment here 🙌
mallenexpensify commentedon Oct 26, 2026
@ikevin127 paid, summary updated above. Thx. Apologies for missing ya
quinthar commentedon Oct 27, 2026
Approved $175 to @ikevin127
JmillsExpensify commentedon Nov 14, 2026
$175 approved for @huult