Skip to content

[Due for payment 2026-10-05] Log the reason for every sign-out #102131

Closed

Description

@mountiny

Problem

Every sign-out in the App logged the same generic line, whatever triggered it. When a user reported an unexpected sign-out, the logs could not tell a deliberate sign-out from a reauthentication network error, a SAML requirement, a revoked device, a deleted account, or an OldDot link signing the previous user out. That made sign-out reports hard to investigate.

Solution

clearStorageAndRedirect in src/libs/actions/SignInRedirect.ts now logs the signOutReason it received, so every sign-out path records why it happened. The two transition paths, AuthScreensInitHandler and LogOutPreviousUserPage, log an extra line that also says whether the link named a copilot account, whether the current session was a copilot session, and whether the transition was a support session.

PR

#101882

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. mountiny commented on Sep 24, 2026

    @mountiny
    ContributorAuthor

    @parasharrajat I think this did not require C+ and no recordings were made, I assume the reward should be smaller

  2. parasharrajat commented on Sep 24, 2026

    @parasharrajat
    Member

    Yes it will be half.

  3. changed the title [-]Log the reason for every sign-out[/-] [+][Due for payment 2026-10-05] Log the reason for every sign-out[/+] on Sep 28, 2026
  4. melvin-bot commented on Sep 28, 2026

    @melvin-bot

    @parasharrajat

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.94-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-05. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  5. 1 remaining item

  6. parasharrajat commented on Oct 4, 2026

    @parasharrajat
    Member

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: NA
      Link to the comment on the Issue: NA

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/689467

    Regression Test Proposal

    Internal change, not needed.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-b119-a5a3-64ad-039a1b14d244
  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 4, 2026
  8. melvin-bot commented on Oct 4, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  9. melvin-bot commented on Oct 4, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  10. mallenexpensify commented on Oct 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @parasharrajat due $100 via NewDot

    Tests weren't needed on Reviewers Checklist on PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions