Skip to content

Describe search- Keyword search is applied instead of Tag when searching for expense with tag #102201

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.93-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94217
Email or phone of affected tester (no customers): jsdoijnodsdisojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Search

Action Performed:

Precondition:

  • Create a tag named Apple.
  1. Go to staging.new.expensify.com
  2. Go to Spend > Expenses.
  3. Open Filters > Describe your search.
  4. Type find expenses with Apple tag > click Apply.

Expected Result:

tag:apple filter will be applied.

Actual Result:

keyword:apple is applied instead.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7268244_1790256358536.9.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7268244

Activity

  1. applause-bot commented on Sep 24, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/3a18d8fa16bd0007ee3c30735d4ce55f1dccb3e6d1dc43c5f5e65aa2616716c8

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 24, 2026
  3. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #94217

  4. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    @carlosmiceli @truph01 you have been assigned to this deploy blocker because you reviewed the offending PR: #94217

  5. github-actions commented on Sep 24, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    @marcaaron you have been assigned to this deploy blocker because you authored the offending PR: #94217

  7. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Sep 24, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug (App PR shipped the feature; the parsing itself happens server-side)
    Causing PR: [Payment due @truph01] Add natural language filter entry point to Spend page - by @marcaaron (High confidence that this PR introduced the feature; Medium confidence that the misclassification itself is fixable in App)
    Related Issues: Spend - "Apply" button is not disabled with empty input on "Describe your search" (same feature, same PR)

    Recommendation: REVERT

    "Describe your search" is a brand-new, self-contained entry point that only reached staging in this deploy, and the natural-language parse it depends on does not currently resolve tag names (it falls back to keyword:), so reverting the App entry point is the cleanest way to unblock the deploy and re-ship once tag support is in place.

    Assigned: @marcaaron (PR author), @truph01 and @carlosmiceli (approving reviewers) from the causing PR
    Labels: No changes. DeployBlockerCash is kept (an App PR shipped the broken feature and the issue is not reproducible in production). DeployBlocker was not present, so nothing was removed.

    📋 Detailed Analysis

    Evidence

    Verification

    Affected files, all added/changed by #94217:

    Confirmed via gh pr view 94217 --json files that both files are in the PR's file list.

    Root Cause

    The App does not classify anything here — it is a pass-through. It sends only nlQuery, policyID and today, then takes the query string straight out of the URL the server returns:

    const searchQuery = new URL(result.searchURL).searchParams.get('q') ?? '';
    onSuccess(ROUTES.SEARCH_ROOT.getRoute({query: searchQuery}));

    So keyword:apple is what came back from the parse — the App did not downgrade a tag: filter. That is corroborated by SearchQueryUtils.ts#L1748-L1751, where tag: values are deliberately passed through unvalidated, so a returned tag:apple would have survived intact into the applied filters.

    This appears to be a backend/internal issue. A separate internal investigation is needed.

    Two App-side details worth checking while that happens:

    1. The only workspace context the App gives the parser is a single policyID, derived at SearchNLFilterContent.tsx#L61-L62: the policyID filter from the current query if present, otherwise the active-policy NVP. On Spend > Expenses there is normally no policyID filter, so if the tester's active policy is unset (or is not the workspace that owns the "Apple" tag), the parse runs with no workspace context and has no tag list to match against — which would produce exactly this keyword fallback.
    2. The PR's own test plan exercises semantic category matching and the keyword fallback for unmatched categories; there is no tag case anywhere in the Tests or QA Steps, which is consistent with tags never having been wired into the parse.

    Alternative if the parse can be fixed server-side within the deploy window: roll forward instead, since that requires no App change. Reverting #94217 is recommended as the default because it is self-contained (new route, new screen, new entry point) with no dependent PRs on the checklist, and it removes the broken UX from this deploy with certainty.

  9. 15 remaining items

  10. melvin-bot commented on Sep 30, 2026

    @melvin-bot

    @marcaaron Eep! 4 days overdue now. Issues have feelings too...

  11. melvin-bot commented on Oct 2, 2026

    @melvin-bot

    @marcaaron Still overdue 6 days?! Let's take care of this!

  12. melvin-bot commented on Oct 3, 2026

    @melvin-bot

    @marcaaron 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  13. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    @marcaaron 10 days overdue. I'm getting more depressed than Marvin.

  14. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    @marcaaron this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  15. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    @marcaaron 12 days overdue now... This issue's end is nigh!

  16. melvin-bot commented on Oct 12, 2026

    @melvin-bot

    This issue has not been updated in over 14 days. @marcaaron eroding to Weekly issue.

  17. marcaaron commented on Nov 3, 2026

    @marcaaron
    Contributor

    I think this is fixed now. Doing a quick re-test before closing.

  18. marcaaron commented on Nov 3, 2026

    @marcaaron
    Contributor

    Retested on the current build with the real parser, using the exact wording from the report. "find expenses with Apple tag" now applies tag:Apple instead of a keyword search. It worked 3 out of 3 times. The tag keeps the capitalization it has in the workspace (Apple, not apple).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions