You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-13] [SelectionList ListItem] Cleanup — Remove dead ListItem props #102257
Shrinks the ListItem / SelectionList prop surface by deleting props that are never set or never read, and collapsing redundant ones.
Removes (dead):
style, isHovered, onHoldMenuOpen — never set or read.
titleContainerStyles / style.listItemTitleContainerStyles, errorRowStyles / style.listItemErrorRowStyles — no app callers, no variant reads them.
index prop and item.index — forwarded, never read.
onInputBlur — never set.
isOffline — only Picked by Search; declare it there directly.
onLongPressRow, shouldHighlightSelectedItem (list-level and ListItemProps) — keep only where Search rows set them.
isSelected, accessibilityRole, shouldUseOptionRole, pressableStyle, pressableWrapperStyle, containerStyle, hoverStyle, accessible, accessibilityLabel — never supplied by the renderer; move to ListItemPressableProps only.
forwardedFSClass on SelectableListItem, list-level onSelectionButtonPress on the sections list — no callers.
Item fields shouldHideAlternateText, sectionIndex, badgeText, cursorStyle, shouldShowSubscript, isMultilineSupported, isAlternateTextMultilineSupported, groupID, categoryID — no list reader. Delete SpendCategorySelectorListItem (sole groupID reader, no production renderer).
Merged and on staging.Chore/remove dead list item props merged Oct 5. It deployed to staging that evening in 9.5.3-0 and passed on web, Android, and iOS. It goes to production with the next release.
Three deploy blockers were auto-linked here this morning. Each investigation traced its blocker to an unrelated PR:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Scenario 1
Open app, create an expense on a workspace whose categories are nested (e.g. Travel: Flights: Domestic) and have long names.
Navigate to the expense Category picker.
Verify that child categories render indented under their parent, long names wrap.
Verify that the category is applied and the picker closes.
Scenario 2 (on mobile)
Open app on a phone-sized viewport, create an expense with a large amount and open Split expense with 6+ participants.
Navigate to the Amount tab and tap the amount input of the bottom row.
Verify that the list scrolls the tapped row above the keyboard and the row keeps its selected highlight.
@truph01 this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
⚠️ Looks like this issue was linked to a Deploy Blockerhere
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blockerhere
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blockerhere
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blockerhere
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Activity
melvin-bot commentedon Oct 6, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 6, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 6, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
MelvinBot commentedon Oct 6, 2026
Status update — 2026-10-06
Merged and on staging. Chore/remove dead list item props merged Oct 5. It deployed to staging that evening in 9.5.3-0 and passed on web, Android, and iOS. It goes to production with the next release.
Three deploy blockers were auto-linked here this morning. Each investigation traced its blocker to an unrelated PR:
Next: watch the production deploy and the 7-day regression window, then close this issue. Add
Skip Paymentto match the other sub-issues.Tracking: [$1000] [Tracking] SelectionList ListItem - Composition over Configuration
view run
melvin-bot commentedon Oct 6, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
6 remaining items
melvin-bot commentedon Oct 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 12, 2026
Payment Summary
Resolving PRs:
Chore/remove dead list item props #102254
Contributor: @jmusial does not require payment (Contractor)
Reviewer: @truph01 owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
truph01 commentedon Oct 14, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Scenario 1
Travel: Flights: Domestic) and have long names.Scenario 2 (on mobile)
Do we agree 👍 or 👎
mallenexpensify commentedon Oct 15, 2026
@truph01 this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
truph01 commentedon Oct 15, 2026
I didn't review the offending PR. #103128 (comment)
I didn't review the offending PR. #103131 (comment)
I didn't review the offending PR. #103133 (comment)
I didn't review the offending PR. #103171 (comment)
mallenexpensify commentedon Oct 16, 2026
Payment Summary
Contributor+: @truph01 due $175 via NewDot
garrettmknight commentedon Oct 19, 2026
$175 approved for @truph01