Skip to content

[Due for payment 2026-10-13] [SelectionList ListItem] Cleanup — Remove dead ListItem props #102257

Closed

Description

@MelvinBot

Part of the SelectionList ListItem — Composition over Configuration tracking effort. Based on draft PR Chore/remove dead list item props.

Cleanup — Remove dead ListItem props

Shrinks the ListItem / SelectionList prop surface by deleting props that are never set or never read, and collapsing redundant ones.

  • Removes (dead):
    • style, isHovered, onHoldMenuOpen — never set or read.
    • titleContainerStyles / style.listItemTitleContainerStyles, errorRowStyles / style.listItemErrorRowStyles — no app callers, no variant reads them.
    • index prop and item.index — forwarded, never read.
    • onInputBlur — never set.
    • isOffline — only Picked by Search; declare it there directly.
    • onLongPressRow, shouldHighlightSelectedItem (list-level and ListItemProps) — keep only where Search rows set them.
    • isSelected, accessibilityRole, shouldUseOptionRole, pressableStyle, pressableWrapperStyle, containerStyle, hoverStyle, accessible, accessibilityLabel — never supplied by the renderer; move to ListItemPressableProps only.
    • forwardedFSClass on SelectableListItem, list-level onSelectionButtonPress on the sections list — no callers.
    • Item fields shouldHideAlternateText, sectionIndex, badgeText, cursorStyle, shouldShowSubscript, isMultilineSupported, isAlternateTextMultilineSupported, groupID, categoryID — no list reader. Delete SpendCategorySelectorListItem (sole groupID reader, no production renderer).
  • Collapses:
    • 4 multiline props → titleNumberOfLines + alternateTextNumberOfLines (default 1, >1 wraps). isRowMultilineSupported (always true) → titleNumberOfLines={2}.
    • style.listItemTitleStyles → item.titleStyles.
    • style.listItemWrapperStyle → item.itemStyle (style order unchanged).
    • onInputFocus prop → SplitListItemType.onInputFocus, removing the SplitListItemWithInputFocus wrapper and its cast.
  • Expected behavior change: none — this is type and prop cleanup only.
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  2. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  3. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  4. MelvinBot commented on Oct 6, 2026

    @MelvinBot
    ContributorAuthor

    Status update — 2026-10-06

    Merged and on staging. Chore/remove dead list item props merged Oct 5. It deployed to staging that evening in 9.5.3-0 and passed on web, Android, and iOS. It goes to production with the next release.

    Three deploy blockers were auto-linked here this morning. Each investigation traced its blocker to an unrelated PR:

    Next: watch the production deploy and the 7-day regression window, then close this issue. Add Skip Payment to match the other sub-issues.

    Tracking: [$1000] [Tracking] SelectionList ListItem - Composition over Configuration


    view run

  5. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  6. 6 remaining items

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 7, 2026
  8. melvin-bot commented on Oct 12, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  9. melvin-bot commented on Oct 12, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  10. truph01 commented on Oct 14, 2026

    @truph01
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    Scenario 1

    1. Open app, create an expense on a workspace whose categories are nested (e.g. Travel: Flights: Domestic) and have long names.
    2. Navigate to the expense Category picker.
    3. Verify that child categories render indented under their parent, long names wrap.
    4. Verify that the category is applied and the picker closes.

    Scenario 2 (on mobile)

    1. Open app on a phone-sized viewport, create an expense with a large amount and open Split expense with 6+ participants.
    2. Navigate to the Amount tab and tap the amount input of the bottom row.
    3. Verify that the list scrolls the tapped row above the keyboard and the row keeps its selected highlight.

    Do we agree 👍 or 👎

  11. mallenexpensify commented on Oct 15, 2026

    @mallenexpensify
    Contributor

    @truph01 this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.

  12. truph01 commented on Oct 15, 2026

    @truph01
    Contributor

    ⚠️ Looks like this issue was linked to a Deploy Blocker here
    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
    If a regression has occurred and you are the assigned CM follow the instructions here.
    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

    I didn't review the offending PR. #103128 (comment)

    ⚠️ Looks like this issue was linked to a Deploy Blocker here
    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
    If a regression has occurred and you are the assigned CM follow the instructions here.
    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

    I didn't review the offending PR. #103131 (comment)

    ⚠️ Looks like this issue was linked to a Deploy Blocker here
    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
    If a regression has occurred and you are the assigned CM follow the instructions here.
    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

    I didn't review the offending PR. #103133 (comment)

    ⚠️ Looks like this issue was linked to a Deploy Blocker here
    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
    If a regression has occurred and you are the assigned CM follow the instructions here.
    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

    I didn't review the offending PR. #103171 (comment)

  13. mallenexpensify commented on Oct 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @truph01 due $175 via NewDot

  14. garrettmknight commented on Oct 19, 2026

    @garrettmknight
    Contributor

    $175 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions