Closed
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringImprovementItem broken or needs improvement.Item broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in review
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Navigate to https://staging.new.expensify.com/
- In the email field, enter a gmail email address for a new account.
- Press continue
- Verify there’s a message saying that a Magic Link has been sent to the email address
- Navigate to the email inbox of the account and open the validation email
- Copy the link and change it to staging.
- Navigate to the staging link
- Verify you’re brought to the “Set a Password” page
- Set a password that follows the password requirements
- After setting the password, verify the user is navigated to the main screen and Fub menu is open automatically
Expected Result:
The Fab menu opens automatically when log in with new account
Actual Results:##
The Fab menu does not open automatically when log in with new account
Workaround:
Unknkown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.87.8
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any new account
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Recording.880.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Metadata
Metadata
Assignees
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringImprovementItem broken or needs improvement.Item broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in review
Activity
melvin-bot commentedon Aug 3, 2022
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.robertjchen commentedon Aug 6, 2022
We are working on revamping this flow with the refactors, will revisit after those changes go out 🤔
melvin-bot commentedon Oct 18, 2022
Triggered auto assignment to @CortneyOfstad (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.27 remaining items
JmillsExpensify commentedon Oct 19, 2022
I'll assign myself them and keep track of the related PR.
[-]Log in - The Fab menu does not open automatically when log in with new account[/-][+][HOLD #11627] Log in - The Fab menu does not open automatically when log in with new account[/+]Beamanator commentedon Oct 20, 2022
Aah nice thanks for the link @luacmartins 👍
luacmartins commentedon Oct 20, 2022
@Beamanator the App PR was merged, but I noticed that Auth can return 0 or 1 instead of a bool, which makes the first part of this conditional fail. So I put up a fix here.
JmillsExpensify commentedon Oct 26, 2022
Given that both the linked PR that put this issue on hold is now on staging, and related, so is the PR fix mentioned immediately above, let's take this issue off hold, right?
JmillsExpensify commentedon Oct 26, 2022
I'm going to go ahead and do that @Beamanator and @luacmartins, and at that point we're just waiting for both PRs to hit production for this issue to close. Yeah?
[-][HOLD #11627] Log in - The Fab menu does not open automatically when log in with new account[/-][+]Log in - The Fab menu does not open automatically when log in with new account[/+]luacmartins commentedon Oct 26, 2022
@JmillsExpensify that's correct!
JmillsExpensify commentedon Oct 26, 2022
Awesome thank you!
luacmartins commentedon Oct 27, 2022
Both PRs are in prod. Closing this issue, please reopen if needed!