Skip to content

[Due for payment 2026-10-07] Expensify Card - Smart Limit description is shown in two lines when there is extra space #102610

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.97-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #101093
Email or phone of affected tester (no customers): jsdoijnodsdisojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable Expensify Card.
  • Assign Expensify card to any workspace member.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Expensfiy Card.
  3. Click on the card.
  4. Click Limit type.

Expected Result:

Smart Limit description should take a single line to make use of the wider RHP.

Actual Result:

Smart Limit description is shown in two lines when there is extra space on the wider RHP.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7273094

Issue OwnerCurrent Issue Owner: @huult

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 30, 2026
  2. applause-bot commented on Sep 30, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/5c168456fdf81937d2f67e6682782dc7e2acbf56aced9811c63f668e90a67546

  3. melvin-bot commented on Sep 30, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #101093

  4. melvin-bot commented on Sep 30, 2026

    @melvin-bot

    @mountiny @huult you have been assigned to this deploy blocker because you reviewed the offending PR: #101093

  5. github-actions commented on Sep 30, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Sep 30, 2026

    @melvin-bot

    @BartekObudzinski you have been assigned to this deploy blocker because you authored the offending PR: #101093

  7. melvin-bot commented on Sep 30, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Sep 30, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: feat: use floating RHP style on web. The auto-assignment is correct.

    Root cause: That PR widened the RHP from variables.sideBarWidth (375px) to a new variables.rhpWidth (440px). It missed one hardcoded width. BaseSelectListItem.tsx:49 still caps multiline alternate text using sideBarWidth. The cap is 303px, so the Smart Limit description wraps even though the wider RHP has about 368px free.

    Recommended fix: In BaseSelectListItem.tsx:49, replace variables.sideBarWidth with variables.rhpWidth. You can also remove the maxWidth cap, because the text container already uses flex1.

    Recommendation: demote and fix in a follow-up. Don't revert. Production shows the same two lines today, because the old RHP was 375px wide. This is cosmetic and not a regression. Reverting would undo a 31-file layout change to fix one line of text wrapping.

    Investigation details
    • The Limit type page passes alternateNumberOfSupportedLines={2} at DynamicExpensifyCardLimitTypePage.tsx:293. BaseSelectionList turns that into isAlternateTextMultilineSupported. That setting applies getMaximumWidth(alternateTextMaxWidth) at BaseSelectListItem.tsx:60-64.
    • The cap is 375 − 40 (padding) − 12 (margin) − 20 (icon) = 303px. The new 440px RHP leaves about 368px for the text.
    • The same cap affects every SelectionList or ValuePicker row with alternateNumberOfSupportedLines > 1 in the RHP. One example is the issue-new-card flow at LimitTypeStep.tsx:218. The one-line fix covers all of them.
    • The other recent commits to BaseSelectListItem.tsx came before this deploy. No other PR on the checklist fits.
    • This analysis comes from reading the code and checking the width math. It wasn't reproduced in a browser.

    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.


    view run

  9. huult commented on Sep 30, 2026

    @huult
    Contributor

    @BartekObudzinski Could you take a quick look at this deploy blocker?

  10. BartekObudzinski commented on Sep 30, 2026

    @BartekObudzinski
    Contributor

    Yes looking on it

  11. BartekObudzinski commented on Sep 30, 2026

    @BartekObudzinski
    Contributor

    the fix is ready @huult #102628

  12. IuliiaHerets commented on Sep 30, 2026

    @IuliiaHerets

    Chrome / v9.4.99-0
    Passed

    bandicam.2026-09-30.20-42-39-380.mp4
  13. changed the title [-]Expensify Card - Smart Limit description is shown in two lines when there is extra space[/-] [+][Due for payment 2026-10-07] Expensify Card - Smart Limit description is shown in two lines when there is extra space[/+] on Sep 30, 2026
  14. melvin-bot commented on Sep 30, 2026

    @melvin-bot

    @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-07. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions