You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Spend - SHIFT+click does not select the middle group when collapsed #102719
Version Number: 9.5.0-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98130 Email or phone of affected tester (no customers):jsdoijnodsdisojo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Search
Action Performed:
Precondition:
Create three expenses with different category.
Go to staging.new.expensify.com
Go to Spend > Expenses.
Click Display > Group by > Category > Apply.
Select the first group via checkbox.
Press SHIFT and select the third group via checkbox.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This isn't a regression. The PR adds Shift+click range selection to Search, but it only supports ranges across expense rows. A Shift+click on a group header is treated as a normal click, so only that one group is toggled. This happens whether the groups are collapsed or expanded.
Production has no Shift+click range selection, normal selection still works, and reverting would remove the whole feature. I suggest demoting this and fixing it in a follow-up. An engineer should decide whether to remove DeployBlockerCash.
Suggested fix: Let group headers pass shiftKey, store the last group header clicked as the range anchor, and select every group between the anchor and the clicked header. Include collapsed groups, and select each one the same way a single header click does.
Evidence
All links use App commit eae59e1, after the merge. Every line cited was added by the causing PR.
This is expected behaviour, not a regression. Design decided how group header checkboxes should behave under Shift on the issue: "Clicking section or all checkbox just works like they do normally", and holding Shift ranges only between expenses, ignoring section headers. Danny agreed to go with that "at least to start". So a Shift+click on the third group's header toggles that group, exactly like a plain click. This is pinned by a unit test in LazyGroupSelectionTest.
The suggested fix above by Melvin (ranging from header to header, collapsed groups included) is Option 1 from that discussion, which design decided against. If design wants to revisit it, it should be a separate feature request rather than a deploy blocker.
Also not sure why it's reported on native there is no Shift key, so the Android and iOS App results are the normal header toggle that production already has.
Activity
melvin-bot commentedon Oct 1, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #98130
applause-bot commentedon Oct 1, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/93c3b67c21a16a9f81bb6021f5e508152cbafee12cb899f254ad60d741785628
melvin-bot commentedon Oct 1, 2026
@stitesExpensify @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #98130
melvin-bot commentedon Oct 1, 2026
@TaduJR you have been assigned to this deploy blocker because you authored the offending PR: #98130
melvin-bot commentedon Oct 1, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 1, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 1, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: feat: Extend shift+click range selection to Search results and report transaction lists by
TaduJR(high confidence)Related issue: [$250] New Feature : Shift+Click Range Selection Not Supported in Multi-Select Lists
Recommendation: Demote, then fix forward
This isn't a regression. The PR adds Shift+click range selection to Search, but it only supports ranges across expense rows. A Shift+click on a group header is treated as a normal click, so only that one group is toggled. This happens whether the groups are collapsed or expanded.
Production has no Shift+click range selection, normal selection still works, and reverting would remove the whole feature. I suggest demoting this and fixing it in a follow-up. An engineer should decide whether to remove
DeployBlockerCash.Suggested fix: Let group headers pass
shiftKey, store the last group header clicked as the range anchor, and select every group between the anchor and the clicked header. Include collapsed groups, and select each one the same way a single header click does.Evidence
All links use App commit
eae59e1, after the merge. Every line cited was added by the causing PR.view run
TaduJR commentedon Oct 1, 2026
This is expected behaviour, not a regression. Design decided how group header checkboxes should behave under Shift on the issue: "Clicking section or all checkbox just works like they do normally", and holding Shift ranges only between expenses, ignoring section headers. Danny agreed to go with that "at least to start". So a Shift+click on the third group's header toggles that group, exactly like a plain click. This is pinned by a unit test in
LazyGroupSelectionTest.The suggested fix above by Melvin (ranging from header to header, collapsed groups included) is Option 1 from that discussion, which design decided against. If design wants to revisit it, it should be a separate feature request rather than a deploy blocker.
Also not sure why it's reported on native there is no Shift key, so the Android and iOS App results are the normal header toggle that production already has.
cc @Expensify/design for viz, and closing.
TaduJR commentedon Oct 1, 2026
@mitarachim
Please update the TC as well.
Thanks.