You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$175] Biometrics-"Request a new code" message display instead Didn't receive a magic code? #102726
Version Number: v9.5.0-0 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod - Provide reasoning. If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102137 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Android 16 / Honor x6b App Component: Other
Action Performed:
Precondition: Device must have a system-level Screen Lock (PIN/Pattern) and Biometrics (Fingerprint or FaceID)
Open the Expensify app
Tap the screen with 4 fingers simultaneously to bring up the hidden Test Tool menu
Locate Biometrics row
Tap "Test" button
Enter the incorrect Magic Code
Verify the error appears and the user stays on the magic code screen (not redirected to the Verification failed screen)
Verify the "Didn't receive a magic code?" option appears and the user can request a new Magic Code and continue the verification
Expected Result:
The “Didn't receive a magic code?” message should be displayed
Actual Result:
“Request a new code” message is shown instead of “Didn't receive a magic code?” message.
The "Request a new code" link works. Tapping it sends a new code, and the label switches back once you start typing.
Recommended Fix: Close this issue and update step 7 of the PR's QA steps to: "After the 30-second countdown, verify the Request a new code link appears, and tapping it sends a new code you can use to finish verification."
If product wants "Didn't receive a security code?" to show even with an error, change ValidateCodeResendButton.tsx:75 to always render translate(resendButtonText). That makes MFA differ from sign-in, so it needs a product decision first.
Investigation details
How the label is chosen. The MFA validate code page passes hasError to its own resend button. It doesn't use the shared ValidateCodeActionForm. The resend button behaves like this:
For the first 30 seconds (isCountdownRunning starts true), it shows a countdown you can't press: "Request a new code in 00:XX".
After the countdown, it shows "Request a new code" if there is an error, or "Didn't receive a security code?" if there isn't.
Why this only shows up now. Before the PR, a wrong code was stored as a fatal error, which redirected to "Verification failed". After the fix it's stored as a continuableError, so the user stays on the screen. The error-state label is now visible for the first time.
Inconsistency to note. The shared ValidateCodeActionForm always shows "Didn't receive a security code?", even with an error. It's used for contact method verification and account merging. MFA matches sign-in, not this form.
Open question. QA may have seen the 30-second countdown text, not the error-state link. The PR description already lists that countdown as a separate issue. A screenshot would settle it.
Next Steps for Contributor+ team: To accept: Close this issue and update the QA steps. If product prefers the alternate label, reply @MelvinBot implement [this](https://github.com/Expensify/App/blob/4e2b30d96ac50d36aae5c455b406251e337a9379/src/components/MultifactorAuthentication/ValidateCodeResendButton.tsx#L75) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Biometrics-"Request a new code" message display instead Didn't receive a magic code?[/-][+][$175] Biometrics-"Request a new code" message display instead Didn't receive a magic code?[/+]on Oct 1, 2026
The error message Didn't receive a magic code? is no longer available in the source code, and the initial implementation has used request a new code when error. So this is a mistake in the QA test step so we can close this issue and update the test step of PR
Activity
applause-bot commentedon Oct 1, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/10e844eb4e5e981d210c8c9de5921c0c0d56582b2f9ec90ff244d58530f677af
MelvinBot commentedon Oct 1, 2026
Issue Analysis
Root Cause: This is expected behavior, not a regression. The MFA resend button shows "Request a new code" on purpose while a wrong-code error is displayed:
ValidateCodeResendButton.tsx:75. Sign-in uses the same logic (BaseValidateCodeForm.tsx:418). The test step in Match the backend Invalid validateCode message so a wrong magic code stays retryable is out of date. Also, no screen says "Didn't receive a magic code?" anymore. That copy is now "Didn't receive a security code?" (en.ts:3431).The "Request a new code" link works. Tapping it sends a new code, and the label switches back once you start typing.
Recommended Fix: Close this issue and update step 7 of the PR's QA steps to: "After the 30-second countdown, verify the Request a new code link appears, and tapping it sends a new code you can use to finish verification."
If product wants "Didn't receive a security code?" to show even with an error, change
ValidateCodeResendButton.tsx:75to always rendertranslate(resendButtonText). That makes MFA differ from sign-in, so it needs a product decision first.Investigation details
How the label is chosen. The MFA validate code page passes
hasErrorto its own resend button. It doesn't use the sharedValidateCodeActionForm. The resend button behaves like this:isCountdownRunningstartstrue), it shows a countdown you can't press: "Request a new code in 00:XX".Why this only shows up now. Before the PR, a wrong code was stored as a fatal error, which redirected to "Verification failed". After the fix it's stored as a
continuableError, so the user stays on the screen. The error-state label is now visible for the first time.The label has been intentional since 2023. Fix - modified magic code link redirects to welcome screen with first place of magic code green added it to sign-in. Its test step reads: "Verify that after the error occurred
Request a new codeis shown instead ofDidn't receive magic code". The MFA button copied that logic when it was created.Inconsistency to note. The shared
ValidateCodeActionFormalways shows "Didn't receive a security code?", even with an error. It's used for contact method verification and account merging. MFA matches sign-in, not this form.Open question. QA may have seen the 30-second countdown text, not the error-state link. The PR description already lists that countdown as a separate issue. A screenshot would settle it.
Related issues: [$175] Mobile Biometrics - Enter incorrect Magic Code redirect to verification failed screen (the original bug the PR fixes).
Next Steps for Contributor+ team:
To accept: Close this issue and update the QA steps. If product prefers the alternate label, reply
@MelvinBot implement [this](https://github.com/Expensify/App/blob/4e2b30d96ac50d36aae5c455b406251e337a9379/src/components/MultifactorAuthentication/ValidateCodeResendButton.tsx#L75)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
melvin-bot commentedon Oct 1, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)[-]Biometrics-"Request a new code" message display instead Didn't receive a magic code?[/-][+][$175] Biometrics-"Request a new code" message display instead Didn't receive a magic code?[/+]melvin-bot commentedon Oct 1, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022105552196095314758
camesenin commentedon Oct 1, 2026
Julesssss commentedon Oct 1, 2026
Assigning @NikkiWines and @suneox from #102137 (comment)
camesenin commentedon Oct 1, 2026
camesenin commentedon Oct 1, 2026
camesenin commentedon Oct 1, 2026
melvin-bot commentedon Oct 1, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
suneox commentedon Oct 2, 2026
It looks like the QA step is invalid, so I'll double check shortly.
NikkiWines commentedon Oct 2, 2026
@suneox what's the latest here?
suneox commentedon Oct 2, 2026
The error message
Didn't receive a magic code?is no longer available in the source code, and the initial implementation has used request a new code when error. So this is a mistake in the QA test step so we can close this issue and update the test step of PRmelvin-bot commentedon Oct 5, 2026
@suneox Whoops! This issue is 2 days overdue. Let's get this updated quick!
suneox commentedon Oct 6, 2026
@NikkiWines Can I close this issue based on the explanation above?
NikkiWines commentedon Oct 6, 2026
Yep, i see you updated the PR steps, so this is fine to close.