Skip to content

[Due for payment 2026-10-12] Payment issue for E/App PR#102321 #103101

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #102321
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @truph01.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Oct 5, 2026

    @melvin-bot
    Author

    @truph01 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. melvin-bot commented on Oct 9, 2026

    @melvin-bot
    Author

    @truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  3. melvin-bot commented on Oct 11, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  4. melvin-bot commented on Oct 11, 2026

    @melvin-bot
    Author

    Payment Summary

    • Reviewer: @truph01 owed $175 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  5. mallenexpensify commented on Oct 14, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @truph01 due $250 via NewDot
    Contributor+: @situchan due $250 via NewDot

    @truph01 plz complete the Contributor+ checklist and tag me in a post once you have. if this is part of a project that started before 2026-09-19, link me to the tracking/main issue and I'll bump to $250. Thx

    @situchan are you due payment for the PR? 50%? I see ✔️ but not a reviewer's checklist with tests

  6. situchan commented on Oct 14, 2026

    @situchan
    Contributor

    Test was done. Examples: #102321 (review), #102321 (review).
    I didn't intentionally post checklist because it's duplicated with @truph01's.
    I reviewed from #102321 (comment)

  7. truph01 commented on Oct 14, 2026

    @truph01
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template. Needed for all bugs AND new features

    Regression Test Proposal

    Precondition:

    Test:

    1. Enable the Insights beta, then open a bar chart (e.g. Home → Spend over time → Top categories) and confirm it renders with category labels.
    2. Slowly narrow the window: confirm labels rotate as space shrinks and the chart flips to horizontal bars (categories on the left) once labels no longer fit, then widen it back and confirm it returns to vertical bars.
    3. In horizontal mode with many categories, confirm every category label is visible (none skipped) and the chart grows taller / scrolls to fit them.

    Do we agree 👍 or 👎

  8. truph01 commented on Oct 14, 2026

    @truph01
    Contributor

    @mallenexpensify This is part of project #317. As we can see, a few completed issues were paid at the old rate of $250.

  9. mallenexpensify commented on Oct 14, 2026

    @mallenexpensify
    Contributor

    @truph01 @situchan paid, summary updated above. Thx.

  10. garrettmknight commented on Oct 19, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

  11. laurenreidexpensify commented on Nov 18, 2026

    @laurenreidexpensify
    Contributor

    Approved @situchan $250 New Expensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions