Skip to content

[Due for payment 2026-10-13] [$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses #103169

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: v9.5.3-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/57602041/test-cases/41237790
Email or phone of affected tester (no customers): applausetester+vp4@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: iPhone 13/ iOS 26.2.1
App Component: Money Requests

Action Performed:

  1. Go to https://staging.new.expensify.com/ on the Safari browser
  2. Log in with the valid account
  3. Tap on the 'Inbox' tab
  4. Tap on the '+' button> 'Create expense'
  5. Tap on the 'Manual' tab on the 'Create expense' page
  6. Select another user
  7. Enter any value into the 'Amount' field, then tap on the 'Create expense' button
  8. After the preview of the expense is created, observe the 'View' button on it
  9. On the post view, tap on the '+' button next to the compose message field
  10. Tap on the 'Create expense' and perform the create and submit expense flow to the same user
  11. Observe the View button in the merged preview of the two expenses.

Expected Result:

After step 8, the 'View' button still displays fully and clearly.

Actual Result:

After step 8, the user observes that the “View” button is partially cut off at the bottom. The issue is not reproducible on Android.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7278599_1791276539437.IMG_1505.mp4
Image

View all open jobs on GitHub

Applause Internal Information
Exported by: Rizky Gunawan
Bug ID: 7278599

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @parasharrajat

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 6, 2026
  2. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Oct 6, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on Oct 6, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Investigation

    ⚠️ Low-to-medium confidence. The likely cause is in this staging release, but the issue says it also reproduces in production, which the code does not support.

    Likely cause: Split report preview action buttons evenly (Expensify/App#102349), merged 2026-10-05 and included in 9.5.3-0. It adds style={styles.flex1} to the "View" button in ReportPreviewActionButton.tsx:27. On iOS Safari, flex: 1 (0% basis) inside a column container with no fixed height can collapse the wrapper. The 40px button then spills below the card, which matches the screenshot.

    Recommended next step:

    1. Ask QA to re-check production (9.5.2-4) on iOS mWeb Safari.
    2. If production is fine, revert Expensify/App#102349. It is a one-line change plus a test. A roll-forward fix is to drop flex1 from the View button when it is the only button, or use flexGrow: 1 without the 0% basis.
    3. If production does reproduce it, the bug is older and cosmetic (the button still works). Demote it from deploy blocker and fix it normally.
    Investigation details
    • I compared production (9.5.2-4) with staging (9.5.3-0-staging) across the report preview folder, src/components/Button, src/components/Pressable, src/styles, and src/pages/inbox/report. The only change affecting the View button layout is the flex1 line from Expensify/App#102349 (commit 4f5c3299c38).
    • Button passes style to the outer pressable wrapper (Button.tsx:150-155). The inner pressable keeps minHeight: 40.
    • When only "View" shows, the button sits in a wrapper that also has flex1 (ReportPreviewActionButton.tsx:62). On narrow layouts that wrapper is inside a flexColumnReverse container with only minHeight: 28 (MoneyRequestReportPreviewBody.tsx:83, :144). Safari can resolve that to near-zero height. Chrome and Android use the content height, which fits "not reproducible on Android".
    • I ruled out Standardize Expense Report and Expense header with predictable button placement and carousel counter. Its preview changes only affect carousel navigation, not layout.
    • Not verified: I could not test on iOS Safari. I also have not explained why it shows only after the second expense.

    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.


    view run

  6. parasharrajat commented on Oct 6, 2026

    @parasharrajat
    Member

    @MelvinBot Create the fix PR for this bug and assign me for review.

  7. MelvinBot commented on Oct 6, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: Fix report preview View button cut off on iOS Safari
    Please mark it as "Ready for review" when it is ready for review.

    parasharrajat, I assigned you and requested your review.

    Fix: The View button now uses flex: 1 only when it shares the row with a primary action. A lone View button goes back to the production layout, which is the case in this issue. The even split from Split report preview action buttons evenly still works.

    Checks: Typecheck, lint, and the React Compiler check passed. The report preview Jest suites passed (117 tests), including a new test for the lone View button. I couldn't test on iOS Safari, so please confirm it there before you mark the PR ready.


    view run

  8. changed the title [-]mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/-] [+][$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/+] on Oct 6, 2026
  9. melvin-bot commented on Oct 6, 2026

    @melvin-bot
  10. parasharrajat commented on Oct 6, 2026

    @parasharrajat
    Member

    @yuwenmemon Pr is ready #103206

  11. m-natarajan commented on Oct 6, 2026

    @m-natarajan

    Not repro in iPhone13/iOS26.6.2, v9.5.3-4

    ScreenRecording_10-06-2026.16-01-08_1.MP4
  12. puneetlath commented on Oct 6, 2026

    @puneetlath
    Contributor

    Great!

  13. added and removed
    ReviewingHas a PR in review
    on Oct 6, 2026
  14. changed the title [-][$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/-] [+][Due for payment 2026-10-13] [$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/+] on Oct 6, 2026
  15. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    @parasharrajat

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-13. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  16. voxturrlabs commented on Oct 7, 2026

    @voxturrlabs

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On iOS mWeb Safari, the "View" button on the report preview is cut off at the bottom after a second expense is added to the report.

    What is the root cause of that problem?

    On narrow layouts, the preview body puts the action buttons in a flexColumnReverse container that only has a 28px minimum height (MoneyRequestReportPreviewBody.tsx#L83, #L144).

    Inside that column, the button wrapper uses styles.flex1 (ReportPreviewActionButton.tsx#L63). The View button inside it also uses flex1. On web, flex: 1 means flex-basis: 0, so in a column both elements start at zero height and only grow into spare space. The column has no fixed height, so Safari leaves them almost 0px tall. The 40px button then spills out of its box and gets clipped. Chrome and Android size these from their content, which is why it only happens on Safari.

    flex1 was only meant to split the row's width evenly between the primary action and View. Because it's also applied along the column (height), it causes this collapse.

    What changes do you think we should make in order to solve the problem?

    Keep flex: 1 working only along the row, where it splits width:

    1. On the outer action wrapper (both the View-only and the primary + View versions), replace flex1 with flexGrow1. The wrapper can still fill the space, but its height comes from its content instead of starting at 0.
    2. Give the View-only wrapper flexRow, like the two-button wrapper. The button's flex1 then applies to width, not height, so the View button can keep flex1 in every case and the layout stays the same for both versions.
    3. Add a test that renders the preview with a View-only action and with a primary + View action in the narrow layout. The test should check that the wrapper uses flexGrow instead of flex: 1 and that the View-only wrapper is a row.

    This fixes the cause for every action combination on narrow layouts, not only the lone View button, and it keeps the even split from the wide layout.

    What alternative solutions did you explore? (Optional)

    Removing flex1 from the View button only when it's shown alone. That fixes this case, but it leaves the wrapper's flex: 1 in the column. That same collapse can come back whenever another child in that column gets flex: 1.

    Contributor details
    Expensify account email: systemadmin@voxturrlabs.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~010efadac9ff3c3d2a/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions