You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-13] [$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses #103169
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
⚠️Low-to-medium confidence. The likely cause is in this staging release, but the issue says it also reproduces in production, which the code does not support.
Likely cause:Split report preview action buttons evenly (Expensify/App#102349), merged 2026-10-05 and included in 9.5.3-0. It adds style={styles.flex1} to the "View" button in ReportPreviewActionButton.tsx:27. On iOS Safari, flex: 1 (0% basis) inside a column container with no fixed height can collapse the wrapper. The 40px button then spills below the card, which matches the screenshot.
Recommended next step:
Ask QA to re-check production (9.5.2-4) on iOS mWeb Safari.
If production is fine, revert Expensify/App#102349. It is a one-line change plus a test. A roll-forward fix is to drop flex1 from the View button when it is the only button, or use flexGrow: 1 without the 0% basis.
If production does reproduce it, the bug is older and cosmetic (the button still works). Demote it from deploy blocker and fix it normally.
Investigation details
I compared production (9.5.2-4) with staging (9.5.3-0-staging) across the report preview folder, src/components/Button, src/components/Pressable, src/styles, and src/pages/inbox/report. The only change affecting the View button layout is the flex1 line from Expensify/App#102349 (commit 4f5c3299c38).
Button passes style to the outer pressable wrapper (Button.tsx:150-155). The inner pressable keeps minHeight: 40.
When only "View" shows, the button sits in a wrapper that also has flex1 (ReportPreviewActionButton.tsx:62). On narrow layouts that wrapper is inside a flexColumnReverse container with only minHeight: 28 (MoneyRequestReportPreviewBody.tsx:83, :144). Safari can resolve that to near-zero height. Chrome and Android use the content height, which fits "not reproducible on Android".
parasharrajat, I assigned you and requested your review.
Fix: The View button now uses flex: 1 only when it shares the row with a primary action. A lone View button goes back to the production layout, which is the case in this issue. The even split from Split report preview action buttons evenly still works.
Checks: Typecheck, lint, and the React Compiler check passed. The report preview Jest suites passed (117 tests), including a new test for the lone View button. I couldn't test on iOS Safari, so please confirm it there before you mark the PR ready.
changed the title [-]mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/-][+][$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/+]on Oct 6, 2026
changed the title [-][$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/-][+][Due for payment 2026-10-13] [$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/+]on Oct 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-13. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Please re-state the problem that we are trying to solve in this issue.
On iOS mWeb Safari, the "View" button on the report preview is cut off at the bottom after a second expense is added to the report.
What is the root cause of that problem?
On narrow layouts, the preview body puts the action buttons in a flexColumnReverse container that only has a 28px minimum height (MoneyRequestReportPreviewBody.tsx#L83, #L144).
Inside that column, the button wrapper uses styles.flex1 (ReportPreviewActionButton.tsx#L63). The View button inside it also uses flex1. On web, flex: 1 means flex-basis: 0, so in a column both elements start at zero height and only grow into spare space. The column has no fixed height, so Safari leaves them almost 0px tall. The 40px button then spills out of its box and gets clipped. Chrome and Android size these from their content, which is why it only happens on Safari.
flex1 was only meant to split the row's width evenly between the primary action and View. Because it's also applied along the column (height), it causes this collapse.
What changes do you think we should make in order to solve the problem?
Keep flex: 1 working only along the row, where it splits width:
On the outer action wrapper (both the View-only and the primary + View versions), replace flex1 with flexGrow1. The wrapper can still fill the space, but its height comes from its content instead of starting at 0.
Give the View-only wrapper flexRow, like the two-button wrapper. The button's flex1 then applies to width, not height, so the View button can keep flex1 in every case and the layout stays the same for both versions.
Add a test that renders the preview with a View-only action and with a primary + View action in the narrow layout. The test should check that the wrapper uses flexGrow instead of flex: 1 and that the View-only wrapper is a row.
This fixes the cause for every action combination on narrow layouts, not only the lone View button, and it keeps the even split from the wide layout.
What alternative solutions did you explore? (Optional)
Removing flex1 from the View button only when it's shown alone. That fixes this case, but it leaves the wrapper's flex: 1 in the column. That same collapse can come back whenever another child in that column gets flex: 1.
Activity
applause-bot commentedon Oct 6, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/73f5a8a49a54dfc39e2f6dbda93a102f1881c981366fdeb168bbc82cc74e8382
https://platform.applause.com/services/links/v1/external/8c97a41d7cd954750d98b6d7ccb7bec0e6d8e7b4aa5fe533b89570acb1f345f7
melvin-bot commentedon Oct 6, 2026
Triggered auto assignment to @yuwenmemon (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 6, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 6, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 6, 2026
Deploy Blocker Investigation
Likely cause: Split report preview action buttons evenly (
Expensify/App#102349), merged 2026-10-05 and included in 9.5.3-0. It addsstyle={styles.flex1}to the "View" button in ReportPreviewActionButton.tsx:27. On iOS Safari,flex: 1(0% basis) inside a column container with no fixed height can collapse the wrapper. The 40px button then spills below the card, which matches the screenshot.Recommended next step:
Expensify/App#102349. It is a one-line change plus a test. A roll-forward fix is to dropflex1from the View button when it is the only button, or useflexGrow: 1without the 0% basis.Investigation details
9.5.2-4) with staging (9.5.3-0-staging) across the report preview folder,src/components/Button,src/components/Pressable,src/styles, andsrc/pages/inbox/report. The only change affecting the View button layout is theflex1line fromExpensify/App#102349(commit4f5c3299c38).Buttonpassesstyleto the outer pressable wrapper (Button.tsx:150-155). The inner pressable keepsminHeight: 40.flex1(ReportPreviewActionButton.tsx:62). On narrow layouts that wrapper is inside aflexColumnReversecontainer with onlyminHeight: 28(MoneyRequestReportPreviewBody.tsx:83, :144). Safari can resolve that to near-zero height. Chrome and Android use the content height, which fits "not reproducible on Android".Next Steps: Reply with
@MelvinBot <your feedback>to refine this analysis.view run
parasharrajat commentedon Oct 6, 2026
@MelvinBot Create the fix PR for this bug and assign me for review.
MelvinBot commentedon Oct 6, 2026
🤖 Draft PR created: Fix report preview View button cut off on iOS Safari
Please mark it as "Ready for review" when it is ready for review.
parasharrajat, I assigned you and requested your review.Fix: The View button now uses
flex: 1only when it shares the row with a primary action. A lone View button goes back to the production layout, which is the case in this issue. The even split from Split report preview action buttons evenly still works.Checks: Typecheck, lint, and the React Compiler check passed. The report preview Jest suites passed (117 tests), including a new test for the lone View button. I couldn't test on iOS Safari, so please confirm it there before you mark the PR ready.
view run
[-]mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/-][+][$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/+]melvin-bot commentedon Oct 6, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022107489814762848601
parasharrajat commentedon Oct 6, 2026
@yuwenmemon Pr is ready #103206
m-natarajan commentedon Oct 6, 2026
Not repro in iPhone13/iOS26.6.2, v9.5.3-4
ScreenRecording_10-06-2026.16-01-08_1.MP4
puneetlath commentedon Oct 6, 2026
Great!
[-][$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/-][+][Due for payment 2026-10-13] [$175] mWeb Safari- Submit expense - The “View” button is truncated when create two expenses[/+]melvin-bot commentedon Oct 6, 2026
@parasharrajat
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-13. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
voxturrlabs commentedon Oct 7, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On iOS mWeb Safari, the "View" button on the report preview is cut off at the bottom after a second expense is added to the report.
What is the root cause of that problem?
On narrow layouts, the preview body puts the action buttons in a flexColumnReverse container that only has a 28px minimum height (MoneyRequestReportPreviewBody.tsx#L83, #L144).
Inside that column, the button wrapper uses styles.flex1 (ReportPreviewActionButton.tsx#L63). The View button inside it also uses flex1. On web, flex: 1 means flex-basis: 0, so in a column both elements start at zero height and only grow into spare space. The column has no fixed height, so Safari leaves them almost 0px tall. The 40px button then spills out of its box and gets clipped. Chrome and Android size these from their content, which is why it only happens on Safari.
flex1 was only meant to split the row's width evenly between the primary action and View. Because it's also applied along the column (height), it causes this collapse.
What changes do you think we should make in order to solve the problem?
Keep flex: 1 working only along the row, where it splits width:
This fixes the cause for every action combination on narrow layouts, not only the lone View button, and it keeps the even split from the wide layout.
What alternative solutions did you explore? (Optional)
Removing flex1 from the View button only when it's shown alone. That fixes this case, but it leaves the wrapper's flex: 1 in the column. That same collapse can come back whenever another child in that column gets flex: 1.
Contributor details
Expensify account email: systemadmin@voxturrlabs.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010efadac9ff3c3d2a/