Skip to content

[Due for payment 2026-10-27] Spend - Expenses arrows still shown on the thread page started from a paid message #103224

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.3-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/57605193/test-cases/41237115
Email or phone of affected tester (no customers): gatantm+6106@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: MacOS Safari
App Component: Chat Report View

Action Performed:

  1. Launch new Expensify and login with an account with a couple of expenses
  2. Go to a chat with an other user
  3. Click on Create > Pay "user" add an amount and confirm
  4. Go to the Spend > Expenses page and open the paid expense
  5. Hover over the "marked as paid" message and click to start a thread (you can start the thread or not)

Expected Result:

There are no move around the expenses arrows as we are not on the expense anymore

Actual Result:

The expense arrows still appear and user can move around the expenses shown on Spend although we are on a new thread and not the main expense

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7279105_1791307553657.Recording__1915.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7279105

Issue OwnerCurrent Issue Owner: @thelullabyy

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 6, 2026
  2. applause-bot commented on Oct 6, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/f7580f3d06566eb634ed985e2b510623e35188d5525b75ad13ff3fab95f97763

  3. github-actions commented on Oct 6, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Oct 6, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. MelvinBot commented on Oct 6, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Investigation

    Causing PR: Standardize Expense Report and Expense header with predictable button placement and carousel counter by thelullabyy. It was merged 2026-10-05 and is part of Deploy Checklist: New Expensify 2026-10-05.

    Confidence: High for the PR, because it is the only PR in this release that changes the prev/next carousel. It is also the first change to fill the carousel from Spend > Expenses, which explains why prod is unaffected. Medium-high for the exact mechanism, which comes from reading the code and was not reproduced.

    Recommended resolution: Fix forward. In MoneyRequestHeader, hide the carousel when the thread's parent is a one-expense report:

    shouldDisplayTransactionNavigation = !!(reportID && isReportInRHP) && !isOneTransactionReport(parentReport)

    This matches the PR's own rule that a one-expense report is the expense view. A revert of this 53-file feature also fixes the issue, if the team reverts it for the other open blockers it caused.

    Investigation details
    1. "Pay user" creates an IOU PAY action with IOUDetails. That action is the parent of the paid expense's thread (SendMoney.ts#L149-L161).
    2. Opening the expense from Spend fills the carousel with every Spend expense, then opens the report with anchorTransactionID (Search/index.tsx#L814-L820, #L629-L641). The PR added both.
    3. "Reply in thread" opens a new search report screen in the RHP with no anchor (Report/index.ts#L2873-L2879). That screen is in CAROUSEL_PRESERVING_SCREENS, so the Spend list stays loaded (MoneyRequestReportTransactionsNavigation.tsx#L38-L43).
    4. A thread whose parent is a PAY action with IOUDetails counts as a transaction thread, so it gets the expense header (ReportActionsUtils.ts#L806-L816, ReportHeader.tsx#L75-L86).
    5. MoneyRequestHeader shows the carousel on every search report screen in the RHP. It doesn't check how the screen was reached (MoneyRequestHeader.tsx#L101-L108). The paid expense is in the Spend list, so the arrows render and page other expenses into the thread screen (MoneyRequestReportTransactionsNavigation.tsx#L435-L453).

    The carousel itself skips the transaction thread of a one-expense report (MoneyRequestReportTransactionsNavigation.tsx#L271-L276), but the header doesn't apply the same rule.

    Alternative fix: show the carousel only when anchorTransactionID is in the route. This is riskier, because createAndOpenSearchTransactionThread opens threads without an anchor (SearchUIUtils.ts#L2539).

    Related: another regression from the same PR was fixed forward in [cp staging] Spend - App crashes after returning to expense RHP from expense report.

    Test plan (web): follow the issue steps and confirm the thread shows no counter or arrows. Then confirm arrows still work for a one-expense report and for an expense in a multi-expense report opened from Spend.


    Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.


    view run

  7. JS00001 commented on Oct 6, 2026

    @JS00001
    Contributor

    Being able to navigate in a thread is not a big deal, lets demote this & add to the follow up list

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 6, 2026
  9. added
    ReviewingHas a PR in review
    and removed on Oct 8, 2026
  10. changed the title [-]Spend - Expenses arrows still shown on the thread page started from a paid message[/-] [+][Due for payment 2026-10-27] Spend - Expenses arrows still shown on the thread page started from a paid message[/+] on Oct 20, 2026
  11. melvin-bot commented on Oct 20, 2026

    @melvin-bot

    @thelullabyy

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.14-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-27. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions