Skip to content

Distance - Reuse route option is not shown when splitting distance #103268

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.4-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102258
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open 1:1 DM with any user.
  3. Create a split distance expense.
  4. Click + > Split distance > Map.

Expected Result:

Reuse route option will be shown when splitting distance.

Actual Result:

Reuse route option is not shown when splitting distance.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7279447_1791326132077.9.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Vincenzo Godoy
Bug ID: 7279447

Activity

  1. applause-bot commented on Oct 7, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/0287af483807d3a35dbb72ae135672915dea0600b8be908b0a88a625c269f650

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 7, 2026
  3. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #102258

  4. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    @Gonals @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #102258

  5. github-actions commented on Oct 7, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    @ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #102258

  7. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Oct 7, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Verdict: I don't think this is a regression, so it probably shouldn't block the deploy. Add Reuse route to the distance creation flow added "Reuse route" only to the Track distance / Create expense Map screen. Split distance uses a different screen that the PR never wired up, so the button can't appear there. Production has no "Reuse route" anywhere, so split distance behaves the same as it does in production.

    Recommendation: Demote it, and don't revert. A revert would remove a working feature from Track distance to fix a flow it never targeted. If product wants split support, track it as a follow-up. Gonals / ShridharGoel, could you confirm split was out of scope?

    Investigation details

    All links use App commit fbbc96e4, which already includes the PR (merged as 8b3fdd9a).

    1. The button needs a handler and at least one saved route. See DistanceRequestFooter.tsx:110:
      const shouldShowReuseRoute = !!navigateToReuseRoutePage && !!reusableDistanceRoutes?.length;
    2. Only IOURequestStepDistanceMap passes the handler. It loads saved routes at L194-L204 and passes the handler at L387. Only Track distance / Create expense > Distance renders this screen.
    3. Split distance renders DynamicIOURequestStepDistance instead. Both entry points lead there: the chat "+" menu (AttachmentPickerWithMenuItems.tsx:240) and the quick action (QuickActionNavigation.ts:56-60). Both open the start page, which renders this screen at IOURequestStartPage.tsx:328-339.
    4. That screen never passes the handler and never loads saved routes. See DynamicIOURequestStepDistance.tsx:860-875 and L941-L956. The PR changed only one unrelated line in this file.
    5. The PR's description and test steps cover only the Track distance Map tab. Nobody discussed split in the PR's comments or reviews.

    If product wants split support now, the change in DynamicIOURequestStepDistance is small, for the create case only:

    • Load saved routes on mount, like IOURequestStepDistanceMap does.
    • Pass a handler that opens the reuse-route page with iouType=split. IOURequestStepReuseRoute already has some split handling (L99), but nothing has tested it.
    • QA the split confirmation after picking a route (participants and amounts).
    • Confirm the server returns split distance expenses as reusable routes. I couldn't verify this. If it doesn't, the button stays hidden even after the screen is wired.

    Next Steps: If you agree split was out of scope, remove DeployBlockerCash and close or demote this issue. Reply with @MelvinBot <your feedback> to refine this analysis.


    view run

  9. JmillsExpensify commented on Oct 7, 2026

    @JmillsExpensify
    Contributor

    P2P flow. Not a priority.

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 7, 2026
  11. ShridharGoel commented on Oct 9, 2026

    @ShridharGoel
    Contributor

    @JmillsExpensify So do we need to support this or should we close this?

  12. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    @Pujan92, @Gonals, @ShridharGoel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. Gonals commented on Oct 15, 2026

    @Gonals
    Contributor

    I think we can close for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions