You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Distance - Reuse route option is not shown when splitting distance #103268
Version Number: 9.5.4-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102258 Email or phone of affected tester (no customers):jsoidjndoiniodnsjojd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Open 1:1 DM with any user.
Create a split distance expense.
Click + > Split distance > Map.
Expected Result:
Reuse route option will be shown when splitting distance.
Actual Result:
Reuse route option is not shown when splitting distance.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Verdict: I don't think this is a regression, so it probably shouldn't block the deploy. Add Reuse route to the distance creation flow added "Reuse route" only to the Track distance / Create expense Map screen. Split distance uses a different screen that the PR never wired up, so the button can't appear there. Production has no "Reuse route" anywhere, so split distance behaves the same as it does in production.
Recommendation: Demote it, and don't revert. A revert would remove a working feature from Track distance to fix a flow it never targeted. If product wants split support, track it as a follow-up. Gonals / ShridharGoel, could you confirm split was out of scope?
Investigation details
All links use App commit fbbc96e4, which already includes the PR (merged as 8b3fdd9a).
The button needs a handler and at least one saved route. See DistanceRequestFooter.tsx:110: const shouldShowReuseRoute = !!navigateToReuseRoutePage && !!reusableDistanceRoutes?.length;
Only IOURequestStepDistanceMap passes the handler. It loads saved routes at L194-L204 and passes the handler at L387. Only Track distance / Create expense > Distance renders this screen.
The PR's description and test steps cover only the Track distance Map tab. Nobody discussed split in the PR's comments or reviews.
If product wants split support now, the change in DynamicIOURequestStepDistance is small, for the create case only:
Load saved routes on mount, like IOURequestStepDistanceMap does.
Pass a handler that opens the reuse-route page with iouType=split. IOURequestStepReuseRoute already has some split handling (L99), but nothing has tested it.
QA the split confirmation after picking a route (participants and amounts).
Confirm the server returns split distance expenses as reusable routes. I couldn't verify this. If it doesn't, the button stays hidden even after the screen is wired.
Next Steps: If you agree split was out of scope, remove DeployBlockerCash and close or demote this issue. Reply with @MelvinBot <your feedback> to refine this analysis.
Activity
applause-bot commentedon Oct 7, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/0287af483807d3a35dbb72ae135672915dea0600b8be908b0a88a625c269f650
melvin-bot commentedon Oct 7, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #102258
melvin-bot commentedon Oct 7, 2026
@Gonals @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #102258
github-actions commentedon Oct 7, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 7, 2026
@ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #102258
melvin-bot commentedon Oct 7, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 7, 2026
Deploy Blocker Analysis
Verdict: I don't think this is a regression, so it probably shouldn't block the deploy. Add Reuse route to the distance creation flow added "Reuse route" only to the Track distance / Create expense Map screen. Split distance uses a different screen that the PR never wired up, so the button can't appear there. Production has no "Reuse route" anywhere, so split distance behaves the same as it does in production.
Recommendation: Demote it, and don't revert. A revert would remove a working feature from Track distance to fix a flow it never targeted. If product wants split support, track it as a follow-up.
Gonals/ShridharGoel, could you confirm split was out of scope?Investigation details
All links use App commit
fbbc96e4, which already includes the PR (merged as8b3fdd9a).const shouldShowReuseRoute = !!navigateToReuseRoutePage && !!reusableDistanceRoutes?.length;IOURequestStepDistanceMappasses the handler. It loads saved routes at L194-L204 and passes the handler at L387. Only Track distance / Create expense > Distance renders this screen.DynamicIOURequestStepDistanceinstead. Both entry points lead there: the chat "+" menu (AttachmentPickerWithMenuItems.tsx:240) and the quick action (QuickActionNavigation.ts:56-60). Both open the start page, which renders this screen at IOURequestStartPage.tsx:328-339.If product wants split support now, the change in
DynamicIOURequestStepDistanceis small, for the create case only:IOURequestStepDistanceMapdoes.iouType=split.IOURequestStepReuseRoutealready has some split handling (L99), but nothing has tested it.Next Steps: If you agree split was out of scope, remove
DeployBlockerCashand close or demote this issue. Reply with@MelvinBot <your feedback>to refine this analysis.view run
JmillsExpensify commentedon Oct 7, 2026
P2P flow. Not a priority.
ShridharGoel commentedon Oct 9, 2026
@JmillsExpensify So do we need to support this or should we close this?
melvin-bot commentedon Oct 13, 2026
@Pujan92, @Gonals, @ShridharGoel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Gonals commentedon Oct 15, 2026
I think we can close for now