You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Distance - Sender's distance route appears in route list for receiver #103278
Version Number: 9.5.4-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102258 Email or phone of affected tester (no customers):jsoidjndoiniodnsjojd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
User A has submitted a map distance expense to User B.
Perform the steps below as User B:
Go to staging.new.expensify.com
Open the IOU report from User A.
Click + > Track distance > Map.
→ Reuse route option is not shown (indicating User A's distance route does not affect User B).
Submit a distance expense to User A.
Click + > Track distance > Map.
Click Reuse route.
→ User A's route appears in the list.
Expected Result:
Sender's distance route will not appear in route list for receiver.
Actual Result:
Sender's distance route appears in route list for receiver.
On the other hand, receiver's route does not appear for sender in route list.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause: The App shows whatever list of routes the OpenReuseRoutePage API command returns, without filtering it. This appears to be a backend/internal issue: the API returns map distance expenses that the current user didn't create. A separate internal investigation is needed.
Recommended resolution:
Fix forward on the backend: return only map distance expenses that the current user created. No App change is needed after that.
Data: Only the API response writes reusableDistanceRoutes, with no optimistic writes. The key is cleared on sign-out, so stale data from another account is ruled out.
Why the button is hidden at first:DistanceRequestFooter.tsx:110 shows Reuse route only when the list isn't empty. Before User B creates a map expense, the API returns an empty list. After User B creates one, the API returns a list that also includes User A's route. Both symptoms come from how the backend selects routes, including User A not seeing User B's route.
Optional App hardening: add an owner accountID to the API response and to ReusableDistanceRoute, then filter on it in IOURequestStepReuseRoute.tsx and DistanceRequestFooter.tsx.
Severity: User B can already see User A's expense in the shared report, so this isn't a privacy leak. It's a UX bug in a new feature, which supports fixing forward.
Not verified: I didn't reproduce this in the app or check production logs.
Next Steps:ShridharGoel, Gonals, Pujan92: please coordinate the backend fix internally, or revert #102258 if it can't land in time. Reply with @MelvinBot <your feedback> to refine this analysis.
Activity
applause-bot commentedon Oct 7, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/76b3838abedddd482fd48b79242a8872364097709d33950537b281fceab57e4b
melvin-bot commentedon Oct 7, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #102258
melvin-bot commentedon Oct 7, 2026
@Gonals @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #102258
melvin-bot commentedon Oct 7, 2026
@ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #102258
melvin-bot commentedon Oct 7, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 7, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 7, 2026
Deploy Blocker Analysis
Causing PR: [Payment due @Pujan92] Add Reuse route to the distance creation flow (
Expensify/App#102258). It adds the whole Reuse route feature, and no other PR on staging touches these files. I'm highly confident it caused this blocker.Root cause: The App shows whatever list of routes the
OpenReuseRoutePageAPI command returns, without filtering it. This appears to be a backend/internal issue: the API returns map distance expenses that the current user didn't create. A separate internal investigation is needed.Recommended resolution:
Investigation details
All links point to App commit
55d597ef3ddcd3b79e88aa8c9dd5e732b0953e52.fetchReusableDistanceRoutes()when the Map tab opens.OPEN_REUSE_ROUTE_PAGEwithnullparameters (types.ts:1760). The backend alone decides which routes count as the user's.reusableDistanceRoutes, with no optimistic writes. The key is cleared on sign-out, so stale data from another account is ruled out.Why the button is hidden at first: DistanceRequestFooter.tsx:110 shows Reuse route only when the list isn't empty. Before User B creates a map expense, the API returns an empty list. After User B creates one, the API returns a list that also includes User A's route. Both symptoms come from how the backend selects routes, including User A not seeing User B's route.
Optional App hardening: add an owner
accountIDto the API response and toReusableDistanceRoute, then filter on it inIOURequestStepReuseRoute.tsxandDistanceRequestFooter.tsx.Severity: User B can already see User A's expense in the shared report, so this isn't a privacy leak. It's a UX bug in a new feature, which supports fixing forward.
Not verified: I didn't reproduce this in the app or check production logs.
Next Steps:
ShridharGoel,Gonals,Pujan92: please coordinate the backend fix internally, or revert #102258 if it can't land in time. Reply with@MelvinBot <your feedback>to refine this analysis.JmillsExpensify commentedon Oct 7, 2026
Worth fixing
Gonals commentedon Oct 7, 2026
Merged in Auth. Removing blocker, as the fix is backend and I don't think we need to block App deploy on it
JmillsExpensify commentedon Oct 7, 2026
Good with that
kavimuru commentedon Oct 13, 2026
@ShridharGoel bug is not reproducible
bandicam.2026-10-10.21-59-00-972.mp4