Skip to content

Distance - Sender's distance route appears in route list for receiver #103278

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.4-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102258
Email or phone of affected tester (no customers): jsoidjndoiniodnsjojd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • User A has submitted a map distance expense to User B.
  • Perform the steps below as User B:
  1. Go to staging.new.expensify.com
  2. Open the IOU report from User A.
  3. Click + > Track distance > Map.
    → Reuse route option is not shown (indicating User A's distance route does not affect User B).
  4. Submit a distance expense to User A.
  5. Click + > Track distance > Map.
  6. Click Reuse route.
    → User A's route appears in the list.

Expected Result:

Sender's distance route will not appear in route list for receiver.

Actual Result:

Sender's distance route appears in route list for receiver.
On the other hand, receiver's route does not appear for sender in route list.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7279505_1791330494488.15.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7279505

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 7, 2026
  2. applause-bot commented on Oct 7, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/76b3838abedddd482fd48b79242a8872364097709d33950537b281fceab57e4b

  3. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #102258

  4. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    @Gonals @Pujan92 you have been assigned to this deploy blocker because you reviewed the offending PR: #102258

  5. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    @ShridharGoel you have been assigned to this deploy blocker because you authored the offending PR: #102258

  6. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Oct 7, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Oct 7, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: [Payment due @Pujan92] Add Reuse route to the distance creation flow (Expensify/App#102258). It adds the whole Reuse route feature, and no other PR on staging touches these files. I'm highly confident it caused this blocker.

    Root cause: The App shows whatever list of routes the OpenReuseRoutePage API command returns, without filtering it. This appears to be a backend/internal issue: the API returns map distance expenses that the current user didn't create. A separate internal investigation is needed.

    Recommended resolution:

    1. Fix forward on the backend: return only map distance expenses that the current user created. No App change is needed after that.
    2. If the backend fix can't land before this deploy, revert [Payment due @Pujan92] Add Reuse route to the distance creation flow #102258. The revert is self-contained, but it also removes the web map-size crash fix that this PR included.
    Investigation details

    All links point to App commit 55d597ef3ddcd3b79e88aa8c9dd5e732b0953e52.

    Why the button is hidden at first: DistanceRequestFooter.tsx:110 shows Reuse route only when the list isn't empty. Before User B creates a map expense, the API returns an empty list. After User B creates one, the API returns a list that also includes User A's route. Both symptoms come from how the backend selects routes, including User A not seeing User B's route.

    Optional App hardening: add an owner accountID to the API response and to ReusableDistanceRoute, then filter on it in IOURequestStepReuseRoute.tsx and DistanceRequestFooter.tsx.

    Severity: User B can already see User A's expense in the shared report, so this isn't a privacy leak. It's a UX bug in a new feature, which supports fixing forward.

    Not verified: I didn't reproduce this in the app or check production logs.


    Next Steps: ShridharGoel, Gonals, Pujan92: please coordinate the backend fix internally, or revert #102258 if it can't land in time. Reply with @MelvinBot <your feedback> to refine this analysis.

  9. JmillsExpensify commented on Oct 7, 2026

    @JmillsExpensify
    Contributor

    Worth fixing

  10. added
    ReviewingHas a PR in review
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 7, 2026
  11. Gonals commented on Oct 7, 2026

    @Gonals
    Contributor

    Merged in Auth. Removing blocker, as the fix is backend and I don't think we need to block App deploy on it

  12. JmillsExpensify commented on Oct 7, 2026

    @JmillsExpensify
    Contributor

    Good with that

  13. kavimuru commented on Oct 13, 2026

    @kavimuru

    @ShridharGoel bug is not reproducible

    bandicam.2026-10-10.21-59-00-972.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions