You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bulk pay: show a modal explaining why non-reimbursable reports got excluded from bank payment #103871
The minimal fix shipped in PR #102347 hides the bank-pay option for the WHOLE selection whenever one of the selected reports is entirely non-reimbursable (whether its total is $0 or not). This stops the original bug (bank option wrongly showing for a $0 report), but it over-corrects: a genuinely payable report loses its bank-pay option too just because it’s selected alongside a non-payable one, with no explanation shown to the user
Solution
Bring the bank-pay option back for mixed selections. When the user picks “Pay with [bank account]” on a selection that includes non-reimbursable-only reports alongside payable ones, show a confirmation modal first: list which reports are excluded and why, then let the user proceed paying the eligible reports via bank while leaving the excluded ones for manual mark-as-paid.
Suggested copy:
**Pay with x1234**
These reports weren’t paid with the bank account because all expenses on them are non-reimbursable. You can manually mark them as paid if preferred.
• report name
• report name
[Got it]
Or this issue is specifically for the mixed selections with both reimbursable and non-reimbursable reports?
Yep, the intention of this modal proposed was for the mixed report selection case. So it's made clear to them which reports were not paid with the bank account after taking the action.
Pay with x1234
These reports weren’t paid with the bank account because all expenses on them are non-reimbursable. You can manually mark them as paid if preferred.
• report name
• report name
[Got it]
I could see an argument that we should show the bank account as an option on "only non-reimbursable" reports selected, but trying to use it would throw a different message in the modal.
Pay with x1234
All expenses on the reports selected are non-reimbursable. You can manually mark these reports as paid if preferred.
Frontend (me), I'd split into separate PRs so each can ship on its own:
Search bulk pay for loaded selections ("Select all on this page" and individual selections): show the bank option, pay what's eligible, then show your mixed or "all skipped" modal with the bulleted report names. No backend change needed.
Single report view: show the bank option for a report that's non-reimbursable or totals $0 or less, and show your single-report modal when it's picked. No backend change needed.
"Select all": once the backend part is in, show the bank option, send the new params, and in BulkActionStatusModal use bank-payment titles ("Paying reports...", "Paid X of Y reports") plus your skipped copy with the existing "View reports" button.
Thanks for catching this. You’re right, it’s a backend bug. For “Select all”, the server looks up reports with the pay todo query, and that query already drops non-reimbursable and $0 reports. So they never reach the pay job and never show up in skippedReportIDs. I’ll fix it so those reports get listed as skipped. I’ll ping you when the fix is up!
Thanks for catching this. You’re right, it’s a backend bug. For “Select all”, the server looks up reports with the pay todo query, and that query already drops non-reimbursable and $0 reports. So they never reach the pay job and never show up in skippedReportIDs. I’ll fix it so those reports get listed as skipped. I’ll ping you when the fix is up!
@mollfpr Please let me know when the backend fix is ready. Thanks!
Activity
melvin-bot commentedon Oct 13, 2026
Triggered auto assignment to @shawnborton (
Design), see these Stack Overflow questions for more details.apeyada commentedon Oct 13, 2026
It was intentional to hide bank payment option for non-reimbursable reports - #87552
Now the decision is changed?
Or this issue is specifically for the mixed selections with both reimbursable and non-reimbursable reports?
shawnborton commentedon Oct 13, 2026
Is anything needed from Design here?
trjExpensify commentedon Oct 15, 2026
I don't think so, Shawn. Pretty standard centered alert modal pattern. 👍
trjExpensify commentedon Oct 15, 2026
Yep, the intention of this modal proposed was for the mixed report selection case. So it's made clear to them which reports were not paid with the bank account after taking the action.
I could see an argument that we should show the bank account as an option on "only non-reimbursable" reports selected, but trying to use it would throw a different message in the modal.
CC: @joekaufmanexpensify what do you think?
mollfpr commentedon Oct 15, 2026
I agree with this. Showing the bank option for the "all non-reimbursable" case with its own modal message makes it clear why nothing was paid.
apeyada commentedon Oct 15, 2026
I can implement this based on latest discussion
joekaufmanexpensify commentedon Oct 16, 2026
Agreed. This feels like better UX, so the user gets feedback on why they weren't able to take the action, versus not showing it at all.
39 remaining items
melvin-bot commentedon Nov 10, 2026
@huult Whoops! This issue is 2 days overdue. Let's get this updated quick!
huult commentedon Nov 11, 2026
Same as above
trjExpensify commentedon Nov 11, 2026
Web PR went to prod yesterday. Can you continue, @huult?
huult commentedon Nov 12, 2026
@trjExpensify Yes, we can continue. The next step is for @apeyada to open the App PR, and then I’ll review it.
huult commentedon Nov 12, 2026
@apeyada When can you open the App PR?
apeyada commentedon Nov 12, 2026
PR is up. I'll mark as ready for review shortly.
apeyada commentedon Nov 12, 2026
@mollfpr
skippedReportIDsisn't coming from backend. Always empty array[].I bulk paid 53 reports (1 reimbursable, 52 non-reimbursable)
mollfpr commentedon Nov 12, 2026
Thanks for catching this. You’re right, it’s a backend bug. For “Select all”, the server looks up reports with the pay todo query, and that query already drops non-reimbursable and $0 reports. So they never reach the pay job and never show up in
skippedReportIDs. I’ll fix it so those reports get listed as skipped. I’ll ping you when the fix is up!apeyada commentedon Nov 12, 2026
I think this is expected but please confirm:Actually, this inconsistency will be fixed after #103871 (comment)
huult commentedon Nov 13, 2026
@mollfpr Please let me know when the backend fix is ready. Thanks!