Skip to content

Bulk pay: show a modal explaining why non-reimbursable reports got excluded from bank payment #103871

Open

Description

@mollfpr

Problem

The minimal fix shipped in PR #102347 hides the bank-pay option for the WHOLE selection whenever one of the selected reports is entirely non-reimbursable (whether its total is $0 or not). This stops the original bug (bank option wrongly showing for a $0 report), but it over-corrects: a genuinely payable report loses its bank-pay option too just because it’s selected alongside a non-payable one, with no explanation shown to the user

Solution

Bring the bank-pay option back for mixed selections. When the user picks “Pay with [bank account]” on a selection that includes non-reimbursable-only reports alongside payable ones, show a confirmation modal first: list which reports are excluded and why, then let the user proceed paying the eligible reports via bank while leaving the excluded ones for manual mark-as-paid.

Suggested copy:

**Pay with x1234**
These reports weren’t paid with the bank account because all expenses on them are non-reimbursable. You can manually mark them as paid if preferred.
• report name
• report name
[Got it]

Discussed here: https://expensify.slack.com/archives/C07NMDKEFMH/p1791383666369379?thread_ts=1791201941.840769&cid=C07NMDKEFMH
Originally reported by @apeyada: Expensify/App#102347 (comment)

Issue OwnerCurrent Issue Owner: @huult

Activity

  1. self-assigned this
    on Oct 13, 2026
  2. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

  3. apeyada commented on Oct 13, 2026

    @apeyada
    Contributor

    It was intentional to hide bank payment option for non-reimbursable reports - #87552
    Now the decision is changed?

    Or this issue is specifically for the mixed selections with both reimbursable and non-reimbursable reports?

  4. shawnborton commented on Oct 13, 2026

    @shawnborton
    Contributor

    Is anything needed from Design here?

  5. trjExpensify commented on Oct 15, 2026

    @trjExpensify
    Contributor

    I don't think so, Shawn. Pretty standard centered alert modal pattern. 👍

  6. trjExpensify commented on Oct 15, 2026

    @trjExpensify
    Contributor

    Or this issue is specifically for the mixed selections with both reimbursable and non-reimbursable reports?

    Yep, the intention of this modal proposed was for the mixed report selection case. So it's made clear to them which reports were not paid with the bank account after taking the action.

    Pay with x1234
    These reports weren’t paid with the bank account because all expenses on them are non-reimbursable. You can manually mark them as paid if preferred.
    • report name
    • report name
    [Got it]

    I could see an argument that we should show the bank account as an option on "only non-reimbursable" reports selected, but trying to use it would throw a different message in the modal.

    Pay with x1234
    All expenses on the reports selected are non-reimbursable. You can manually mark these reports as paid if preferred.

    [Got it]

    CC: @joekaufmanexpensify what do you think?

  7. mollfpr commented on Oct 15, 2026

    @mollfpr
    ContributorAuthor

    I agree with this. Showing the bank option for the "all non-reimbursable" case with its own modal message makes it clear why nothing was paid.

  8. apeyada commented on Oct 15, 2026

    @apeyada
    Contributor

    I can implement this based on latest discussion

  9. joekaufmanexpensify commented on Oct 16, 2026

    @joekaufmanexpensify
    Contributor

    CC: @joekaufmanexpensify what do you think?

    Agreed. This feels like better UX, so the user gets feedback on why they weren't able to take the action, versus not showing it at all.

  10. 39 remaining items

  11. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    @huult Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. huult commented on Nov 11, 2026

    @huult
    Contributor

    The BE PR is up for review!

    Not overdue. The BE PR is under review.

    Same as above

  13. trjExpensify commented on Nov 11, 2026

    @trjExpensify
    Contributor

    Web PR went to prod yesterday. Can you continue, @huult?

  14. huult commented on Nov 12, 2026

    @huult
    Contributor

    @trjExpensify Yes, we can continue. The next step is for @apeyada to open the App PR, and then I’ll review it.

  15. huult commented on Nov 12, 2026

    @huult
    Contributor

    Frontend (me), I'd split into separate PRs so each can ship on its own:

    Search bulk pay for loaded selections ("Select all on this page" and individual selections): show the bank option, pay what's eligible, then show your mixed or "all skipped" modal with the bulleted report names. No backend change needed.
    Single report view: show the bank option for a report that's non-reimbursable or totals $0 or less, and show your single-report modal when it's picked. No backend change needed.
    "Select all": once the backend part is in, show the bank option, send the new params, and in BulkActionStatusModal use bank-payment titles ("Paying reports...", "Paid X of Y reports") plus your skipped copy with the existing "View reports" button.

    @apeyada When can you open the App PR?

  16. apeyada commented on Nov 12, 2026

    @apeyada
    Contributor

    PR is up. I'll mark as ready for review shortly.

  17. apeyada commented on Nov 12, 2026

    @apeyada
    Contributor

    @mollfpr skippedReportIDs isn't coming from backend. Always empty array[].
    I bulk paid 53 reports (1 reimbursable, 52 non-reimbursable)

    bug
  18. mollfpr commented on Nov 12, 2026

    @mollfpr
    ContributorAuthor

    Thanks for catching this. You’re right, it’s a backend bug. For “Select all”, the server looks up reports with the pay todo query, and that query already drops non-reimbursable and $0 reports. So they never reach the pay job and never show up in skippedReportIDs. I’ll fix it so those reports get listed as skipped. I’ll ping you when the fix is up!

  19. apeyada commented on Nov 12, 2026

    @apeyada
    Contributor

    I think this is expected but please confirm:

    Actually, this inconsistency will be fixed after #103871 (comment)

    • For non-reimbursable or $0 report: (not counted for payable reports)
    zero
    • For negative amount report: (counted for payable reports)
    negative
  20. huult commented on Nov 13, 2026

    @huult
    Contributor

    Thanks for catching this. You’re right, it’s a backend bug. For “Select all”, the server looks up reports with the pay todo query, and that query already drops non-reimbursable and $0 reports. So they never reach the pay job and never show up in skippedReportIDs. I’ll fix it so those reports get listed as skipped. I’ll ping you when the fix is up!

    @mollfpr Please let me know when the backend fix is ready. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions