Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: v9.5.13-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102379
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10 / Chrome
App Component: Search
Action Performed:
Precondition: Owner has some expenses submitted in his workspace. Has some expenses from other users.
- Go to Spend > Filter
- Open From filter> Select only Owner account
- Verify the options are displayed correctly
Result: The From column is missing from the results when filtering by the owner account. - Open From filter> Select another user account
Result: The column from appears with Owner account and the selected user.
Expected Result:
The results should display the From column with the corresponding expense information when filtering by the owner account.
Actual Result:
The From column is missing from the results when filtering by the owner account, but when adding another user account in From filter, column From appears correctly.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7288122_1792155763126.bandicam_2026-10-16_07-45-31-442.mp4
Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7288122
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022111122772036396436
- Upwork Job ID: 2111122772036396436
- Last Price Increase: 2026-10-16
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
applause-bot commentedon Oct 16, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a7637f48b01e44c6416ccd00f2e203b26564312bee705c7716b357811bb3b8da
MelvinBot commentedon Oct 16, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On Spend > Expenses, the From column disappears when the From filter is set to only your own account.
What is the root cause of that problem?
The default column logic shows From only when at least one row has an actor other than you (
SearchUIUtils.ts:6887-6892). Filteringfrom:to yourself makes every row yours, so From stays hidden. Adding another user brings in a row that isn't yours, so From comes back.This rule is intentional. It came from Auto show/hide columns depending on available data, but it does not consider an explicit
from:filter.What changes do you think we should make in order to solve the problem?
Always show From when the query has a
from:filter. This follows the existing pattern for the Violations column (queryHasViolationFilter).SearchQueryUtils.ts, addqueryHasFromFilter(queryJSON). It returns true whenflatFiltershas afromkey.shouldShowFromColumnparameter togetColumnsToShow. Show From when it is true or when the existing other-actor check passes.queryHasFromFilter(queryJSON)fromuseSearchColumnsToShow. For consistency, also pass it fromuseSearchOverlay,SortByPopup, anduseSearchBulkActions.from:filter.What alternative solutions did you explore? (Optional)
Removing the "is it me" check would show From on every personal default view. That works against the intent of the auto-hide feature.
Code references
getColumnsToShow:SearchUIUtils.ts:6447. From starts hidden at L6674.useSearchColumnsToShow.ts:39-50. It already hasqueryJSONand passesqueryHasViolationFilter(queryJSON).SearchQueryUtils.ts:823.SearchUIUtilsTest.ts:12487-12494.to:filter could get the same treatment, but this issue does not require it.Note: This changes intended behavior. Product should confirm that an explicit
from:filter should always show the From column.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/104247)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
melvin-bot commentedon Oct 16, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (
External)[-]Spend- From column Is missing when filtering by From is owner account[/-][+][$175] Spend- From column Is missing when filtering by From is owner account[/+]melvin-bot commentedon Oct 16, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022111122772036396436
camesenin commentedon Oct 16, 2026
melvin-bot commentedon Oct 16, 2026
Details
janiya2 commentedon Oct 16, 2026
Contributor details
Your Expensify account email: janithad2@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/janithad
Proposal
Please re-state the problem that we are trying to solve in this issue.
In Spend > Search results, when a user explicitly filters by
Fromand selects only their own account (or owner account), theFromcolumn disappears from the search results table. When another user account is added to theFromfilter, theFromcolumn reappears.What is the root cause of that problem?
In
src/libs/SearchUIUtils.ts(lines 6805–6808), the default dynamic column auto-hide logic determines whether to display theFromcolumn based on whether the transaction rows contain actors other than the current signed-in user:columns[CONST.SEARCH.TABLE_COLUMNS.FROM]is initialized tofalse(line 6590).from:owner), every row in the result belongs tocurrentAccountID. As a result, the conditionaccountID !== currentAccountIDis never satisfied, and theFromcolumn remains hidden (false).Fromcolumn makes sense on personal default views (where all expenses are implicitly yours), it fails to respect when a user has explicitly specified an activefrom:search filter.Violationscolumn usesqueryHasViolationFilter(queryJSON)to guarantee that an explicit violation filter always keeps the Violations column visible (useSearchColumnsToShow.ts:48). However, no corresponding check exists for theFromfilter.What changes do you think we should make in order to solve the problem?
Following the established pattern for
queryHasViolationFilter:queryHasFromFilterinsrc/libs/SearchQueryUtils.ts:shouldShowFromColumnparameter insrc/libs/SearchUIUtils.ts(getColumnsToShow):shouldShowFromColumnfromuseSearchColumnsToShow.ts(and relevant Search callers):(For complete consistency across the Search domain, also forward
shouldShowFromColumn: queryHasFromFilter(queryJSON)inSortByPopup.tsx,useSearchOverlay.ts, anduseSearchBulkActions.tswherevershouldShowViolationsColumnis provided).What alternative solutions did you explore? (Optional)
We explored unconditionally enabling the
Fromcolumn in default views even when all expenses belong to the signed-in user. However, that defeats the purpose of the auto-hide column optimization introduced in PR #68561 (which reduces visual noise when all displayed expenses belong to the user). Tying column visibility toshouldShowFromColumn: queryHasFromFilter(queryJSON)respects both user intent (when explicitly filtering) and clean default views.(Bonus architectural note: The
Tocolumn has the mirror logic at line 6820. If product desires parity for recipient filtering as well,queryHasToFiltercan be incorporated cleanly in the same manner).Tests
Automated Tests:
tests/unit/Search/SearchQueryUtilsTest.ts:queryHasFromFilter(queryJSON)returnstruewhenflatFilterscontainskey: CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM.falsewhen nofromfilter is present.tests/unit/Search/SearchUIUtilsTest.ts:currentAccountID:shouldShowFromColumn: false, the returned columns array does NOT includeCONST.SEARCH.TABLE_COLUMNS.FROM.shouldShowFromColumn: true, the returned columns array DOES includeCONST.SEARCH.TABLE_COLUMNS.FROM.Manual Verification:
Fromcolumn is displayed in the search results table showing the owner's avatar/name.Fromcolumn continues to be displayed correctly with both accounts.Fromfilter and navigate back to the default "Expenses" search.from:filter.melvin-bot commentedon Oct 16, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
taieddie commentedon Oct 16, 2026
Contributor details
Your Expensify account email: taieddie8@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01e51b3f9ff738cf94
Proposal
Please re-state the problem that we are trying to solve in this issue.
On Spend > Expenses, when filtering by the workspace owner or current user account in the
Fromfilter, theFromcolumn disappears from the search results table.What is the root cause of that problem?
In
src/libs/SearchUIUtils.ts:6889-6892, insidegetColumnsToShow, the conditionif (accountID && accountID !== currentAccountID)setscolumns[CONST.SEARCH.TABLE_COLUMNS.FROM] = true.The auto-hide column logic (introduced in PR #68561) only displays the
Fromcolumn if at least one row belongs to an actor differing fromcurrentAccountID. When a user explicitly filters by their own account (from: owner), every returned transaction matchesaccountID === currentAccountID. Because no differing actor exists,columns[CONST.SEARCH.TABLE_COLUMNS.FROM]remainsfalse. It fails silently. The table suppresses theFromcolumn even though the user explicitly filtered on it.What changes do you think we should make in order to solve the problem?
In
src/libs/SearchQueryUtils.ts, add a helperqueryHasUserFromFilter(queryJSON: SearchQueryJSON | undefined): booleanfollowing thequeryHasViolationFilterpattern:!isDefaultExpensesQuery(queryJSON)).queryJSON?.flatFiltersfor groups matchinggroup.key === CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM.group.filters.some((filter) => filter.operator === CONST.SEARCH.SYNTAX_OPERATORS.EQUAL_TO)to ensure the user has set an explicit positive equality filter.from:filters while strictly ignoring default presets and negated filters (such as-from:).In
src/libs/SearchUIUtils.ts, updategetColumnsToShow:shouldShowFromColumn: boolean = falseto the parameters object, defaulting tofalseso callers without user search filters maintain backwards compatibility (useMoneyRequestReportColumns.ts,ReportDetailsColumnsPage.tsx).Fromcheck to show the column whenshouldShowFromColumnis true or when an actor differs:if (shouldShowFromColumn || (accountID && accountID !== currentAccountID)) { columns[CONST.SEARCH.TABLE_COLUMNS.FROM] = true; }customResulttake precedence and ignoreshouldShowFromColumn, preserving user-configured columns.Thread
shouldShowFromColumnto search callers:src/components/Search/hooks/useSearchColumnsToShow.ts:39-50, passshouldShowFromColumn: queryHasUserFromFilter(queryJSON)intogetColumnsToShow.src/components/Search/SearchList/ListItem/GroupHeader.tsxandsrc/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsx, passshouldShowFromColumnderived strictly from the parentcurrentSearchQueryJSON(viauseSearchQueryContext()), never from childtransactionsQueryJSON. This avoids falsely forcing theFromcolumn on member-grouped sub-tables wherebuildSpecificGroupQueryautomatically injects afrom:clause.shouldShowFromColumnfromuseSearchOverlay.tsx,SortByPopup.tsx, anduseSearchBulkActions.tsso table display, sort popup, and CSV exports remain identical.Unit Tests:
tests/unit/Search/useSearchSnapshotTest.ts:71-74, update the@libs/SearchQueryUtilsjest mock to includequeryHasUserFromFilter: () => falsesouseSearchColumnsToShowinvocations insideuseSearchSnapshottests pass without undefined function errors.tests/unit/Search/SearchUIUtilsTest.ts, add test cases verifying:currentAccountIDandshouldShowFromColumnisfalse, theFromcolumn is hidden (preserving auto-hide for default expense views).currentAccountIDandshouldShowFromColumnistrue, theFromcolumn is shown.customResultignoreshouldShowFromColumnand preserve the user's custom columns.tests/unit/Search/SearchQueryUtilsTest.ts, verify thatqueryHasUserFromFilterreturnstruefor positive user-enteredfrom:, andfalsefor default queries (isDefaultExpensesQuery) or negated-from:.What alternative solutions did you explore? (Optional)
Earlier proposals by @MelvinBot suggest simply checking
flatFilters.fromwithout checking filter operators or default provenance. MelvinBot misses negative filters like-from:and risks showing theFromcolumn on default views that injectfromunder the hood. MelvinBot also evaluatestransactionsQueryJSONin grouped tables, causing member-grouped sub-tables to incorrectly force theFromcolumn. DerivingshouldShowFromColumnstrictly from the parentcurrentSearchQueryJSONand validating positive equality inSearchQueryUtilsresolves the issue cleanly across all search surfaces without regressions.29 remaining items
melvin-bot commentedon Nov 4, 2026
@linhvovan29546 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Nov 4, 2026
@linhvovan29546 Still overdue 6 days?! Let's take care of this!
sam5235 commentedon Nov 4, 2026
@linhvovan29546 @trjExpensify I can reproduce this on staging, and I think I know why it doesn't show up for everyone.
It only happens when the search has no saved column list, meaning there's no
columns:in the URL. Once a column list is in the query,Fromshows even when you filter to yourself. Any account that has edited columns gets that list, and the app keeps reopening the last query, so it hides the bug.To see it on any account (needs at least one expense from another member):
Fromcolumn shows.Filters>From> select only yourself >Apply. TheFromcolumn disappears.Fromfilter. TheFromcolumn is back.104247-repro-github.mp4
I built the
Paidcolumn (#103956) and the expanded-group date column fix (#105307) in this code. I have the root cause and a small fix for this, and I'm happy to take it if it's opened up.melvin-bot commentedon Nov 5, 2026
@linhvovan29546 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
jeffrey-graham commentedon Nov 7, 2026
melvin-bot commentedon Nov 7, 2026
jeffrey-graham commentedon Nov 7, 2026
melvin-bot commentedon Nov 9, 2026
@linhvovan29546 12 days overdue. Walking. Toward. The. Light...
linhvovan29546 commentedon Nov 10, 2026
@MelvinBot Based on the discussion in this issue, would you like to update the proposal?
MelvinBot commentedon Nov 10, 2026
Updated proposal
The product clarification changes the recommendation: keep dynamic column hiding; make the Columns selector reflect what the table actually displays. My earlier proposal to force
Fromwhenever afrom:filter exists should be withdrawn.What is the root cause of that problem?
Without an explicit
columns:selection, the table intentionally hidesFromwhen every expense belongs to the signed-in user. Explicit column selections override that behavior, explaining why account history appeared to affect reproduction.The actionable problem is
Frombeing checked in the selector while hidden in the table, not dynamic hiding itself.However, current main already contains selector-seeding logic for loaded, ungrouped searches. Code inspection alone therefore does not establish a remaining bug in that path.
Code evidence
What changes do you think we should make in order to solve the problem?
Preserve these behaviors:
Fromis unchecked but available to select.Fromand saving explicitly shows it, including for self-only results.Before proposing additional production changes, verify whether the reported mismatch persists with the existing implementation. Add regression coverage for self-only results, results containing another member, explicitly selecting
From, and resetting columns. Keep grouped searches separate rather than copying their summary columns into the expense-column selector.What alternative solutions did you explore? (Optional)
Forcing
Fromfor everyfrom:filter would change behavior product explicitly accepted, so it is no longer recommended.Verification: Source inspection only; current browser behavior has not been verified. I would not recommend implementing the original proposal.
view run
linhvovan29546 commentedon Nov 10, 2026
@trjExpensify I re-tested on latest
mainwith a fresh account. WithFromfiltered to only thecurrent user, the table hidesFromand theColumnspage shows itunchecked. Adding another account to thefilterbrings thecolumnback, and theColumnspage shows itchecked. So the selector already matches the table in both cases, and the mismatch I saw earlier doesn't reproduce anymore. What's left is the intentional auto-hide (#68561). Can we close this?trjExpensify commentedon Nov 11, 2026
Yep, thanks!