Skip to content

[Due for payment 2026-11-10] [$250] [Sentry: APP-N5H] HybridApp Android: native tab bar crashes with more than 6 items #104505

Closed

Description

@mountiny

Sentry

https://expensify.sentry.io/issues/APP-N5H

Impact (snapshot at filing)

  • Users (total since first seen): 39
  • Events: 143
  • Users (last 14d, all versions): 39
  • Users (last 14d, production 9.5.11 to 9.5.13): 1
  • First seen: 2026-10-16 (4 days ago)
  • Last seen: 2026-10-20 (ongoing, Sentry marks it as escalating)
  • Platform: Android HybridApp
  • App version(s): 9.5.13-0 (31 users) and 9.5.13-1 (4 users), plus 1 user each on 9.5.9-4, 9.5.10-0, 9.5.11-0, 9.5.13-3 and 9.5.14-0
  • Affected route(s) (parameterized): native screen; the sample event was on Settings_Troubleshoot
  • Mechanism: UncaughtExceptionHandler, level fatal

Most users were on 9.5.13-0, a staging build. 9.5.13-6 is now rolling out to production on Android, so this may grow.

Stack trace (top frames, first-party only)

com.swmansion.rnscreens.ScreenStack.onUpdate (ScreenStack.kt:323)
com.swmansion.rnscreens.gamma.tabs.container.TabsContainer.onAttachedToWindow (TabsContainer.kt:311)
com.swmansion.rnscreens.gamma.tabs.container.TabsContainer.flushPendingUpdates (TabsContainer.kt:212)
com.swmansion.rnscreens.gamma.tabs.container.TabsContainer.updateNavigationMenuStructure (TabsContainer.kt:545)
com.swmansion.rnscreens.gamma.tabs.container.MenuHelpersKt.getOrCreateMenuItemForFragment (MenuHelpers.kt:8)
androidx.appcompat.view.menu.MenuBuilder.add
IllegalArgumentException: Maximum number of items supported by CustomBottomNavigationView is 6

Suspected cause

The native tab container adds a seventh item to the Android bottom navigation menu, which supports at most 6. It happens when a screen stack attaches the tab container again, so the tab menu items may be added again instead of reused.

Reproduction

Unknown. See the Sentry events linked from the Sentry issue.

Related

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @wildan-m

Activity

  1. self-assigned this
    on Oct 20, 2026
  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 20, 2026
  3. melvin-bot commented on Oct 20, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  4. changed the title [-][Sentry: APP-N5H] HybridApp Android: native tab bar crashes with more than 6 items[/-] [+][$175] [Sentry: APP-N5H] HybridApp Android: native tab bar crashes with more than 6 items[/+] on Oct 20, 2026
  5. melvin-bot commented on Oct 20, 2026

    @melvin-bot
  6. RajGahoi commented on Oct 20, 2026

    @RajGahoi

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    HybridApp on Android crashes with IllegalArgumentException: Maximum number of items supported by CustomBottomNavigationView is 6 when a screen stack re-attaches the native tab container or when more than 6 navigation items are added.

    What is the root cause of that problem?

    Android's BottomNavigationView / CustomBottomNavigationView enforces a hard limit of maximum 6 items (MAX_ITEM_COUNT = 6).

    In PR #101339 and patch @react-navigation+bottom-tabs+7.19.2+003+hidden-tab-items.patch, the app registers 6 tab routes:
    HOME, REPORTS_SPLIT_NAVIGATOR, SEARCH_FULLSCREEN_NAVIGATOR, INSIGHTS, WORKSPACE_NAVIGATOR, SETTINGS_SPLIT_NAVIGATOR.
    Although getTabWithoutBarItem designates one route as abBarItemHidden: true to stay at 5 items, when a screen stack re-attaches (ScreenStack.kt:onUpdate -> TabsContainer.kt:onAttachedToWindow -> flushPendingUpdates -> updateNavigationMenuStructure), menu items from the previous fragment attachment can persist or re-accumulate without clearing or recycling if lushPendingUpdates runs repeatedly during stack transitions. Adding the new items pushes the menu size to 7 (or above), throwing IllegalArgumentException: Maximum number of items supported by CustomBottomNavigationView is 6.

    What changes do you think we should make in order to solve the problem?

    1. In TabsContainer.kt (or via patch to
      eact-native-screens), before calling updateNavigationMenuStructure / getOrCreateMenuItemForFragment, ensure menu.clear() is called or check that existing menu items matching the fragment tabs are reused/updated rather than re-added.
    2. In @react-navigation+bottom-tabs+7.19.2+003+hidden-tab-items.patch, strictly guard that routes marked with abBarItemHidden: true are never passed as native tab fragments to RNScreens under any transition state.

    Automated Tests

    Add a test in ScreenStackTest / navigation tests that mounts the native tab navigator, performs stack pushes and pops (such as opening Settings_Troubleshoot), and verifies that the menu items count in BottomNavigationView never exceeds 5.

    Contributor details
    Your Expensify account email: gahoiraj01@gmail.com

  7. RajGahoi commented on Oct 20, 2026

    @RajGahoi

    Contributor details update:
    Upwork Profile Link: https://www.upwork.com/freelancers/~014898525b9c53fc32

  8. jloa-dev commented on Oct 21, 2026

    @jloa-dev

    Contributor details
    Your Expensify account email: jloa.dev@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0163955a2ba221e513

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On Android HybridApp, navigating between screens (e.g., visiting Settings_Troubleshoot or during screen transitions inside a ScreenStack) crashes fatally with:
    IllegalArgumentException: Maximum number of items supported by CustomBottomNavigationView is 6
    thrown from:

    com.swmansion.rnscreens.ScreenStack.onUpdate (ScreenStack.kt:323)
    com.swmansion.rnscreens.gamma.tabs.container.TabsContainer.onAttachedToWindow (TabsContainer.kt:311)
    com.swmansion.rnscreens.gamma.tabs.container.TabsContainer.flushPendingUpdates (TabsContainer.kt:212)
    com.swmansion.rnscreens.gamma.tabs.container.TabsContainer.updateNavigationMenuStructure (TabsContainer.kt:545)
    com.swmansion.rnscreens.gamma.tabs.container.MenuHelpersKt.getOrCreateMenuItemForFragment (MenuHelpers.kt:8)
    androidx.appcompat.view.menu.MenuBuilder.add
    

    What is the root cause of that problem?

    1. In react-native-screens (gamma tabs on Android), TabsContainer manages bottom navigation tabs using CustomBottomNavigationView (based on Android Material's BottomNavigationView). Android's bottom navigation menu enforces a strict hardware constraint:
      MAX_ITEM_COUNT = 6 (or 5 standard, 6 custom). Adding a 7th item to MenuBuilder throws IllegalArgumentException.
    2. In ScreenStack.kt:286, when screen fragments are updated or re-appended in stack order, the fragment containing the tab bar is detached and re-attached to the window (transaction.remove(wrapper.fragment) followed by transaction.add(...)).
    3. When TabsContainer.onAttachedToWindow() executes, it calls flushPendingUpdates() -> updateNavigationMenuStructure().
    4. In updateNavigationMenuStructure(), TabsContainer iterates through its tab fragments and calls getOrCreateMenuItemForFragment(fragment) which delegates to bottomNavigationView.menu.add(...).
    5. However, updateNavigationMenuStructure() does not clear or synchronize the existing bottomNavigationView.menu prior to re-populating items. Because items from the initial layout pass are already present in the menu, re-adding the tabs appends duplicate menu items to the MenuBuilder. As soon as menu.size() reaches 7 (e.g. 4 tabs added twice = 8 items), Android throws IllegalArgumentException: Maximum number of items supported by CustomBottomNavigationView is 6.

    What alternative solutions did you explore? (Optional)

    None, clearing or diffing existing menu items in TabsContainer.updateNavigationMenuStructure before adding items is the cleanest, idiomatic solution.

    What changes do you think we should make in order to solve the problem?

    Add a patch in patches/react-native-screens/ (or update existing gamma patches, e.g. react-native-screens+4.28.0+006+clear-tab-menu-before-update.patch):

    In node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/gamma/tabs/container/TabsContainer.kt:
    Before populating fragments in updateNavigationMenuStructure(), clear the existing menu:

    --- a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/gamma/tabs/container/TabsContainer.kt
    +++ b/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/gamma/tabs/container/TabsContainer.kt
    @@ -540,6 +540,7 @@ class TabsContainer(
         }
     
         private fun updateNavigationMenuStructure() {
    +        bottomNavigationView.menu.clear()
             fragments.forEachIndexed { index, fragment ->
                 val menuItem = getOrCreateMenuItemForFragment(fragment)
                 // configure item...

    Or in MenuHelpers.kt:
    Ensure that getOrCreateMenuItemForFragment checks bottomNavigationView.menu.findItem(fragment.id) instead of unconditionally calling menu.add(...).

    What automated tests can you add to prevent this from re-occurring?

    Add an Android instrumented/unit test for TabsContainer verifying that calling onAttachedToWindow() and flushPendingUpdates() repeatedly on a TabsContainer with 4-5 tabs never causes bottomNavigationView.menu.size() to exceed the fragment count or throw IllegalArgumentException.

  9. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  10. sijo0218 commented on Oct 21, 2026

    @sijo0218

    Contributor details
    Your Expensify account email: sijo0218@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~011091133bbb09cd1c

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On Android HybridApp, navigating between screens (e.g. visiting sub-pages or during screen transitions in a ScreenStack) fatal crashes with:

    IllegalArgumentException: Maximum number of items supported by CustomBottomNavigationView is 6
    

    thrown from:

    com.swmansion.rnscreens.ScreenStack.onUpdate (ScreenStack.kt:323)
    com.swmansion.rnscreens.gamma.tabs.container.TabsContainer.onAttachedToWindow (TabsContainer.kt:311)
    com.swmansion.rnscreens.gamma.tabs.container.TabsContainer.flushPendingUpdates (TabsContainer.kt:212)
    com.swmansion.rnscreens.gamma.tabs.container.TabsContainer.updateNavigationMenuStructure (TabsContainer.kt:545)
    com.swmansion.rnscreens.gamma.tabs.container.MenuHelpersKt.getOrCreateMenuItemForFragment (MenuHelpers.kt:8)
    androidx.appcompat.view.menu.MenuBuilder.add
    

    What is the root cause of that problem?

    There are two interconnected defects in react-native-screens gamma tabs on Android:

    1. Child Removal Failure in Fabric (TabsHostViewManager):

      • In React Native Fabric, ViewGroupManager manages view additions and removals by inspecting child views via getChildCount(parent) and getChildAt(parent, index).
      • In TabsHostViewManager.kt, TabsHost does not attach TabsScreen views directly as Android ViewGroup children (they are managed in an internal renderedScreens list and encapsulated in TabsScreenFragment inside TabsContainer.tabsModel).
      • However, TabsHostViewManager does not override getChildCount or getChildAt. Consequently, React Native defaults to parent.childCount (which only sees the root container, count = 1).
      • When Fabric attempts to remove an inactive or toggled tab child at index > 0, getChildAt(parent, index) returns out of bounds or mismatches, causing Fabric to consider the view "already removed from parent" and skip calling removeViewAt / removeView.
      • As a result, TabsHost.unmountReactSubviewAt and TabsContainer.removeTabsScreenAt are never called for the old tab. When the tab or replacement screen is re-mounted, TabsHostViewManager.addView calls mountReactSubviewAt -> container.addTabsScreenAt, appending another fragment into tabsModel.
      • Every tab transition or beta re-render leaks stale fragments into tabsModel, causing tabsModel.size to grow beyond 5 to 7 or more.
    2. Uncapped Menu Population against Hardware Limits in updateNavigationMenuStructure():

      • In TabsContainer.kt:532-547:
        private fun updateNavigationMenuStructure() {
            val menu = bottomNavigationView.menu
            val isMenuInSync =
                menu.size == tabsModel.size &&
                    tabsModel.withIndex().all { (index, fragment) ->
                        menu.getItem(index).itemId == fragment.menuItemId
                    }
            if (isMenuInSync) return
            menu.clear()
            tabsModel.forEach { fragment ->
                menu.getOrCreateMenuItemForFragment(fragment)
            }
        }
      • Notice that menu.clear() on line 543 does clear bottomNavigationView.menu. However, tabsModel.forEach iterates over all items in tabsModel without checking bottomNavigationView.maxItemCount (MAX_ITEM_COUNT = 6 in CustomBottomNavigationView / Android Material NavigationBarMenu).
      • In TabsHost.kt:76, mountReactSubviewAt only checks index < bottomNavigationViewMaxItemCount, never checking whether renderedScreens.size >= bottomNavigationViewMaxItemCount or whether the TabsScreen is already mounted.
      • When ScreenStack.onUpdate executes (e.g. re-attaching screens in stack order via transaction.commitNowAllowingStateLoss()), TabsContainer.onAttachedToWindow calls flushPendingUpdates() -> updateNavigationMenuStructure(). Because tabsModel accumulated 7 or more fragments, tabsModel.forEach attempts to add the 7th item into bottomNavigationView.menu.
      • NavigationBarMenu.addInternal detects size() + 1 > maxItemCount (7 > 6) and throws IllegalArgumentException: Maximum number of items supported by CustomBottomNavigationView is 6.

    What alternative solutions did you explore? (Optional)

    Attempting to only cap at the JS layer (NativeBottomTabView.native.js) is insufficient because Fabric view re-ordering and remount cycles on Android will still leak native fragments inside TabsHost.renderedScreens and TabsContainer.tabsModel if TabsHostViewManager cannot report its children. Both the view manager lifecycle and native container menu bounds must be secured.

    What changes do you think we should make in order to solve the problem?

    Add a patch in patches/react-native-screens/react-native-screens+4.28.0+006+fix-tabs-host-child-lifecycle-and-menu-limit.patch:

    1. In TabsHostViewManager.kt:
      Override getChildCount and getChildAt to reflect renderedScreens so Fabric can successfully unmount child screens:

      override fun getChildCount(parent: TabsHost): Int = parent.renderedScreensCount
      
      override fun getChildAt(parent: TabsHost, index: Int): View? = parent.getRenderedScreenAt(index)
    2. In TabsHost.kt:
      Expose renderedScreensCount and getRenderedScreenAt(index):

      internal val renderedScreensCount: Int
          get() = renderedScreens.size
      
      internal fun getRenderedScreenAt(index: Int): TabsScreen? =
          renderedScreens.getOrNull(index)

      In mountReactSubviewAt, guard against duplicate insertion and ensure renderedScreens deduplicates any existing entry for the same screen:

      internal fun mountReactSubviewAt(tabsScreen: TabsScreen, index: Int) {
          unmountReactSubview(tabsScreen)
          val maxCount = container.bottomNavigationView.maxItemCount
          require(renderedScreens.size < maxCount) {
              "[RNScreens] Cannot mount TabsScreen: container already reached maximum capacity of $maxCount items"
          }
          renderedScreens.add(index.coerceAtMost(renderedScreens.size), tabsScreen)
          tabsScreen.setTabsScreenDelegate(container)
          container.addTabsScreenAt(index.coerceAtMost(renderedScreens.size - 1), tabsScreen)
      }
    3. In TabsContainer.kt:
      In addTabsScreenAt, deduplicate matching screens:

      internal fun addTabsScreenAt(index: Int, tabsScreen: TabsScreen) {
          tabsModel.removeIf { it.tabsScreen === tabsScreen || it.requireScreenKey == tabsScreen.requireScreenKey }
          tabsModel.add(index.coerceAtMost(tabsModel.size), TabsScreenFragment(tabsScreen))
          invalidationFlags.invalidateAll()
      }

      In updateNavigationMenuStructure(), bound the iteration strictly to bottomNavigationView.maxItemCount:

      private fun updateNavigationMenuStructure() {
          val menu = bottomNavigationView.menu
          val isMenuInSync =
              menu.size == tabsModel.size &&
                  tabsModel.withIndex().all { (index, fragment) ->
                      menu.getItem(index).itemId == fragment.menuItemId
                  }
      
          if (isMenuInSync) {
              return
          }
          menu.clear()
          val maxItems = bottomNavigationView.maxItemCount
          tabsModel.take(maxItems).forEach { fragment ->
              menu.getOrCreateMenuItemForFragment(fragment)
          }
      }

    What automated tests can you add to prevent this from re-occurring?

    1. In Android unit/integration tests (TabsContainerTest / TabsHostTest), verify that repeatedly mounting, unmounting, and re-mounting tabs on TabsHost with Fabric view manager dispatches:
      • Maintains renderedScreens.size == tabsModel.size.
      • Never exceeds bottomNavigationView.maxItemCount.
      • Never throws IllegalArgumentException during onAttachedToWindow() and flushPendingUpdates().
    2. In tests/unit/NativeBottomTabViewTest.tsx, add test cases simulating rapid navigation transitions across tab routes and beta toggles to ensure the number of native Tabs.Screen children mounted to Tabs.Host never exceeds 5.
  11. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  12. 53 remaining items

  13. melvin-bot commented on Nov 12, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. mallenexpensify commented on Nov 13, 2026

    @mallenexpensify
    Contributor

    The Deploy Blocker issue #105783 is repro on all PRs. Could you please double check if it's not introduced by #105058

    @mananjadhav this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.

  15. mananjadhav commented on Nov 13, 2026

    @mananjadhav
    Collaborator

    @mallenexpensify Apologies I only checked the issue comments and not the PR.

    As mentioned in this comment here, it seems to be related to an invalid credentials error. Plus our change was on the Android tabs only. Both are unrelated.

  16. mallenexpensify commented on Nov 15, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @wildan-m paid $250 via Upwork
    Contributor+: @mananjadhav due $250 via NewDot

  17. wildan-m commented on Nov 17, 2026

    @wildan-m
    Contributor

    @mallenexpensify I still not receive upwork offer for this one

  18. mallenexpensify commented on Nov 17, 2026

    @mallenexpensify
    Contributor

    @wildan-m can you please accept the job below? Please reply here and tag me once you have. Updated price too, apologies
    https://www.upwork.com/jobs/~022112637848604843209

  19. wildan-m commented on Nov 17, 2026

    @wildan-m
    Contributor

    @mallenexpensify can make it as an offer instead of job? i low on upwork connect at the moment

  20. mallenexpensify commented on Nov 17, 2026

    @mallenexpensify
    Contributor

    @wildan-m can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022112637848604843209

    I'll ping ya in Slack too

  21. wildan-m commented on Nov 17, 2026

    @wildan-m
    Contributor

    @mallenexpensify offer accepted

  22. mallenexpensify commented on Nov 18, 2026

    @mallenexpensify
    Contributor

    @wildan-m paid, summary updated above. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions