You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-02] Memoize Search column size options so leaving Spend doesn't re-render every row #104718
Search doesn't compile with React Compiler, and it built columnSizeOptions as a new object on every render. That object reaches SearchColumnWidthsContext through SearchListViewLayout, so each Search render gave every TransactionItemRowWide new column styles and re-rendered every row and its cells. In the flat expense and expense report views, useSearchColumnWidths also measured the text of every row again.
Search re-renders when the Spend tab loses focus, so tapping Inbox from Spend paid for all of it inside ManualNavigateToInboxTab.
Lets create a PR to use a useMemo with the same flags. The memo sits above the component's early returns, where its inputs already exist, so rows re-render only when a column changes width. The values don't change.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A - performance issue
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Oct 26, 2026
@JS00001 @BartekObudzinski
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
8 remaining items
melvin-bot commentedon Nov 1, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Nov 1, 2026
Payment Summary
Resolving PRs:
perf: memoize Search column size options so leaving Spend doesn't re-render every row #104716
Contributor: @BartekObudzinski does not require payment (Contractor)
Assignee: @Eskalifer1 requires payment (Needs manual offer from BZ)
BugZero Checklist (@mallenexpensify)
Eskalifer1 commentedon Nov 2, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A - performance issue
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
N/A - performance issue
melvin-bot commentedon Nov 5, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Nov 5, 2026
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Nov 5, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Nov 5, 2026
Payment Summary
Contributor+: @Eskalifer1 paid $175 via Upwork
@Eskalifer1 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022118425976630387202
Eskalifer1 commentedon Nov 5, 2026
Hi @mallenexpensify, i have accepted, thank you!
mallenexpensify commentedon Nov 6, 2026
@Eskalifer1 paid, summary updated above. Thx.