Skip to content

[Due for payment 2026-11-02] Memoize Search column size options so leaving Spend doesn't re-render every row #104718

Closed

Description

@JS00001

Coming from #104716:

Search doesn't compile with React Compiler, and it built columnSizeOptions as a new object on every render. That object reaches SearchColumnWidthsContext through SearchListViewLayout, so each Search render gave every TransactionItemRowWide new column styles and re-rendered every row and its cells. In the flat expense and expense report views, useSearchColumnWidths also measured the text of every row again.

Search re-renders when the Spend tab loses focus, so tapping Inbox from Spend paid for all of it inside ManualNavigateToInboxTab.

Lets create a PR to use a useMemo with the same flags. The memo sits above the component's early returns, where its inputs already exist, so rows re-render only when a column changes width. The values don't change.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Oct 26, 2026

    @melvin-bot

    @JS00001 @BartekObudzinski

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

  2. self-assigned this
    on Oct 26, 2026
  3. 8 remaining items

  4. melvin-bot commented on Nov 1, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  5. melvin-bot commented on Nov 1, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  6. Eskalifer1 commented on Nov 2, 2026

    @Eskalifer1
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A - performance issue

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      N/A - performance issue

  7. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  8. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. mallenexpensify commented on Nov 5, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Eskalifer1 paid $175 via Upwork

    @Eskalifer1 can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022118425976630387202

  11. Eskalifer1 commented on Nov 5, 2026

    @Eskalifer1
    Contributor

    Hi @mallenexpensify, i have accepted, thank you!

  12. mallenexpensify commented on Nov 6, 2026

    @mallenexpensify
    Contributor

    @Eskalifer1 paid, summary updated above. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions