Skip to content

[Due for payment 2026-11-14] Migrate ParticipantPicker to @react-navigation modal screen #104753

Closed

Description

@MelvinBot

Context

This is a sub-issue of #53493 (Replace modal screens with modals from @react-navigation).

ParticipantPicker was missed by the migration inventory. It was added in #87920 (Apr 28), after the Apr 24 inventory, and shipped behind a beta. The Jul 22 triage skipped it while that beta was being reverted and its iOS freeze was being fixed.

Problem

ParticipantPicker still renders a react-native-modal-based Modal (src/components/ParticipantPicker/index.tsx:24). It has the same animation and navigation problems as the other modals tracked in #53493.

Migration approach

The routed version already exists: DynamicIOURequestStepParticipants, with the confirmation step as an entry screen. Replace the ParticipantPicker modal with navigation to that route.

PR

#104751

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added and removed
    ReviewingHas a PR in review
    on Nov 7, 2026
  2. changed the title [-]Migrate ParticipantPicker to @react-navigation modal screen[/-] [+][Due for payment 2026-11-14] Migrate ParticipantPicker to @react-navigation modal screen[/+] on Nov 7, 2026
  3. 1 remaining item

  4. parasharrajat commented on Nov 8, 2026

    @parasharrajat
    Member

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: Refactor
      Link to the comment on the Issue: Refactor

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/705715

    Regression Test Proposal

    Precondition:

    Test:

    Scenario 1 - Change recipient from the "To" row

    1. Open app
    2. Navigate to FAB > Create expense > Manual, fill in an amount and a category, then press the "To" row
    3. Press the referral banner, go back, and verify that the "Choose recipient" page is still open
    4. Select a different workspace and verify that the app returns to the form with that workspace in "To" and the category cleared

    Scenario 2 - Auto open

    1. Open app
    2. Navigate to FAB > Create expense > Manual
    3. Verify that the "Choose recipient" page slides in as an RHP screen over the form
    4. Select "You" and verify that the app returns to the form with the expense on your self DM, the app does not freeze, and the recipient page does not open again

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-2fd9-a145-9120-880a11c19654
  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 8, 2026
  6. melvin-bot commented on Nov 13, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. melvin-bot commented on Nov 13, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  8. mallenexpensify commented on Nov 17, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    Ready. Job price: $175 (standard, no Help Wanted, assigned 2026-10-22).

    • parasharrajat (C+): 100%, via NewDot

    No deploy blockers or regressions on the issue or the PR.

    Next: press Caps+Y, then pay.

    Evidence
    • BugZero checklist, with test steps: comment. No TestRail case yet.
    • Resolving PR 104751: by jmusial (agency), merged 2026-11-05, approved by mountiny and parasharrajat. No revert.
    • Videos: author 5/5, C+ 4/4.

    PAYPREP v1

  9. mallenexpensify commented on Nov 17, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @parasharrajat due $175 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions