You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD FormidableLabs/victory-native-xl#687] Upgrade react-native-skia to v3 #105154
On hold for FormidableLabs/victory-native-xl#687 (feat!: migrate to Skia 3 and Gesture Handler 3). victory-native does not support Skia 3 yet, and that PR is still a draft.
Background
App uses @shopify/react-native-skia@^2.11.2 and victory-native@^42.0.1. Skia 3 changes the renderer backend significantly (https://wcandillon.dev/article/hello-graphite-performance), which should improve performance without other changes.
App already meets the PR's other requirements: react-native-gesture-handler@3.3.0 and react-native-reanimated@4.7.0.
Steps after the HOLD lifts
Upgrade victory-native to the release that includes Skia 3 support.
Replace @shopify/react-native-skia with react-native-skia@3.x and update imports. Skia 3 renames the package.
Replace any async CanvasRef snapshot calls. Skia 3 removes them.
Check whether canvaskit-wasm needs a version bump for web.
Test charts on iOS, Android, and web, including the server/victory-chart-renderer workspace.
Compare chart rendering performance before and after the upgrade.
Activity