Skip to content

[HOLD FormidableLabs/victory-native-xl#687] Upgrade react-native-skia to v3 #105154

Open

Description

@melvin-bot

HOLD

On hold for FormidableLabs/victory-native-xl#687 (feat!: migrate to Skia 3 and Gesture Handler 3). victory-native does not support Skia 3 yet, and that PR is still a draft.

Background

App uses @shopify/react-native-skia@^2.11.2 and victory-native@^42.0.1. Skia 3 changes the renderer backend significantly (https://wcandillon.dev/article/hello-graphite-performance), which should improve performance without other changes.

App already meets the PR's other requirements: react-native-gesture-handler@3.3.0 and react-native-reanimated@4.7.0.

Steps after the HOLD lifts

  1. Upgrade victory-native to the release that includes Skia 3 support.
  2. Replace @shopify/react-native-skia with react-native-skia@3.x and update imports. Skia 3 renames the package.
  3. Replace any async CanvasRef snapshot calls. Skia 3 removes them.
  4. Check whether canvaskit-wasm needs a version bump for web.
  5. Test charts on iOS, Android, and web, including the server/victory-chart-renderer workspace.
  6. Compare chart rendering performance before and after the upgrade.

Slack thread: https://expensify.slack.com/archives/C08CZDJFJ77/p1793050619592069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions