Skip to content

[Due for payment 2026-11-09] Web - Spend - Paid date is truncated in table view #105276

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.24-5
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103956
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Search

Action Performed:

Precondition:

  • There is at least one paid expense from previous year.
  1. Go to staging.new.expensify.com
  2. Go to Spend > Expenses.
  3. Apply the following filters:
  • Filters > Status > Paid
  • Filters > Date > Last year
  • Display > Group by > From
  • Display > Edit columns > Paid
  1. Expand any group.

Expected Result:

Paid date will be shown completely in table view.

Actual Result:

Paid date is truncated in table view.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7298946_1793204272463.10.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7298946

Issue OwnerCurrent Issue Owner: @FitseTLT

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2026
  2. applause-bot commented on Oct 28, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/9ee0f4c76c3c6caf0cb76543641d04de8c1bde4130702e2593355b89bdc4eb7c

  3. melvin-bot commented on Oct 28, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #103956

  4. melvin-bot commented on Oct 28, 2026

    @melvin-bot

    @JS00001 @FitseTLT @garrettmknight you have been assigned to this deploy blocker because you reviewed the offending PR: #103956

  5. melvin-bot commented on Oct 28, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Oct 28, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. MelvinBot commented on Oct 28, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: feat: add a Paid column option to the Spend reports table (author sam5235). High confidence. It is the only PR on Deploy Checklist: New Expensify 2026-10-27 that touches these files.

    Root cause: The expanded "Group by" table never widens the Paid column for past-year dates. The column stays at 62px, so "Mar 12, 2025" gets cut off. The ungrouped table handles this correctly.

    Recommendation: roll forward. The fix is about 15 lines across 3 files. A revert would remove a 20-file feature to fix one column width.

    1. SearchUIUtils.ts getGroupColumnWidthFlags: add shouldShowYearPaid, set it from transaction.shouldShowYearPaid, and include it in the early-break check.
    2. TransactionGroupListExpanded.tsx: pass shouldShowYearPaid to SearchTableHeader, and pass paidColumnSize (WIDE or NORMAL) to each TransactionItemRow.
    3. GroupHeader.tsx: pass shouldShowYearPaid to its sticky SearchTableHeader so the header matches the rows.

    If a fix can't land in time, revert the PR.

    Investigation details
    • The Paid column is 102px only when isPaidColumnWide is set, otherwise 62px: styles/utils/index.ts#L2052-L2054.
    • The date cell uses "MMM d, yyyy" for past-year dates: DateCell.tsx#L43-L46. This is why the repro needs Date = Last year.
    • The ungrouped table reads shouldShowYearPaid and passes paidColumnSize to the row (TransactionListItemWide.tsx#L144, #L226). Its header does the same (SearchTableHeader.tsx#L718).
    • Each grouped transaction carries shouldShowYearPaid (SearchUIUtils.ts#L2043). However, neither TransactionGroupListExpanded.tsx nor GroupHeader.tsx reads it. As a result, paidColumnSize is undefined in the row and the cell stays narrow (TransactionItemRowWide.tsx#L170, #L310-L323).
    • The header and rows are both 62px, so the columns align and the text is just truncated.
    • Side note: Submitted, Approved, Posted and Exported have the same gap in expanded groups. Based on the code, they likely truncate past-year dates in production already. The PR copied that existing pattern. Fixing them in the same change is optional for this blocker.

    view run

  8. JS00001 commented on Oct 28, 2026

    @JS00001
    Contributor

    yeah we can demote, @FitseTLT @sam5235 lets fix this in a follow up please

  9. 7 remaining items

  10. melvin-bot commented on Oct 28, 2026

    @melvin-bot

    @FitseTLT — to hire @sam5235 on Upwork, add the External label so a job is created and the offer is sent automatically.

  11. JS00001 commented on Oct 29, 2026

    @JS00001
    Contributor

    yeah lets fix for all of them

  12. added and removed
    ReviewingHas a PR in review
    on Nov 2, 2026
  13. changed the title [-]Web - Spend - Paid date is truncated in table view[/-] [+][Due for payment 2026-11-09] Web - Spend - Paid date is truncated in table view[/+] on Nov 2, 2026
  14. melvin-bot commented on Nov 2, 2026

    @melvin-bot

    @FitseTLT

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.27-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-09. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  15. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @FitseTLT Whoops! This issue is 2 days overdue. Let's get this updated quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions