You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-14] Zoho Books - Error shows up after selecting company card account #105676
Version Number: 9.5.28-4 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102712 Email or phone of affected tester (no customers):jsodijnosidjonj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enable zohoBooks beta.
Connect to Zoho Books.
Go to staging.new.expensify.com
Go to workspace settings > Connections.
Click Zoho Book.
Click Export.
Click Company card account.
Select any account.
Click Company card account.
Expected Result:
No error will show up after selecting company card account.
Actual Result:
Error shows up after selecting company card account.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The auto-assigned PR, feat: Allow admins to merge approved reports, is unrelated. It only touches report-merge code and language files. Its author and reviewers can be unassigned, and the author and reviewers of #105240 should be assigned instead.
Root cause: The error is the App's failure fallback. It appears when the backend rejects the UpdateZohoBooksCreditCardAccount request. The App request itself looks correct, so this appears to be a backend/internal issue. A separate internal investigation is needed.
Recommended action: Roll forward instead of reverting. The page is behind the zohoBooks beta and doesn't exist in production. Reverting #105240 would remove the whole Zoho Books export settings UI. Keep DeployBlockerCash until an internal engineer confirms the backend cause and either demotes or fixes it.
On selection, ZohoBooksCompanyCardAccountPage.tsx:72-77 calls updateZohoBooksCreditCardAccount(policyID, item.value, creditCardAccountID). That action sends UpdateZohoBooksCreditCardAccount with {policyID, creditCardAccountID}.
The only source of this error is the failureData in ZohoBooks.ts:328-350. It restores the old value and sets errorFields.creditCardAccountID to common.genericErrorMessage. The page shows it through getLatestErrorField at line 97. So the error on reopening means the API call failed.
The picker lists data.bankAccounts (lines 46-52). A review-time fix changed it to that list. The parameter name matches the equivalent commands for other connections, which work.
Next step: check the request logs for the tester account (jsodijnosidjonj@gmail.com, 2026-11-02) for UpdateZohoBooksCreditCardAccount. If the backend expects IDs from a different list, a small follow-up App PR can fix the picker.
Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.
changed the title [-]Zoho Books - Error shows up after selecting company card account[/-][+][Due for payment 2026-11-14] Zoho Books - Error shows up after selecting company card account[/+]on Nov 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.33-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-14. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Nov 2, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/4dbd5658b18570a09e3b50b8c094512dafc557e9b2b3af82b53eec2144ffc2f0
melvin-bot commentedon Nov 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #102712
melvin-bot commentedon Nov 2, 2026
@Beamanator @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #102712
melvin-bot commentedon Nov 2, 2026
@dmkt9 you have been assigned to this deploy blocker because you authored the offending PR: #102712
melvin-bot commentedon Nov 2, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 2, 2026
Deploy Blocker Analysis
Causing PR: Add Zoho Books export settings UI, manual export, and Mark as exported (
Expensify/App#105240), merged 2026-11-02 and included in 9.5.28-4. Confidence: High that this PR exposed the bug.The auto-assigned PR, feat: Allow admins to merge approved reports, is unrelated. It only touches report-merge code and language files. Its author and reviewers can be unassigned, and the author and reviewers of #105240 should be assigned instead.
Root cause: The error is the App's failure fallback. It appears when the backend rejects the
UpdateZohoBooksCreditCardAccountrequest. The App request itself looks correct, so this appears to be a backend/internal issue. A separate internal investigation is needed.Recommended action: Roll forward instead of reverting. The page is behind the
zohoBooksbeta and doesn't exist in production. Reverting #105240 would remove the whole Zoho Books export settings UI. KeepDeployBlockerCashuntil an internal engineer confirms the backend cause and either demotes or fixes it.Investigation details
updateZohoBooksCreditCardAccount.ZohoBooksCompanyCardAccountPage.tsx:72-77callsupdateZohoBooksCreditCardAccount(policyID, item.value, creditCardAccountID). That action sendsUpdateZohoBooksCreditCardAccountwith{policyID, creditCardAccountID}.failureDatainZohoBooks.ts:328-350. It restores the old value and setserrorFields.creditCardAccountIDtocommon.genericErrorMessage. The page shows it throughgetLatestErrorFieldat line 97. So the error on reopening means the API call failed.data.bankAccounts(lines 46-52). A review-time fix changed it to that list. The parameter name matches the equivalent commands for other connections, which work.UpdateZohoBooksCreditCardAccount. If the backend expects IDs from a different list, a small follow-up App PR can fix the picker.Next Steps: Reply with
@MelvinBot <your feedback>to refine this analysis.9 remaining items
[-]Zoho Books - Error shows up after selecting company card account[/-][+][Due for payment 2026-11-14] Zoho Books - Error shows up after selecting company card account[/+]melvin-bot commentedon Nov 7, 2026
@situchan / @nkdengineer
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.33-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-14. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Nov 10, 2026
@situchan Still overdue 6 days?! Let's take care of this!