Skip to content

[Due for payment 2026-11-14] Zoho Books - Error shows up after selecting company card account #105676

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.28-4
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102712
Email or phone of affected tester (no customers): jsodijnosidjonj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable zohoBooks beta.
  • Connect to Zoho Books.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Connections.
  3. Click Zoho Book.
  4. Click Export.
  5. Click Company card account.
  6. Select any account.
  7. Click Company card account.

Expected Result:

No error will show up after selecting company card account.

Actual Result:

Error shows up after selecting company card account.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7302946_1793648214143.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Chandana Kiran
Bug ID: 7302946

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 2, 2026
  2. applause-bot commented on Nov 2, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/4dbd5658b18570a09e3b50b8c094512dafc557e9b2b3af82b53eec2144ffc2f0

  3. melvin-bot commented on Nov 2, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #102712

  4. melvin-bot commented on Nov 2, 2026

    @melvin-bot

    @Beamanator @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #102712

  5. melvin-bot commented on Nov 2, 2026

    @melvin-bot

    @dmkt9 you have been assigned to this deploy blocker because you authored the offending PR: #102712

  6. melvin-bot commented on Nov 2, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 2, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 2, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: Add Zoho Books export settings UI, manual export, and Mark as exported (Expensify/App#105240), merged 2026-11-02 and included in 9.5.28-4. Confidence: High that this PR exposed the bug.

    The auto-assigned PR, feat: Allow admins to merge approved reports, is unrelated. It only touches report-merge code and language files. Its author and reviewers can be unassigned, and the author and reviewers of #105240 should be assigned instead.

    Root cause: The error is the App's failure fallback. It appears when the backend rejects the UpdateZohoBooksCreditCardAccount request. The App request itself looks correct, so this appears to be a backend/internal issue. A separate internal investigation is needed.

    Recommended action: Roll forward instead of reverting. The page is behind the zohoBooks beta and doesn't exist in production. Reverting #105240 would remove the whole Zoho Books export settings UI. Keep DeployBlockerCash until an internal engineer confirms the backend cause and either demotes or fixes it.

    Investigation details
    • The Company card account page is new in Add Zoho Books export settings UI, manual export, and Mark as exported #105240. Before this release, no UI could call updateZohoBooksCreditCardAccount.
    • On selection, ZohoBooksCompanyCardAccountPage.tsx:72-77 calls updateZohoBooksCreditCardAccount(policyID, item.value, creditCardAccountID). That action sends UpdateZohoBooksCreditCardAccount with {policyID, creditCardAccountID}.
    • The only source of this error is the failureData in ZohoBooks.ts:328-350. It restores the old value and sets errorFields.creditCardAccountID to common.genericErrorMessage. The page shows it through getLatestErrorField at line 97. So the error on reopening means the API call failed.
    • The picker lists data.bankAccounts (lines 46-52). A review-time fix changed it to that list. The parameter name matches the equivalent commands for other connections, which work.
    • Next step: check the request logs for the tester account (jsodijnosidjonj@gmail.com, 2026-11-02) for UpdateZohoBooksCreditCardAccount. If the backend expects IDs from a different list, a small follow-up App PR can fix the picker.

    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.

  9. 9 remaining items

  10. removed their assignment
    on Nov 3, 2026
  11. changed the title [-]Zoho Books - Error shows up after selecting company card account[/-] [+][Due for payment 2026-11-14] Zoho Books - Error shows up after selecting company card account[/+] on Nov 7, 2026
  12. melvin-bot commented on Nov 7, 2026

    @melvin-bot

    @situchan / @nkdengineer

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.33-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-14. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  13. added
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    on Nov 8, 2026
  14. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    @situchan Still overdue 6 days?! Let's take care of this!

  15. removed their assignment
    on Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions