You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Error while changing Rate or Unit in Reimburse expenses page - reported by @aneequeahmad #10586
Can't change the Rate or Unit and see error An error occurred while updating the workspace. please try again later
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: 1.1.91-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
The Web-E PR for the refactor of Policy_CustomUnit_Update had breaking changes in lib/GetAPI.php to the data structure returned. For the time where Web-E changes are on prod but the corresponding App PR is on not on prod, this is the result. Fortunately the App PR is on staging and should make it to prod shortly, so I think we're fine to just live with this issue in the meantime.
Hmm I doubt if it was eligible for the reporting bonus. There was no PR made to fix this specifically (If I am correct?) and this issue was going to get solved as mentioned above. So there was no contribution as the issue was already going to get solved.
@Puneet-here, a bug which is on Production and has priority should be reported ASAP so it can be fixed on priority in a separate PR or existing PR. Does this makes sense ? Thanks
@Puneet-here We discussed internally, the issue was valid at the time of reporting and it was our fault we have messed up the order of deployments and deployed frontend before the backend was ready.
We want to make sure contributors keep testing and discovering bugs and incentivize contributors to do this. The bug was valid and it was not contirbutor's fault it was fixed by backend deploy.
I agree this is an edge case which is probably not clearly described in the contributing guidelines.
Activity
melvin-bot commentedon Aug 26, 2022
Triggered auto assignment to @madmax330 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mountiny commentedon Aug 27, 2022
Might be related to this change #10374 @amyevans
melvin-bot commentedon Aug 29, 2022
@madmax330 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
amyevans commentedon Aug 29, 2022
The Web-E PR for the refactor of Policy_CustomUnit_Update had breaking changes in lib/GetAPI.php to the data structure returned. For the time where Web-E changes are on prod but the corresponding App PR is on not on prod, this is the result. Fortunately the App PR is on staging and should make it to prod shortly, so I think we're fine to just live with this issue in the meantime.
aneequeahmad commentedon Aug 30, 2022
@madmax330 is there any bug reporting job created for this, i can see this is fixed in prod.
melvin-bot commentedon Aug 30, 2022
Triggered auto assignment to @bfitzexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.mountiny commentedon Aug 30, 2022
@bfitzexpensify Would you please create reporting bonus job on upwork for @aneequeahmad and pay them out? Thank you very much!
@aneequeahmad Thanks for eagle's eye!
bfitzexpensify commentedon Aug 30, 2022
Contract created, accepted, paid and ended
mountiny commentedon Aug 30, 2022
🚀
Puneet-here commentedon Aug 30, 2022
Hmm I doubt if it was eligible for the reporting bonus. There was no PR made to fix this specifically (If I am correct?) and this issue was going to get solved as mentioned above. So there was no contribution as the issue was already going to get solved.
aneequeahmad commentedon Aug 30, 2022
@Puneet-here, a bug which is on Production and has priority should be reported ASAP so it can be fixed on priority in a separate PR or existing PR. Does this makes sense ? Thanks
mountiny commentedon Aug 30, 2022
@Puneet-here We discussed internally, the issue was valid at the time of reporting and it was our fault we have messed up the order of deployments and deployed frontend before the backend was ready.
We want to make sure contributors keep testing and discovering bugs and incentivize contributors to do this. The bug was valid and it was not contirbutor's fault it was fixed by backend deploy.
I agree this is an edge case which is probably not clearly described in the contributing guidelines.