Skip to content

Error while changing Rate or Unit in Reimburse expenses page - reported by @aneequeahmad #10586

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on use icon to open setting page.
  2. Click on workspace > Reimburse expenses
  3. Change Track distance Rate or Unit

Expected Result:

Should be able to change the Rate or Unit

Actual Result:

Can't change the Rate or Unit and see error An error occurred while updating the workspace. please try again later

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.91-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-08-25.at.9.38.44.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661445864439179

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Aug 26, 2022

    @melvin-bot

    Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. mountiny commented on Aug 27, 2022

    @mountiny
    Contributor

    Might be related to this change #10374 @amyevans

  3. melvin-bot commented on Aug 29, 2022

    @melvin-bot

    @madmax330 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  4. amyevans commented on Aug 29, 2022

    @amyevans
    Contributor

    The Web-E PR for the refactor of Policy_CustomUnit_Update had breaking changes in lib/GetAPI.php to the data structure returned. For the time where Web-E changes are on prod but the corresponding App PR is on not on prod, this is the result. Fortunately the App PR is on staging and should make it to prod shortly, so I think we're fine to just live with this issue in the meantime.

  5. aneequeahmad commented on Aug 30, 2022

    @aneequeahmad
    Contributor

    @madmax330 is there any bug reporting job created for this, i can see this is fixed in prod.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 30, 2022
  7. melvin-bot commented on Aug 30, 2022

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  8. mountiny commented on Aug 30, 2022

    @mountiny
    Contributor

    @bfitzexpensify Would you please create reporting bonus job on upwork for @aneequeahmad and pay them out? Thank you very much!

    @aneequeahmad Thanks for eagle's eye!

  9. bfitzexpensify commented on Aug 30, 2022

    @bfitzexpensify
    Contributor

    Contract created, accepted, paid and ended

  10. mountiny commented on Aug 30, 2022

    @mountiny
    Contributor

    🚀

  11. Puneet-here commented on Aug 30, 2022

    @Puneet-here
    Contributor

    Hmm I doubt if it was eligible for the reporting bonus. There was no PR made to fix this specifically (If I am correct?) and this issue was going to get solved as mentioned above. So there was no contribution as the issue was already going to get solved.

  12. aneequeahmad commented on Aug 30, 2022

    @aneequeahmad
    Contributor

    @Puneet-here, a bug which is on Production and has priority should be reported ASAP so it can be fixed on priority in a separate PR or existing PR. Does this makes sense ? Thanks

  13. mountiny commented on Aug 30, 2022

    @mountiny
    Contributor

    @Puneet-here We discussed internally, the issue was valid at the time of reporting and it was our fault we have messed up the order of deployments and deployed frontend before the backend was ready.

    We want to make sure contributors keep testing and discovering bugs and incentivize contributors to do this. The bug was valid and it was not contirbutor's fault it was fixed by backend deploy.

    I agree this is an edge case which is probably not clearly described in the contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions