You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-20] Expense - Category field and Reimbursable toggle are not shown when destination is self DM #106696
Version Number: 9.5.37-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#105939 Email or phone of affected tester (no customers):sjoidnjsonjiojsdio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Have a workspace.
Go to staging.new.expensify.com
Open FAB > Create expense > Manual.
Click Report field.
Click None.
Expected Result:
Category field and Reimbursable toggle will be shown when destination is self DM.
Actual Result:
Category field and Reimbursable toggle are not shown when destination is self DM.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Selecting None moves the expense to self-DM, but the dropdown targets the nested Manual tab instead of the outer expense form. The form therefore retains its previous expense type instead of becoming TRACK, causing both Category and Reimbursable to disappear.
The PR shipped in 9.5.37-0 and appears in the staging deploy checklist, matching the reported version. Attribution is supported by its actual code changes, not merely the automatic assignment.
What changes do you think we should make in order to solve the problem?
Prefer a targeted roll-forward: pass an explicit expense-type change callback from the screen owning the form route, rather than discovering that route inside the dropdown.
Add a regression test using the real nested Manual-tab structure. After selecting None, verify the outer route becomes TRACK, both fields appear under eligible workspace settings, and the expense saves to personal space.
Confidence: Strong code evidence, independently reviewed. Browser reproduction and the proposed fix remain unverified; no code changes were made.
What alternative solutions did you explore? (Optional)
Reverting the originating PR is a fallback if a targeted fix cannot be validated promptly. Revert compatibility has not been tested. Missing categories and locked reimbursement settings can legitimately hide fields, but do not explain the route mismatch.
Next Steps for Contributor+ team: To accept:@MelvinBot implement this proposal to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - Category field and Reimbursable toggle are not shown when destination is self DM[/-][+][Due for payment 2026-11-20] Expense - Category field and Reimbursable toggle are not shown when destination is self DM[/+]on Nov 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-20. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Nov 12, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/41d4e30e171b5a589875886d22f07485b59dea7f2ef471db557ed1c4ce7d4932
melvin-bot commentedon Nov 12, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #105939
melvin-bot commentedon Nov 12, 2026
@puneetlath @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #105939
melvin-bot commentedon Nov 12, 2026
@DylanDylann you have been assigned to this deploy blocker because you authored the offending PR: #105939
melvin-bot commentedon Nov 12, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 12, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 12, 2026
Proposal
What is the root cause of that problem?
The Report dropdown updates the wrong navigation route. The regression was introduced by Refactor ReportField logic to simplify report editability condition.
Selecting None moves the expense to self-DM, but the dropdown targets the nested Manual tab instead of the outer expense form. The form therefore retains its previous expense type instead of becoming
TRACK, causing both Category and Reimbursable to disappear.Supporting code and release evidence
useRoute().TRACK.The PR shipped in 9.5.37-0 and appears in the staging deploy checklist, matching the reported version. Attribution is supported by its actual code changes, not merely the automatic assignment.
What changes do you think we should make in order to solve the problem?
Prefer a targeted roll-forward: pass an explicit expense-type change callback from the screen owning the form route, rather than discovering that route inside the dropdown.
Add a regression test using the real nested Manual-tab structure. After selecting None, verify the outer route becomes
TRACK, both fields appear under eligible workspace settings, and the expense saves to personal space.Confidence: Strong code evidence, independently reviewed. Browser reproduction and the proposed fix remain unverified; no code changes were made.
What alternative solutions did you explore? (Optional)
Reverting the originating PR is a fallback if a targeted fix cannot be validated promptly. Revert compatibility has not been tested. Missing categories and locked reimbursement settings can legitimately hide fields, but do not explain the route mismatch.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement this proposalto create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
[-]Expense - Category field and Reimbursable toggle are not shown when destination is self DM[/-][+][Due for payment 2026-11-20] Expense - Category field and Reimbursable toggle are not shown when destination is self DM[/+]melvin-bot commentedon Nov 13, 2026
@ikevin127 / @DylanDylann
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-20. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]