You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Per diem - Per diem expense amount can be changed by expense rule #107137
Version Number: 9.5.40-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#105893 Email or phone of affected tester (no customers):djdoifjndojfodj@gmail.co Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable Rules and Per diem.
Workspace has per diem rates.
Go to staging.new.expensify.com
Go to workspace chat.
Create a per diem expense with Advertising category.
Go to workspace settings > Rules.
Click Add rule > Apply expense defaults.
Select Advertising category in "If any expense matches".
Enter any amount in "Then apply the following defaults".
Toggle on "Apply to existing unsubmitted expenses".
Click Save rule.
Open the per diem expense in Step 3.
Expected Result:
Per diem expense amount cannot be manipulated by expense rule because we cannot manually edit per diem expense amount.
Actual Result:
Per diem expense amount can be changed by expense rule.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Saving sends the rule and shouldUpdateMatchingTransactions to SetRule. Its optimistic updates modify rules, not transaction amounts, so the reported mutation is not explained by local save-handler updates: Rules.ts:196–247.
Together, this supports a missing equivalent restriction during rule execution—not a manual amount-editor regression.
Recommended disposition
Keep the deploy blocker and escalate to an internal engineer with backend access. The likely corrective change belongs outside App; an App-only fix is not established.
Do not blindly revert the reland. Its description documents that previously saved rules continued running after the earlier revert, and the reland also contains crash protection for rule-modified expenses. Removing the UI alone therefore is not proven to stop the behavior.
Backend investigation should verify per-diem amount protection across retroactive and future rule execution, while preserving other valid rule actions.
Verification limits: Static code, PR history, and release-checklist investigation only. No browser reproduction, backend implementation inspection, or production-log confirmation was performed. Confidence is high in the feature-enabling PR attribution, but medium in the backend root-cause hypothesis.
Activity
applause-bot commentedon Nov 17, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/4aa4235c94b2f7eac6b5202ccc84dd16aed3eb7751e2b381ac0b1d1ea5bbad46
expensify-chore-bot commentedon Nov 17, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #105893
expensify-chore-bot commentedon Nov 17, 2026
@JS00001 @luacmartins @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #105893
expensify-chore-bot commentedon Nov 17, 2026
@Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #105893
expensify-chore-bot commentedon Nov 17, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 17, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 17, 2026
Deploy blocker investigation
Finding: Reland expense defaults for tags and amounts enabled the reported behavior. It is included in the 9.5.40-0 staging release. The likely enforcement defect is backend-side, but that root cause remains unverified.
Evidence
ExpenseDefaultRuleUtils.ts:273–296.Setactions:ExpenseDefaultRuleUtils.ts:329–354.shouldUpdateMatchingTransactionstoSetRule. Its optimistic updates modify rules, not transaction amounts, so the reported mutation is not explained by local save-handler updates:Rules.ts:196–247.ReportUtils.ts:6398–6403.Together, this supports a missing equivalent restriction during rule execution—not a manual amount-editor regression.
Recommended disposition
Keep the deploy blocker and escalate to an internal engineer with backend access. The likely corrective change belongs outside App; an App-only fix is not established.
Do not blindly revert the reland. Its description documents that previously saved rules continued running after the earlier revert, and the reland also contains crash protection for rule-modified expenses. Removing the UI alone therefore is not proven to stop the behavior.
Backend investigation should verify per-diem amount protection across retroactive and future rule execution, while preserving other valid rule actions.
Verification limits: Static code, PR history, and release-checklist investigation only. No browser reproduction, backend implementation inspection, or production-log confirmation was performed. Confidence is high in the feature-enabling PR attribution, but medium in the backend root-cause hypothesis.
view run
JS00001 commentedon Nov 17, 2026
Lets not block on this, I'll fix it on the BE
JS00001 commentedon Nov 17, 2026
pr open