Skip to content

Per diem - Per diem expense amount can be changed by expense rule #107137

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.40-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #105893
Email or phone of affected tester (no customers): djdoifjndojfodj@gmail.co
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Enable Rules and Per diem.
  • Workspace has per diem rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a per diem expense with Advertising category.
  4. Go to workspace settings > Rules.
  5. Click Add rule > Apply expense defaults.
  6. Select Advertising category in "If any expense matches".
  7. Enter any amount in "Then apply the following defaults".
  8. Toggle on "Apply to existing unsubmitted expenses".
  9. Click Save rule.
  10. Open the per diem expense in Step 3.

Expected Result:

Per diem expense amount cannot be manipulated by expense rule because we cannot manually edit per diem expense amount.

Actual Result:

Per diem expense amount can be changed by expense rule.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7316867_1794932374787.12.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7316867

Issue OwnerCurrent Issue Owner: @JS00001

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 17, 2026
  2. applause-bot commented on Nov 17, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/4aa4235c94b2f7eac6b5202ccc84dd16aed3eb7751e2b381ac0b1d1ea5bbad46

  3. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #105893

  4. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    @JS00001 @luacmartins @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #105893

  5. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    @Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #105893

  6. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 17, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 17, 2026

    @MelvinBot
    Contributor

    Deploy blocker investigation

    Finding: Reland expense defaults for tags and amounts enabled the reported behavior. It is included in the 9.5.40-0 staging release. The likely enforcement defect is backend-side, but that root cause remains unverified.

    Evidence

    Together, this supports a missing equivalent restriction during rule execution—not a manual amount-editor regression.

    Recommended disposition

    Keep the deploy blocker and escalate to an internal engineer with backend access. The likely corrective change belongs outside App; an App-only fix is not established.

    Do not blindly revert the reland. Its description documents that previously saved rules continued running after the earlier revert, and the reland also contains crash protection for rule-modified expenses. Removing the UI alone therefore is not proven to stop the behavior.

    Backend investigation should verify per-diem amount protection across retroactive and future rule execution, while preserving other valid rule actions.

    Verification limits: Static code, PR history, and release-checklist investigation only. No browser reproduction, backend implementation inspection, or production-log confirmation was performed. Confidence is high in the feature-enabling PR attribution, but medium in the backend root-cause hypothesis.


    view run

  9. JS00001 commented on Nov 17, 2026

    @JS00001
    Contributor

    Lets not block on this, I'll fix it on the BE

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 17, 2026
  11. JS00001 commented on Nov 17, 2026

    @JS00001
    Contributor

    pr open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions