Skip to content

Has filter is not applied when enter group-by:violation from search #107476

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.43-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #107141
Email or phone of affected tester (no customers): gocemate+mizar333@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: windows 11/chrome
App Component: Other

Action Performed:

Precondition: Has some expense with violation and it's submitted/approved

Steps:

  1. Enable Rule feature in a workspace
  2. Open the search router
  3. Enter group-by:violation
  4. Select this option
  5. Verify you navigate to Spend tab and expenses are displayed

Expected Result:

Has filter is auto-applied

Actual Result:

Has filter is not auto-applied

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7319402_1795122958032.Recording__142.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Chandana Kiran
Bug ID: 7319402

Activity

  1. applause-bot commented on Nov 19, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/21f0a9b693b39be065f584f1d6195b4f1b6a211f43f1f81d55debb0e97282df2

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 19, 2026
  3. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #107141

  4. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    @neil-marcellini you have been assigned to this deploy blocker because you reviewed the offending PR: #107141

  5. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    @nkdengineer you have been assigned to this deploy blocker because you authored the offending PR: #107141

  6. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 19, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. neil-marcellini commented on Nov 19, 2026

    @neil-marcellini
    Contributor

    I don't think this needs to block release. It works fine and I don't think most people will do this, it's just a little inconsistent.

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 19, 2026
  10. neil-marcellini commented on Nov 19, 2026

    @neil-marcellini
    Contributor

    I'll have AI put up a fix

  11. MelvinBot commented on Nov 19, 2026

    @MelvinBot
    Contributor

    Proposal

    Recommendation: keep this non-blocking. Expenses still display, and the reviewer confirmed this is an inconsistency. The issue already has no deploy-blocker label.

    What is the root cause of that problem?

    Add group-by:violation introduced different behavior between the Display menu and search-router entry: only the Display-menu path automatically adds the violation Has filters.

    Supporting evidence

    This explains the missing visible filter without requiring a backend failure. Confidence: high for the frontend cause. Browser reproduction and backend result equivalence were not independently verified.

    What changes do you think we should make in order to solve the problem?

    Apply the same default submitted/approved violation filters when selecting violation grouping through the search router. Preserve explicitly selected stages and unrelated filters.

    Add regression coverage for router entry, Display-menu parity, and explicit-stage preservation.

    What alternative solutions did you explore? (Optional)

    Changing the generic parser could affect intentionally supported raw queries; prefer the narrower router behavior change. Reverting the feature appears disproportionate to the reported inconsistency.


    Next Steps for Contributor+ team:
    To accept: Request implementation of this proposal.
    To refine: Reply with feedback.
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  12. nkdengineer commented on Nov 20, 2026

    @nkdengineer
    Contributor

    @neil-marcellini it's a known issue as I asked in the previous PR here #107141 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions