Skip to content

Invoices-message is "bank account" on payment to no BA submitter #107513

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: v9.5.48-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #105968
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 Chrome
App Component: Money Requests

Action Performed:

Preconditions:

  • Account B create a workspace (USD), enable Invoice, invite A to workspace so it is easier to find invoice
  • Account A add a make payment bank account (1111)
  • Account B does not have any bank account
  1. Open https://staging.new.expensify.com/
  2. Account B send an invoice to Account A
  3. Account A go to OD and pay invoice with business bank account
  4. In ND, go to the invoice detail page
  5. Scroll down to payment system message

Expected Result:

Verify that the message still says "personal bank account".

Actual Result:

the message says "bank account" only

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7319684_1795149402589.add_a_bank_account.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7319684

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 20, 2026
  2. applause-bot commented on Nov 20, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/755c0add6be0489db9f447ea570abf5c7985d7e72e48de85a5edbdd4ff2df15c

  3. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #105968

  4. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @s77rt @roryabraham you have been assigned to this deploy blocker because you reviewed the offending PR: #105968

  5. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @cead22 you have been assigned to this deploy blocker because you authored the offending PR: #105968

  6. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 20, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 20, 2026

    @MelvinBot
    Contributor

    Investigation result: likely QA expectation mismatch

    The wording change comes from Show payment details and stored names on invoices linked to bills, but appears intentional—not a confirmed regression.

    The PR explicitly states that invoice messages should no longer say “personal.” Its QA steps 19–20 retain “personal bank account” for expense reports, whereas this issue tests an invoice.

    Code evidence
    • ReportUtils.ts:5061–5073 selects “bank account” for invoices and preserves “personal bank account” for expense reports/IOUs. It does not require a bill link.
    • en.ts:1858–1859 contains both distinct translations; the original wording was not globally replaced.
    • ReportUtilsTest.ts:4499–4543 explicitly expects this distinction, including an invoice without bill-link metadata.

    The message describes the recipient’s missing deposit account—not the payer’s selected payment account.

    Recommended resolution: Have cead22, s77rt, or roryabraham confirm whether standalone invoices should be an exception. If not, correct this test’s expected result and remove the blocker through normal triage. A full PR revert is not justified by this report alone.

    Confidence: High on attribution; intended standalone-invoice requirements still need confirmation. No independent browser reproduction or tests were run, and no code or labels were changed.


    view run

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions