Skip to content

Android - App crashed after tap the back button in offline mode #10757

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the test app and log in with any account
  2. Enable offline mode
  3. Open any chat
  4. Tap the Back button at the left top

Expected Result:

The user is returned to the main screen (LHN) after tapping the Back button at the chat view

Actual Result:

App crashed after tapping the back button at chat view in offline mode

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.96.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5713428_Screen-20220901-200553.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Sep 1, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 1, 2022

    @melvin-bot

    Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. arosiclair commented on Sep 1, 2022

    @arosiclair
    Contributor

    Repro'd this in dev on main with the Android emulator.

    Screen Shot 2022-09-01 at 3 49 09 PM

  4. arosiclair commented on Sep 1, 2022

    @arosiclair
    Contributor

    @mateusbra @AndrewGable @parasharrajat
    Do any of you guys think this has anything to do with the react-native-svg upgrade here: #10334? Other than the stack trace pictured above I can't find any useful log output.

  5. luacmartins commented on Sep 2, 2022

    @luacmartins
    Contributor

    I see this immediately before the crash:

    09-02 09:43:40.127   497  6106 I system_server: oneway function results will be dropped but finished with status OK and parcel size 4
    09-02 09:43:40.994  6696  6810 D ReactNativeJS: [info] [Onyx] set() called for key: reportDraftComment_7 - ""
    09-02 09:43:41.418  1220  1246 I PeriodicStatsRunner: PeriodicStatsRunner.call():180 call()
    09-02 09:43:41.418  1220  1246 I PeriodicStatsRunner: PeriodicStatsRunner.call():184 No submit PeriodicStats since input started.
    09-02 09:43:42.982   497  6106 I system_server: oneway function results will be dropped but finished with status OK and parcel size 4
    09-02 09:43:42.982   497  6106 I system_server: oneway function results will be dropped but finished with status OK and parcel size 4
    09-02 09:43:43.116   497  3185 I system_server: oneway function results will be dropped but finished with status OK and parcel size 4
    09-02 09:43:43.549  6696  6810 D ReactNativeJS: [info] Navigating to route - {"path":"/r/7"}
    09-02 09:43:43.573  6696  6810 D ReactNativeJS: [info] [Onyx] set() called for key: session properties: loading,shouldShowComposeInput,authToken,accountID,email,encryptedAuthToken - ""
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: Exception in native call
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.String.trim()' on a null object reference
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.horcrux.svg.SVGLength.<init>(SVGLength.java:37)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.horcrux.svg.SVGLength.from(SVGLength.java:107)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.horcrux.svg.LinearGradientView.setX1(LinearGradientView.java:50)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.horcrux.svg.RenderableViewManager$LinearGradientManager.setX1(RenderableViewManager.java:1806)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.horcrux.svg.RenderableViewManager$LinearGradientManager.setX1(RenderableViewManager.java:1770)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.viewmanagers.RNSVGLinearGradientManagerDelegate.setProperty(RNSVGLinearGradientManagerDelegate.java:59)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps(ViewManagerPropertyUpdater.java:46)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.ViewManager.updateProperties(ViewManager.java:46)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties(NativeViewHierarchyManager.java:142)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIImplementation.synchronouslyUpdateViewOnUIThread(UIImplementation.java:305)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIManagerModule.synchronouslyUpdateViewOnUIThread(UIManagerModule.java:400)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.animated.PropsAnimatedNode.restoreDefaultValues(PropsAnimatedNode.java:90)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.animated.NativeAnimatedNodesManager.restoreDefaultValues(NativeAnimatedNodesManager.java:470)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.animated.NativeAnimatedModule$20.execute(NativeAnimatedModule.java:866)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.animated.NativeAnimatedModule$ConcurrentOperationQueue.executeBatch(NativeAnimatedModule.java:147)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.animated.NativeAnimatedModule$2.execute(NativeAnimatedModule.java:324)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIViewOperationQueue$UIBlockOperation.execute(UIViewOperationQueue.java:579)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIViewOperationQueue$1.run(UIViewOperationQueue.java:915)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches(UIViewOperationQueue.java:1026)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIViewOperationQueue.access$2600(UIViewOperationQueue.java:47)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:1086)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.uimanager.GuardedFrameCallback.doFrame(GuardedFrameCallback.java:29)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:175)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(ChoreographerCompat.java:85)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:970)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at android.view.Choreographer.doCallbacks(Choreographer.java:796)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at android.view.Choreographer.doFrame(Choreographer.java:727)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:957)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at android.os.Handler.handleCallback(Handler.java:938)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at android.os.Handler.dispatchMessage(Handler.java:99)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at android.os.Looper.loop(Looper.java:223)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at android.app.ActivityThread.main(ActivityThread.java:7656)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at java.lang.reflect.Method.invoke(Native Method)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
    09-02 09:43:44.426  6696  6696 E unknown:ReactNative: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
    
  6. AndrewGable commented on Sep 2, 2022

    @AndrewGable
    Contributor

    at com.horcrux.svg.SVGLength.<init>(SVGLength.java:37)

    Looks like SVG- Good find!

  7. luacmartins commented on Sep 2, 2022

    @luacmartins
    Contributor

    Yea, I can confirm that reverting the react-native-svg upgrade resolves the issue

  8. luacmartins commented on Sep 2, 2022

    @luacmartins
    Contributor

    @AndrewGable should we revert this upgrade for now?

  9. AndrewGable commented on Sep 2, 2022

    @AndrewGable
    Contributor

    Yes please!

  10. self-assigned this
    on Sep 2, 2022
  11. luacmartins commented on Sep 2, 2022

    @luacmartins
    Contributor

    Revert merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions