You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android - Chat - Deleted message is displayed for brief moment after back online #10799
Hey @tgolen, I think we can quickly fix this by using the reportAction's pendingAction field inside the reportActionItem or reportActionItemFragment or maybe OfflineWithFeedback.
We can check if the reportAction is a comment and something like pendingAction === styles.offlineFeedback.deleted && !props.network.isOffline and render the text as an empty string in that case!
I can take this if that's ok or it can be an External issue too!
Activity
melvin-bot commentedon Sep 2, 2022
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.PauloGasparSv commentedon Sep 2, 2022
Hey @tgolen, I think we can quickly fix this by using the reportAction's
pendingActionfield inside the reportActionItem or reportActionItemFragment or maybe OfflineWithFeedback.We can check if the reportAction is a comment and something like
pendingAction === styles.offlineFeedback.deleted && !props.network.isOfflineand render the text as an empty string in that case!I can take this if that's ok or it can be an External issue too!
tgolen commentedon Sep 5, 2022
@PauloGasparSv Feel free to gab and work on it
PauloGasparSv commentedon Sep 8, 2022
Same issue from here: #10753
melvin-bot commentedon Sep 22, 2022
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.