Skip to content

Android - Chat - Deleted message is displayed for brief moment after back online #10799

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #10780

Action Performed:

  1. Launch the app
  2. Log in with expensifail account
  3. Select any user
  4. Send message
  5. .Go offline and delete that message
  6. The message should not disappear but instead appear with a strike-through
  7. Go online, the message should disappear

Expected Result:

Deleted message should disappear after back online

Actual Result:

Deleted message is displayed for brief moment after back online

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.96.5

Reproducible in staging?: Yes

Reproducible in production?: No -new feature

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220902-093647_New.Expensify.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Sep 2, 2022

    @melvin-bot

    Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. PauloGasparSv commented on Sep 2, 2022

    @PauloGasparSv
    Contributor

    Hey @tgolen, I think we can quickly fix this by using the reportAction's pendingAction field inside the reportActionItem or reportActionItemFragment or maybe OfflineWithFeedback.

    We can check if the reportAction is a comment and something like pendingAction === styles.offlineFeedback.deleted && !props.network.isOffline and render the text as an empty string in that case!

    I can take this if that's ok or it can be an External issue too!

  3. removed their assignment
    on Sep 5, 2022
  4. tgolen commented on Sep 5, 2022

    @tgolen
    Contributor

    @PauloGasparSv Feel free to gab and work on it

  5. added and removed on Sep 5, 2022
  6. self-assigned this
    on Sep 5, 2022
  7. PauloGasparSv commented on Sep 8, 2022

    @PauloGasparSv
    Contributor

    Same issue from here: #10753

  8. melvin-bot commented on Sep 22, 2022

    @melvin-bot

    ⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions