You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reimburse expenses - The milage rate automatically changes to the initial value #10821
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Ah poop, the mistake is here where we forgot to think about migration to support older data. cc @amyevans.
We could push up a fix to support the older data but I think maybe it's better to push forward and CP these two, #10692, and #10557 (for this one, the related web PRs are already live and the PR is in final review so I think it should be simple enough to CP). cc @neil-marcellini
We'll need to cherry pick #10557, but it needs to be updated with main first and then I can review again before we ship it. Does that plan sound okay? Going to comment in the PR
wouldn't your PR include a bunch of unwanted commits when we CP?
Hmm I don't think so, I'm not entirely sure how the cherry pick script works though to be honest. But I would expect that it just cherry picks each individual commit in the PR.
But yes by that logic, being up to date with main doesn't actually matter
The original blocker is resolved. We might want to make further improvements as the extra decimal places are being added quite quickly, but I'm marking this off:
Activity
OSBotify commentedon Sep 5, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 5, 2022
Triggered auto assignment to @chiragsalian (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.chiragsalian commentedon Sep 5, 2022
Ah poop, the mistake is here where we forgot to think about migration to support older data. cc @amyevans.
We could push up a fix to support the older data but I think maybe it's better to push forward and CP these two,
#10692, and
#10557 (for this one, the related web PRs are already live and the PR is in final review so I think it should be simple enough to CP). cc @neil-marcellini
amyevans commentedon Sep 6, 2022
cc @jasperhuangg as well since looks like there's more conflicts when trying to merge
maininto your App branch in #10557luacmartins commentedon Sep 6, 2022
@amyevans do you wanna take this blocker over from Chirag, since you seem to know how to fix it?
Julesssss commentedon Sep 6, 2022
Bumping @amyevans. But I can also take over this as I'll be working on deployers until we release today.
amyevans commentedon Sep 6, 2022
We'll need to cherry pick #10557, but it needs to be updated with
mainfirst and then I can review again before we ship it. Does that plan sound okay? Going to comment in the PRJulesssss commentedon Sep 6, 2022
Just wanted to check that this is necessary. As if we merge
mainwouldn't your PR include a bunch of unwanted commits when we CP?amyevans commentedon Sep 6, 2022
Hmm I don't think so, I'm not entirely sure how the cherry pick script works though to be honest. But I would expect that it just cherry picks each individual commit in the PR.
But yes by that logic, being up to date with
maindoesn't actually matterJulesssss commentedon Sep 6, 2022
We'll get back to this tomorrow once the provisioning build has been confirmed to be working.
Julesssss commentedon Sep 7, 2022
Now that the CP workflow is fixed, I retried the CP and it worked 🎉
Julesssss commentedon Sep 7, 2022
Testing should begin shortly after the build is made available for Applause.
Julesssss commentedon Sep 7, 2022
The original blocker is resolved. We might want to make further improvements as the extra decimal places are being added quite quickly, but I'm marking this off:
Milage.mov