Skip to content

Reimburse expenses - The milage rate automatically changes to the initial value #10821

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #10692

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
    and login
  2. Create a New Workspace
  3. Go to Settings -> Workspace -> Reimburse expenses
  4. Edit the milage rate

Expected Result:

The mileage rate should change after the changes

Actual Result:

The milage rate automatically changes to the initial value

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.97.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5718603_Recording__1786.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Sep 5, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 5, 2022

    @melvin-bot

    Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. chiragsalian commented on Sep 5, 2022

    @chiragsalian
    Contributor

    Ah poop, the mistake is here where we forgot to think about migration to support older data. cc @amyevans.

    We could push up a fix to support the older data but I think maybe it's better to push forward and CP these two,
    #10692, and
    #10557 (for this one, the related web PRs are already live and the PR is in final review so I think it should be simple enough to CP). cc @neil-marcellini

  4. amyevans commented on Sep 6, 2022

    @amyevans
    Contributor

    cc @jasperhuangg as well since looks like there's more conflicts when trying to merge main into your App branch in #10557

  5. luacmartins commented on Sep 6, 2022

    @luacmartins
    Contributor

    @amyevans do you wanna take this blocker over from Chirag, since you seem to know how to fix it?

  6. Julesssss commented on Sep 6, 2022

    @Julesssss
    Contributor

    Bumping @amyevans. But I can also take over this as I'll be working on deployers until we release today.

  7. amyevans commented on Sep 6, 2022

    @amyevans
    Contributor

    We'll need to cherry pick #10557, but it needs to be updated with main first and then I can review again before we ship it. Does that plan sound okay? Going to comment in the PR

  8. Julesssss commented on Sep 6, 2022

    @Julesssss
    Contributor

    but it needs to be updated with main first

    Just wanted to check that this is necessary. As if we mergemain wouldn't your PR include a bunch of unwanted commits when we CP?

  9. amyevans commented on Sep 6, 2022

    @amyevans
    Contributor

    wouldn't your PR include a bunch of unwanted commits when we CP?

    Hmm I don't think so, I'm not entirely sure how the cherry pick script works though to be honest. But I would expect that it just cherry picks each individual commit in the PR.

    But yes by that logic, being up to date with main doesn't actually matter

  10. Julesssss commented on Sep 6, 2022

    @Julesssss
    Contributor

    We'll get back to this tomorrow once the provisioning build has been confirmed to be working.

  11. self-assigned this
    on Sep 7, 2022
  12. Julesssss commented on Sep 7, 2022

    @Julesssss
    Contributor

    Now that the CP workflow is fixed, I retried the CP and it worked 🎉

  13. Julesssss commented on Sep 7, 2022

    @Julesssss
    Contributor

    Testing should begin shortly after the build is made available for Applause.

  14. Julesssss commented on Sep 7, 2022

    @Julesssss
    Contributor

    The original blocker is resolved. We might want to make further improvements as the extra decimal places are being added quite quickly, but I'm marking this off:

    Milage.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions