Skip to content

Android - Attachment - PDF password form displayed lower than expected #10822

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #9141

Action Performed:

  1. Launch the app
  2. Log in with expensifail account
  3. Select any user
  4. Click the plus button to the left of the message input, and select "Add attachment"
  5. Select a password-protected PDF
  6. Verify that the password form appears
  7. Tap on Enter the password

Expected Result:

PDF password form displayed higher than actual

Actual Result:

PDF password form displayed lower than expected

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.97.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Sep 5, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 5, 2022

    @melvin-bot

    Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. varshamb commented on Sep 5, 2022

    @varshamb
    Contributor

    Proposal

    Use justifyContentStart

    contentContainerStyle={[styles.ph5, styles.flex1, styles.justifyContentCenter]}

  4. parasharrajat commented on Sep 5, 2022

    @parasharrajat
    Member

    This is by design cc: @shawnborton . We coded it that way. The form will be vertically centered on all platforms.

  5. shawnborton commented on Sep 5, 2022

    @shawnborton
    Contributor

    Correct. I also don't see a link to Slack conversation @kbecciv - can we make sure there is a Slack conversation before reporting these bugs? Thanks!

  6. kbecciv commented on Sep 12, 2022

    @kbecciv
    Author

    @shawnborton This is issue reported by Applause - Interna Team, so we don't provide the link for Slack conversation on those bugs.

  7. shawnborton commented on Sep 13, 2022

    @shawnborton
    Contributor

    Got it. We might want to change that in the future, well keep you posted. In the meantime, let's keep this closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions