Skip to content

Android - Workspace settings - Input fields are not grayed out when made changes offline #10825

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the App and login
  2. Click on Create a New Workspace
  3. Navigate to the General settings page
  4. Disable the internet connection
  5. Change the workspace currency and name
  6. Save the changes

Expected Result:

Input fields should be grayed out when saved changes offline

Actual Result:

Input fields are not grayed out when made changes offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.97.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5718910_video_2022-09-05_21-54-02.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Sep 5, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 5, 2022

    @melvin-bot

    Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. chiragsalian commented on Sep 5, 2022

    @chiragsalian
    Contributor

    Not really a blocker. I think this is fine since we'll now allow updating the workspace name optimistically even when offline so this seems normal to me. cc @neil-marcellini as well since you made this change.

    I tested on staging and it looks good to me as is.

  4. self-assigned this
    on Sep 6, 2022
  5. luacmartins commented on Sep 6, 2022

    @luacmartins
    Contributor

    I agree that this is not a blocker since it's just UI and doesn't prevent the user from using the App. I was also not able to reproduce this locally. Removing the blocker label.

  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Sep 6, 2022
  7. neil-marcellini commented on Sep 6, 2022

    @neil-marcellini
    Contributor

    Was cellular data turned off when "going offline"? The offline indicator did not appear. @kbecciv can you please try again and make sure that cellular data is off?

  8. kbecciv commented on Sep 6, 2022

    @kbecciv
    Author

    @neil-marcellini Checking with team, will update you shortly.

  9. kbecciv commented on Sep 6, 2022

    @kbecciv
    Author

    @luacmartins @neil-marcellini Not able reproduced with build 1.1.97.2

    Screen_Recording_20220906-084501_New.Expensify.mp4
  10. luacmartins commented on Sep 6, 2022

    @luacmartins
    Contributor

    Cool, thanks for confirming! gonna close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions