You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] User can't download the production app from playstore #11132
@mallenexpensify@mallenexpensify I was checking with the team on the same. There is a tricky way to download PROD build on Android with the same device as you have staging. Currently we all see STG
Since all our testers are already getting BETA (STG) builds, not sure this result is accurate.
Is there any chance you can ask someone in Expensify internally who DOES NOT have staging build to download PROD build?
@Puneet-here paid $250 for reporting @AndrewGable we want to update regression test steps for this, right? If so I'll leave open and tackle the last piece.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Verify the app does not way staging on the login page.
I put 'does not' cuz that should be the expected behavior and staging should be the edge or test case, right? I'm still new to these steps, I'm assuming we're always creating them for the production version of the app, let me know if that's not correct
Are these needed before we close this out @AndrewGable ?
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
I do not think this is required, the code relied on an external site that we do not have control over, so it actually started to fail without a code change on our side.
Thanks @AndrewGable. @thesahindia are you able to complete the above steps? I think the process we're working towards is to have C+ complete all items they can. For any that are related to backend changes, the C+ would comment on the issue, tag the assigned internal engineer, and provide reasoning why they're unable to complete the steps.
I don't have much knowledge on this issue since I didn't do anything here. Just a heads-up that @srikarparsimentioned that it was a regression from #9960
I think as Andrew mentioned, @mallenexpensify we should be good to close this one out, seems like the Google API response has changed and that introduced this problem. We could not do much else other than have a regression test which will check for this.
Activity
mallenexpensify commentedon Oct 12, 2022
@mvtglobally are you able to reproduce?
melvin-bot commentedon Oct 17, 2022
@mvtglobally Huh... This is 4 days overdue. Who can take care of this?
mallenexpensify commentedon Oct 17, 2022
@mvtglobally can you see if you're able to reproduce?
melvin-bot commentedon Oct 19, 2022
@mvtglobally 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
mvtglobally commentedon Oct 19, 2022
@mallenexpensify @mallenexpensify I was checking with the team on the same. There is a tricky way to download PROD build on Android with the same device as you have staging. Currently we all see STG
Since all our testers are already getting BETA (STG) builds, not sure this result is accurate.
Is there any chance you can ask someone in Expensify internally who DOES NOT have staging build to download PROD build?
video_2022-10-18_01-46-04.mp4
mallenexpensify commentedon Oct 20, 2022
Asking internally https://expensify.slack.com/archives/C01SKUP7QR0/p1666291488048139
mallenexpensify commentedon Oct 20, 2022
Gonna close cuz @alex-mechler was able to help test and it looks like its not repro

122 remaining items
mountiny commentedon Dec 29, 2022
Asked in the PR if we had closed to loop on the ProductionQA actually.
AndrewGable commentedon Dec 30, 2022
@mallenexpensify Sounds good 👍 - Testing passed
mallenexpensify commentedon Dec 30, 2022
@Puneet-here can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~019d52081ca835b9ef
Puneet-here commentedon Dec 30, 2022
Accepted @mallenexpensify
mallenexpensify commentedon Jan 2, 2023
@Puneet-here paid $250 for reporting
@AndrewGable we want to update regression test steps for this, right? If so I'll leave open and tackle the last piece.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
AndrewGable commentedon Jan 2, 2023
Yep - We can add a regression test for this.
mallenexpensify commentedon Jan 3, 2023
Posted regression test steps in #bug-zero
https://expensify.slack.com/archives/C01SKUP7QR0/p1672711388472929
mallenexpensify commentedon Jan 3, 2023
Likely running with this for regression test steps, will create the GH for tomorrow
Under "Account Setting" in TR add a new test titled About - App download links
Add steps
I put 'does not' cuz that should be the expected behavior and staging should be the edge or test case, right? I'm still new to these steps, I'm assuming we're always creating them for the production version of the app, let me know if that's not correct
mallenexpensify commentedon Jan 6, 2023
Issue created to update test steps https://github.com/Expensify/Expensify/issues/253420
Are these needed before we close this out @AndrewGable ?
AndrewGable commentedon Jan 6, 2023
I do not think this is required, the code relied on an external site that we do not have control over, so it actually started to fail without a code change on our side.
mallenexpensify commentedon Jan 9, 2023
Thanks @AndrewGable.
@thesahindia are you able to complete the above steps? I think the process we're working towards is to have C+ complete all items they can. For any that are related to backend changes, the C+ would comment on the issue, tag the assigned internal engineer, and provide reasoning why they're unable to complete the steps.
thesahindia commentedon Jan 11, 2023
I don't have much knowledge on this issue since I didn't do anything here. Just a heads-up that @srikarparsi mentioned that it was a regression from #9960
mountiny commentedon Jan 11, 2023
I think as Andrew mentioned, @mallenexpensify we should be good to close this one out, seems like the Google API response has changed and that introduced this problem. We could not do much else other than have a regression test which will check for this.
mallenexpensify commentedon Jan 12, 2023
K, closing. Thanks @thesahindia and @mountiny