Skip to content

[$1000] User can't download the production app from playstore #11132

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to playstore
  2. Download new expensify
  3. Open the app and login
  4. Check if it has a stg badge at top

Expected Result:

The app should not have the stg badge and stg features

Actual Result:

The app is stg

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Android

Version Number:
Reproducible in staging?: need repro
Reproducible in production?: need repro
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Upwork job URL: https://www.upwork.com/jobs/~0138615bf32be2c02c
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662562500746549?thread_ts=1660710162.573049&cid=C01GTK53T8Q

View all open jobs on GitHub

Activity

  1. mallenexpensify commented on Oct 12, 2022

    @mallenexpensify
    Contributor

    @mvtglobally are you able to reproduce?

  2. melvin-bot commented on Oct 17, 2022

    @melvin-bot

    @mvtglobally Huh... This is 4 days overdue. Who can take care of this?

  3. mallenexpensify commented on Oct 17, 2022

    @mallenexpensify
    Contributor

    @mvtglobally can you see if you're able to reproduce?

  4. melvin-bot commented on Oct 19, 2022

    @melvin-bot

    @mvtglobally 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  5. mvtglobally commented on Oct 19, 2022

    @mvtglobally
    Author

    @mallenexpensify @mallenexpensify I was checking with the team on the same. There is a tricky way to download PROD build on Android with the same device as you have staging. Currently we all see STG
    Since all our testers are already getting BETA (STG) builds, not sure this result is accurate.
    Is there any chance you can ask someone in Expensify internally who DOES NOT have staging build to download PROD build?

    video_2022-10-18_01-46-04.mp4
  6. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2022
  7. mallenexpensify commented on Oct 20, 2022

    @mallenexpensify
    Contributor
  8. mallenexpensify commented on Oct 20, 2022

    @mallenexpensify
    Contributor

    Gonna close cuz @alex-mechler was able to help test and it looks like its not repro
    image

    image

  9. 122 remaining items

  10. mountiny commented on Dec 29, 2022

    @mountiny
    Contributor

    Asked in the PR if we had closed to loop on the ProductionQA actually.

  11. AndrewGable commented on Dec 30, 2022

    @AndrewGable
    Contributor

    @mallenexpensify Sounds good 👍 - Testing passed

  12. mallenexpensify commented on Dec 30, 2022

    @mallenexpensify
    Contributor

    @Puneet-here can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~019d52081ca835b9ef

  13. Puneet-here commented on Dec 30, 2022

    @Puneet-here
    Contributor
  14. mallenexpensify commented on Jan 2, 2023

    @mallenexpensify
    Contributor

    @Puneet-here paid $250 for reporting
    @AndrewGable we want to update regression test steps for this, right? If so I'll leave open and tackle the last piece.

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/253420
  15. AndrewGable commented on Jan 2, 2023

    @AndrewGable
    Contributor

    Yep - We can add a regression test for this.

  16. mallenexpensify commented on Jan 3, 2023

    @mallenexpensify
    Contributor
  17. mallenexpensify commented on Jan 3, 2023

    @mallenexpensify
    Contributor

    Likely running with this for regression test steps, will create the GH for tomorrow

    Under "Account Setting" in TR add a new test titled About - App download links
    Add steps

    1. Ensure App isn't loaded on device
    2. Click Android on an Android device
    3. Follow steps to download app
    4. Verify app has downloaded to device
    5. Verify the app does not way staging on the login page.

    I put 'does not' cuz that should be the expected behavior and staging should be the edge or test case, right? I'm still new to these steps, I'm assuming we're always creating them for the production version of the app, let me know if that's not correct

  18. mallenexpensify commented on Jan 6, 2023

    @mallenexpensify
    Contributor

    Issue created to update test steps https://github.com/Expensify/Expensify/issues/253420

    Are these needed before we close this out @AndrewGable ?

    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  19. AndrewGable commented on Jan 6, 2023

    @AndrewGable
    Contributor

    I do not think this is required, the code relied on an external site that we do not have control over, so it actually started to fail without a code change on our side.

  20. mallenexpensify commented on Jan 9, 2023

    @mallenexpensify
    Contributor

    Thanks @AndrewGable.
    @thesahindia are you able to complete the above steps? I think the process we're working towards is to have C+ complete all items they can. For any that are related to backend changes, the C+ would comment on the issue, tag the assigned internal engineer, and provide reasoning why they're unable to complete the steps.

  21. thesahindia commented on Jan 11, 2023

    @thesahindia
    Member

    I don't have much knowledge on this issue since I didn't do anything here. Just a heads-up that @srikarparsi mentioned that it was a regression from #9960

  22. mountiny commented on Jan 11, 2023

    @mountiny
    Contributor

    I think as Andrew mentioned, @mallenexpensify we should be good to close this one out, seems like the Google API response has changed and that introduced this problem. We could not do much else other than have a regression test which will check for this.

  23. mallenexpensify commented on Jan 12, 2023

    @mallenexpensify
    Contributor

    K, closing. Thanks @thesahindia and @mountiny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions