You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-11-02] [$250] Saving a workspace name should close the keyboard - reported by @chauchausoup #11195
Form input will come to address the change in the name
Once a desired name is input, press save button
Keyboard modal doesn’t goes down instead no any freezing behavior is shown on Save button
Expected Result:
Keyboard modal should close
Save button should be frozen as in web app
Actual Result:
Nothing happens. It remains as it is once a desired name is updated.
Workaround:
unknown
Platform:
Where is this issue occurring?
iOS
Android
Version Number: 1.2.1-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Add Keyboard.dismiss() after line 64 (not sure if we should dismiss the keyboard before validation or after, do we wanna keep the keyboard open if there is some error?)
changed the title [-][$250] Saving a workspace name should close the keyboard - reported by @chauchausoup[/-][+][HOLD for payment 2022-11-02] [$250] Saving a workspace name should close the keyboard - reported by @chauchausoup[/+]on Oct 26, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Sep 22, 2022
Triggered auto assignment to @NicMendonca (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.Puneet-here commentedon Sep 22, 2022
Proposal
Add Keyboard.dismiss() after line 64 (not sure if we should dismiss the keyboard before validation or after, do we wanna keep the keyboard open if there is some error?)
App/src/pages/workspace/WorkspaceSettingsPage.js
Lines 61 to 64 in f76f708
We have to do the same for other pages too because it's not only on workspace settings page.
melvin-bot commentedon Sep 22, 2022
Triggered auto assignment to @Luke9389 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Luke9389 commentedon Sep 22, 2022
@Puneet-here please wait for the Help Wanted label to be applied before leaving a proposal. Thanks!
melvin-bot commentedon Sep 22, 2022
Triggered auto assignment to @MitchExpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.41 remaining items
mallenexpensify commentedon Oct 17, 2022
@chauchausoup this should work for ya https://www.upwork.com/jobs/~014b51c853743c4959
The GH issue number and
Expensifyshould always be in the job title.MitchExpensify commentedon Oct 19, 2022
Hired @chauchausoup, thanks for sharing the working link @mallenexpensify !
[-][$250] Saving a workspace name should close the keyboard - reported by @chauchausoup[/-][+][HOLD for payment 2022-11-02] [$250] Saving a workspace name should close the keyboard - reported by @chauchausoup[/+]melvin-bot commentedon Oct 26, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-11-02. 🎊
MitchExpensify commentedon Oct 27, 2022
Made a note to pay on 2022-11-02
MitchExpensify commentedon Nov 2, 2022
Paid to all bar @mollfpr, just waiting on you to accept the offer! Thanks everyone
mollfpr commentedon Nov 3, 2022
@MitchExpensify accepted, thanks!
MitchExpensify commentedon Nov 3, 2022
Paid all, thanks again