Skip to content

[HOLD for payment 2022-11-02] [$250] Saving a workspace name should close the keyboard - reported by @chauchausoup #11195

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to workspace section
  2. Click on workspace name
  3. Form input will come to address the change in the name
  4. Once a desired name is input, press save button
  5. Keyboard modal doesn’t goes down instead no any freezing behavior is shown on Save button

Expected Result:

Keyboard modal should close
Save button should be frozen as in web app

Actual Result:

Nothing happens. It remains as it is once a desired name is updated.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.2.1-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-09-04.at.11.52.02.mov

Expensify/Expensify Issue URL:
Issue reported by: @chauchausoup
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662272007043879

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Sep 22, 2022

    @melvin-bot

    Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 22, 2022
  3. Puneet-here commented on Sep 22, 2022

    @Puneet-here
    Contributor

    Proposal

    Add Keyboard.dismiss() after line 64 (not sure if we should dismiss the keyboard before validation or after, do we wanna keep the keyboard open if there is some error?)

    submit() {
    if (this.props.policy.isPolicyUpdating || !this.validate()) {
    return;
    }

    We have to do the same for other pages too because it's not only on workspace settings page.

  4. melvin-bot commented on Sep 22, 2022

    @melvin-bot

    Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. removed their assignment
    on Sep 22, 2022
  6. Luke9389 commented on Sep 22, 2022

    @Luke9389
    Contributor

    @Puneet-here please wait for the Help Wanted label to be applied before leaving a proposal. Thanks!

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 22, 2022
  8. melvin-bot commented on Sep 22, 2022

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  9. 41 remaining items

  10. mallenexpensify commented on Oct 17, 2022

    @mallenexpensify
    Contributor

    @chauchausoup this should work for ya https://www.upwork.com/jobs/~014b51c853743c4959
    The GH issue number and Expensify should always be in the job title.

  11. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2022
  12. MitchExpensify commented on Oct 19, 2022

    @MitchExpensify
    Contributor

    Hired @chauchausoup, thanks for sharing the working link @mallenexpensify !

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 26, 2022
  14. changed the title [-][$250] Saving a workspace name should close the keyboard - reported by @chauchausoup[/-] [+][HOLD for payment 2022-11-02] [$250] Saving a workspace name should close the keyboard - reported by @chauchausoup[/+] on Oct 26, 2022
  15. melvin-bot commented on Oct 26, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-11-02. 🎊

  16. MitchExpensify commented on Oct 27, 2022

    @MitchExpensify
    Contributor

    Made a note to pay on 2022-11-02

  17. MitchExpensify commented on Nov 2, 2022

    @MitchExpensify
    Contributor

    Paid to all bar @mollfpr, just waiting on you to accept the offer! Thanks everyone

  18. mollfpr commented on Nov 3, 2022

    @mollfpr
    Contributor

    @MitchExpensify accepted, thanks!

  19. MitchExpensify commented on Nov 3, 2022

    @MitchExpensify
    Contributor

    Paid all, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions