You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for BZ checklist] [$2000] mWeb - Manage Members - Blue outline at checkbox @Puneet-here #11283
Like, when we tab around a page, we want a visual indication of what's focused.
Maybe the change here should be to un-focus on click, but again, not sure if that's actually a good practice.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat / @Luke9389] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat / @Luke9389] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat / @Luke9389] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
I'm not sure if this bug was actually caused by another PR. I think it's a bug in the sense that it's unwanted behavior, but not actually a regression. Do you agree @parasharrajat?
changed the title [-][HOLD for payment 2022-12-20] [$2000] mWeb - Manage Members - Blue outline at checkbox @Puneet-here[/-][+][HOLD for BZ checklist] [$2000] mWeb - Manage Members - Blue outline at checkbox @Puneet-here[/+]on Dec 29, 2022
I checked the boxes bc I'm pretty sure this was not a regression, so there was no link to give. I also don't think this warrants a discussion in expensify-bugs, we just need more thorough testing on front end UI PRs.
Activity
melvin-bot commentedon Sep 26, 2022
Triggered auto assignment to @laurenreidexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.varshamb commentedon Sep 26, 2022
Remove
styles.borderColorFocusBy removing this, we will have same behaviour for clicking checkbox and clicking on member name.
App/src/components/Checkbox.js
Line 107 in 6bd5304
Screen.Recording.2022-09-26.at.9.23.41.PM.mov
melvin-bot commentedon Sep 27, 2022
Triggered auto assignment to @Luke9389 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Luke9389 commentedon Sep 27, 2022
I think we may actually want this for accessibility reasons. Perhaps @shawnborton knows offhand?
Luke9389 commentedon Sep 27, 2022
Like, when we tab around a page, we want a visual indication of what's focused.
Maybe the change here should be to un-focus on click, but again, not sure if that's actually a good practice.
shawnborton commentedon Sep 27, 2022
Hmm I'm not sure, I think it should get the blue outline if it's tabbed into focus but maybe not if it's just clicked.
162 remaining items
melvin-bot commentedon Dec 13, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Luke9389 commentedon Dec 14, 2022
I'm not sure if this bug was actually caused by another PR. I think it's a bug in the sense that it's unwanted behavior, but not actually a regression. Do you agree @parasharrajat?
Christinadobrzyn commentedon Dec 21, 2022
Paying this job,
I can't tell when the PR was merged for bonuses. It looks like it was created on Nov 30th and merged on Dec 3rd? Is that right?
Paid @Puneet-here as the reporter and @getusha $1000k but I'm trying to figure out the payment for @parasharrajat and @hungvu193 and if any bonuses apply, can you help? @parasharrajat and @Luke9389
parasharrajat commentedon Dec 21, 2022
So here is the summary.
So it was not merged in 3 days.
cc: @Luke9389
Christinadobrzyn commentedon Dec 22, 2022
Job is paid for everyone - job closed in Upwork
@hungvu193 $2000 hired for the fix
@parasharrajat $2000 hired as C+
@Puneet-here $250 hired as reporter
@getusha hire for $1000 for contributions
@parasharrajat and @Luke9389 would you be able to take a look over this comment - #11283 (comment) and then close this issue?
melvin-bot commentedon Dec 29, 2022
@shawnborton, @hungvu193, @parasharrajat, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!
JmillsExpensify commentedon Dec 29, 2022
@Luke9389 @parasharrajat Mind helping @Christinadobrzyn with the checklist items above and then close out this issue?
[-][HOLD for payment 2022-12-20] [$2000] mWeb - Manage Members - Blue outline at checkbox @Puneet-here[/-][+][HOLD for BZ checklist] [$2000] mWeb - Manage Members - Blue outline at checkbox @Puneet-here[/+]melvin-bot commentedon Jan 2, 2023
@shawnborton, @hungvu193, @parasharrajat, @Luke9389 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Luke9389 commentedon Jan 4, 2023
Just seeing this after being OOO in a while. I'll check it out.
Luke9389 commentedon Jan 4, 2023
I checked the boxes bc I'm pretty sure this was not a regression, so there was no link to give. I also don't think this warrants a discussion in expensify-bugs, we just need more thorough testing on front end UI PRs.