Skip to content

[HOLD for BZ checklist] [$2000] mWeb - Manage Members - Blue outline at checkbox @Puneet-here #11283

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to settings > workspace
  3. Manage members page
  4. Select a user now tap on the checkbox of that user

Expected Result:

The checkbox shouldn't get blue outline

Actual Result:

The checkbox gets blue outline

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.2.6.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-09-05.at.10.47.19.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @Puneet-here

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662398489632479

View all open jobs on GitHub

Activity

  1. added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 26, 2022
  2. melvin-bot commented on Sep 26, 2022

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. added and removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 26, 2022
  4. varshamb commented on Sep 26, 2022

    @varshamb
    Contributor

    Remove styles.borderColorFocus
    By removing this, we will have same behaviour for clicking checkbox and clicking on member name.

    this.state.isFocused && styles.borderColorFocus,

    Screen.Recording.2022-09-26.at.9.23.41.PM.mov
  5. removed their assignment
    on Sep 27, 2022
  6. melvin-bot commented on Sep 27, 2022

    @melvin-bot

    Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. Luke9389 commented on Sep 27, 2022

    @Luke9389
    Contributor

    I think we may actually want this for accessibility reasons. Perhaps @shawnborton knows offhand?

  8. Luke9389 commented on Sep 27, 2022

    @Luke9389
    Contributor

    Like, when we tab around a page, we want a visual indication of what's focused.
    Maybe the change here should be to un-focus on click, but again, not sure if that's actually a good practice.

  9. shawnborton commented on Sep 27, 2022

    @shawnborton
    Contributor

    Hmm I'm not sure, I think it should get the blue outline if it's tabbed into focus but maybe not if it's just clicked.

  10. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 29, 2022
  11. 162 remaining items

  12. melvin-bot commented on Dec 13, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  13. Luke9389 commented on Dec 14, 2022

    @Luke9389
    Contributor

    I'm not sure if this bug was actually caused by another PR. I think it's a bug in the sense that it's unwanted behavior, but not actually a regression. Do you agree @parasharrajat?

  14. Christinadobrzyn commented on Dec 21, 2022

    @Christinadobrzyn
    Contributor

    Paying this job,

    I can't tell when the PR was merged for bonuses. It looks like it was created on Nov 30th and merged on Dec 3rd? Is that right?

    Paid @Puneet-here as the reporter and @getusha $1000k but I'm trying to figure out the payment for @parasharrajat and @hungvu193 and if any bonuses apply, can you help? @parasharrajat and @Luke9389

  15. parasharrajat commented on Dec 21, 2022

    @parasharrajat
    Member

    So here is the summary.

    1. PR was c+ approved within 3 days Fix green outline at checkbox #13181 (review).
    2. But CME took over in 6 days and then merged it.

    So it was not merged in 3 days.

    cc: @Luke9389

  16. Christinadobrzyn commented on Dec 22, 2022

    @Christinadobrzyn
    Contributor

    Job is paid for everyone - job closed in Upwork

    @hungvu193 $2000 hired for the fix
    @parasharrajat $2000 hired as C+
    @Puneet-here $250 hired as reporter
    @getusha hire for $1000 for contributions

    @parasharrajat and @Luke9389 would you be able to take a look over this comment - #11283 (comment) and then close this issue?

  17. removed their assignment
    on Dec 22, 2022
  18. melvin-bot commented on Dec 29, 2022

    @melvin-bot

    @shawnborton, @hungvu193, @parasharrajat, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  19. JmillsExpensify commented on Dec 29, 2022

    @JmillsExpensify
    Contributor

    @Luke9389 @parasharrajat Mind helping @Christinadobrzyn with the checklist items above and then close out this issue?

  20. changed the title [-][HOLD for payment 2022-12-20] [$2000] mWeb - Manage Members - Blue outline at checkbox @Puneet-here[/-] [+][HOLD for BZ checklist] [$2000] mWeb - Manage Members - Blue outline at checkbox @Puneet-here[/+] on Dec 29, 2022
  21. melvin-bot commented on Jan 2, 2023

    @melvin-bot

    @shawnborton, @hungvu193, @parasharrajat, @Luke9389 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  22. Luke9389 commented on Jan 4, 2023

    @Luke9389
    Contributor

    Just seeing this after being OOO in a while. I'll check it out.

  23. Luke9389 commented on Jan 4, 2023

    @Luke9389
    Contributor

    I checked the boxes bc I'm pretty sure this was not a regression, so there was no link to give. I also don't think this warrants a discussion in expensify-bugs, we just need more thorough testing on front end UI PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignEngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions