Skip to content

[HOLD for payment 2022-11-16] [$500] Android/iOS - Workspace - Numbers shaking while updating rate in reimburse expenses @gadhiyamanan #11352

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account with Workspace or create one
  3. Go Workspace > Reimburse expenses
  4. Edit rate

Expected Result:

Numbers should not shake

Actual Result:

Numbers shaking while updating rate in reimburse expenses

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android
  • iOS

Version Number: 1.2.7.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220907_225406_New.Expensify.mp4
LUTA9874.1.MP4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662571711808209

View all open jobs on GitHub

Activity

  1. added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 27, 2022
  2. melvin-bot commented on Sep 27, 2022

    @melvin-bot

    Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. added and removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 27, 2022
  4. melvin-bot commented on Sep 28, 2022

    @melvin-bot

    Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. removed their assignment
    on Sep 28, 2022
  6. AndrewGable commented on Sep 29, 2022

    @AndrewGable
    Contributor

    Hmm, I don't think this is a bug and is intended behavior? The number can only be so big, so we remove the last number. Feel free to reply if you disagree.

  7. gadhiyamanan commented on Sep 29, 2022

    @gadhiyamanan
    Contributor

    @AndrewGable i think we should add character limitations instead of removing last number

  8. AndrewGable commented on Sep 29, 2022

    @AndrewGable
    Contributor

    Can you provide an example of this elsewhere in the app? Thanks!

  9. gadhiyamanan commented on Sep 29, 2022

    @gadhiyamanan
    Contributor
  10. AndrewGable commented on Sep 29, 2022

    @AndrewGable
    Contributor

    Ok thank you, I agree let's match that functionality. I will send to external if you'd like to propose a solution.

  11. 54 remaining items

  12. changed the title [-][$500] Android/iOS - Workspace - Numbers shaking while updating rate in reimburse expenses @gadhiyamanan[/-] [+][HOLD for payment 2022-11-16] [$500] Android/iOS - Workspace - Numbers shaking while updating rate in reimburse expenses @gadhiyamanan[/+] on Nov 9, 2022
  13. melvin-bot commented on Nov 9, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.25-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-11-16. 🎊

  14. thesahindia commented on Nov 9, 2022

    @thesahindia
    Member

    @thesahindia could you help with identifying the PR where the bug was introduced?

    I think #9800

  15. puneetlath commented on Nov 16, 2022

    @puneetlath
    Contributor

    @gadhiyamanan @aimane-chnaif @thesahindia can you please apply to the Upwork job here so I can get everyone paid out: https://www.upwork.com/jobs/~01427aa8632545994e

  16. gadhiyamanan commented on Nov 17, 2022

    @gadhiyamanan
    Contributor

    Applied 🚀

  17. thesahindia commented on Nov 17, 2022

    @thesahindia
    Member

    Applied, thanks!

  18. aimane-chnaif commented on Nov 18, 2022

    @aimane-chnaif
    Contributor

    @gadhiyamanan @aimane-chnaif @thesahindia can you please apply to the Upwork job here so I can get everyone paid out: https://www.upwork.com/jobs/~01427aa8632545994e

    @puneetlath already applied. thanks!

  19. puneetlath commented on Nov 21, 2022

    @puneetlath
    Contributor

    Sorry for the delay! Sent you all hiring offers.

  20. melvin-bot commented on Nov 29, 2022

    @melvin-bot

    @puneetlath, @AndrewGable, @thesahindia, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  21. melvin-bot commented on Dec 1, 2022

    @melvin-bot

    @puneetlath, @AndrewGable, @thesahindia, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

  22. thesahindia commented on Dec 1, 2022

    @thesahindia
    Member

    @puneetlath, let's close this. I believe it is settled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions