You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-10-20] [$250] Ensure the page not found error message is properly centered in the chat view #11473
changed the title [-]Ensure the page not found error message is properly centered in the chat view[/-][+][$250] Ensure the page not found error message is properly centered in the chat view[/+]on Sep 30, 2022
Currently component is not quite center just because we have two components (HeaderWithCloseButton + BlockingView)
As BlockingView is already centered but due to HeaderWithCloseButton component height, combining both components does not get actually centered view
Fix
In order to fix centered <BlockingView/> we need to add paddingBottom same height as HeaderWithCloseButton height
here in below <View> component we need to add paddingBottom: variables.contentHeaderHeight
Eventually, this will fix the center issue inside the drawer as well (currently if <FullPageNotFoundView/> is inside the drawer has also same align issue)
we need to create a new style inside styles.js to avoid inline styles
Cause : With reference to View, BlockingView is centered but with presence of HeaderWithCloseButton BlockingView is not centered wrt to the page. Solution:
We can enforce centerStyle wrapper that will center any component with respect to the browser DOM despite the associated components. Such wrapper can come handy in later stages of development too.
PR is ready but it needs to have QA steps, bit confused about what steps should I add in order to generate a page not found error can you do you have any suggestions regarding that @eVoloshchak@sketchydroide
PR is ready but it needs to have QA steps, bit confused about what steps should I add in order to generate a page not found error can you do you have any suggestions regarding that @eVoloshchak@sketchydroide
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][$250] Ensure the page not found error message is properly centered in the chat view[/-][+][HOLD for payment 2022-10-20] [$250] Ensure the page not found error message is properly centered in the chat view[/+]on Oct 13, 2022
Activity
melvin-bot commentedon Sep 30, 2022
Triggered auto assignment to @MitchExpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 30, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)melvin-bot commentedon Sep 30, 2022
Triggered auto assignment to @sketchydroide (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.[-]Ensure the page not found error message is properly centered in the chat view[/-][+][$250] Ensure the page not found error message is properly centered in the chat view[/+]dhairyasenjaliya commentedon Sep 30, 2022
Proposal
Cause
Fix
<BlockingView/>we need to add paddingBottom same height as HeaderWithCloseButton height<View>component we need to addpaddingBottom: variables.contentHeaderHeight<FullPageNotFoundView/>is inside the drawer has also same align issue)App/src/components/BlockingViews/FullPageNotFoundView.js
Lines 58 to 64 in 607f8e9
Result
Web

M-web

iPhone
Drawer
With Fix

Without fix (current code)

krishnemd commentedon Oct 1, 2022
Proposal:
Cause : With reference to View, BlockingView is centered but with presence of HeaderWithCloseButton BlockingView is not centered wrt to the page.
Solution:
We can enforce centerStyle wrapper that will center any component with respect to the browser DOM despite the associated components. Such wrapper can come handy in later stages of development too.
Wrapper Style:
Add this style to View Component as
<View style={[styles.flex1, styles.centerStyle]}>Before the wrapper:
After the wrapper:
14 remaining items
dhairyasenjaliya commentedon Oct 4, 2022
will create PR soon :)
dhairyasenjaliya commentedon Oct 5, 2022
PR is ready but it needs to have QA steps, bit confused about what steps should I add in order to generate a page not found error can you do you have any suggestions regarding that @eVoloshchak @sketchydroide
eVoloshchak commentedon Oct 5, 2022
I think #10452 contains the necessary steps
dhairyasenjaliya commentedon Oct 5, 2022
QA steps updated thank you,PR ready for review :) @eVoloshchak
melvin-bot commentedon Oct 13, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-10-20. 🎊
[-][$250] Ensure the page not found error message is properly centered in the chat view[/-][+][HOLD for payment 2022-10-20] [$250] Ensure the page not found error message is properly centered in the chat view[/+]MitchExpensify commentedon Oct 20, 2022
Paid @dhairyasenjaliya
Offer sent here @eVoloshchak
MitchExpensify commentedon Oct 20, 2022
Paid all!