Skip to content

[HOLD for payment 2022-11-24] [$250] BUG: when deleting the last message of a conversation (own messages) the chat is marked as unread for a moment  #11688

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to ND and login
  2. go to a report and delete the last message (own message)

Expected Result:

LHN should be updated with last message

Actual Result:

The message switches to bold to indicate as unread message for a second

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.12-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.652.mp4

Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665165816566859

View all open jobs on GitHub

Activity

  1. added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Oct 9, 2022
  2. melvin-bot commented on Oct 9, 2022

    @melvin-bot

    Triggered auto assignment to @isabelastisser (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. added and removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Oct 9, 2022
  4. Puneet-here commented on Oct 11, 2022

    @Puneet-here
    Contributor

    Just wanted to comment that, it is reproducible on deleting any message, not just last message.

  5. melvin-bot commented on Oct 12, 2022

    @melvin-bot

    @isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. isabelastisser commented on Oct 12, 2022

    @isabelastisser
    Contributor

    I was OOO for the past 3 weeks and catching up now, will review this soon.

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2022
  8. isabelastisser commented on Oct 21, 2022

    @isabelastisser
    Contributor

    Reviewing this now.

  9. 64 remaining items

  10. isabelastisser commented on Nov 28, 2022

    @isabelastisser
    Contributor

    @eVoloshchak , did you find the offending PR? Thanks!

  11. eVoloshchak commented on Nov 28, 2022

    @eVoloshchak
    Contributor

    Sorry, missed this one
    It seems like #10929 has introduced this bug

  12. isabelastisser commented on Dec 1, 2022

    @isabelastisser
    Contributor

    Update:

    • Payment has been made to the contributor that fixed the issue (if applicable) - Done, @tienifr

    • @eVoloshchak , you haven't applied for the job in Upwork, so I sent you an offer there. Please accept it, and I will issue the payment. Thanks!

  13. isabelastisser commented on Dec 1, 2022

    @isabelastisser
    Contributor
    • Payment has been made to the contributor+ that helped on the issue (if applicable) @eVoloshchak , done!
  14. eVoloshchak commented on Dec 1, 2022

    @eVoloshchak
    Contributor

    @isabelastisser, could you please check if we are eligible for the bonus? PR was merged the same day @tienifr was assigned to the job if I recall correctly

  15. isabelastisser commented on Dec 2, 2022

    @isabelastisser
    Contributor

    I will review this by EOD.

  16. eVoloshchak commented on Dec 5, 2022

    @eVoloshchak
    Contributor

    Not overdue, waiting for the payments to be settled

  17. isabelastisser commented on Dec 7, 2022

    @isabelastisser
    Contributor

    I apologize for my delay here! The PR was merged within 3 business days, so I issued the 50% bonus in Upwork now. @eVoloshchak @tienifr , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions