You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Software keyboard covers part of the submit button on login page #11701
The software keyboard should open, and the text input, submit button, etc... should shift up such that it's completely in view
Actual Result:
The submit button is partially covered.
Workaround:
n/a – just ignore the visual bug
Platform:
Where is this issue occurring?
Mobile Web (Android Chrome)
Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
Interestingly, if you scroll the page up and down with the keyboard open, then this bug no longer happens. You can completely close the keyboard, scroll back to the top, and then tap on the TextInput and it does not happen again. If you then refresh the page, then it will happen again.
changed the title [-]Software keyboard covers part of the submit button on login page[/-][+][HOLD] Software keyboard covers part of the submit button on login page[/+]on Oct 10, 2022
changed the title [-][HOLD] Software keyboard covers part of the submit button on login page[/-][+]Software keyboard covers part of the submit button on login page[/+]on Oct 13, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Payment has been made to the issue reporter (if applicable)
Payment has been made to the contributor that fixed the issue (if applicable)
Payment has been made to the contributor+ that helped on the issue (if applicable)
hey @JmillsExpensify, thanks for testing that! I had originally thought that this was fixed by my PR, and included it in the list of fixes. However, after some testing, we found that there was still an issue on Android Chrome. You can see here, on the password form, the sign in button is still partially covered:
Oh nice! I tested on iOS and wasn't able to see it anymore. I'll update the testing reproduction steps and remove Safari so this issue focuses on Android wWeb moving forward. What do you think?
PR is ready to merge. There's one consideration for small screen Android mentioned in the PR, though that's not a blocker. Someone click the merge button and let's close this out!
I'm working on a large regression test in the linked issue above. I'm going to hold creating it until we have a broader stream of keyboard cases. Linked PR is stilling waiting to be deployed to staging/production, so I'll continue to keep this issue open in the meantime.
changed the title [-]Software keyboard covers part of the submit button on login page[/-][+][HOLD for payment] Software keyboard covers part of the submit button on login page[/+]on Dec 8, 2022
changed the title [-][HOLD for payment] Software keyboard covers part of the submit button on login page[/-][+]Software keyboard covers part of the submit button on login page[/+]on Dec 10, 2022
@aimane-chnaif sorry for the confusion. I think @JmillsExpensify probably didn't realize there were two C+ on this one. I sent you a hiring offer.
@puneetlath thanks. Just to confirm:
I see you offered $500. As for the new rule, internal PR review is compensated as flatten $1000.
But 2 C+ reviews was the reason of halving?
Activity
roryabraham commentedon Oct 10, 2022
Interestingly, if you scroll the page up and down with the keyboard open, then this bug no longer happens. You can completely close the keyboard, scroll back to the top, and then tap on the TextInput and it does not happen again. If you then refresh the page, then it will happen again.
[-]Software keyboard covers part of the submit button on login page[/-][+][HOLD] Software keyboard covers part of the submit button on login page[/+][-][HOLD] Software keyboard covers part of the submit button on login page[/-][+]Software keyboard covers part of the submit button on login page[/+]tgolen commentedon Oct 13, 2022
I removed the HOLD on this and assigned it to me because this is fixed in #11586
JmillsExpensify commentedon Nov 3, 2022
Linked PR hit production 12 hours ago. I tested this and all looked good. @tgolen are you seeing the same?
melvin-bot commentedon Nov 3, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:
tgolen commentedon Nov 3, 2022
hey @JmillsExpensify, thanks for testing that! I had originally thought that this was fixed by my PR, and included it in the list of fixes. However, after some testing, we found that there was still an issue on Android Chrome. You can see here, on the password form, the sign in button is still partially covered:
JmillsExpensify commentedon Nov 3, 2022
Oh nice! I tested on iOS and wasn't able to see it anymore. I'll update the testing reproduction steps and remove Safari so this issue focuses on Android wWeb moving forward. What do you think?
54 remaining items
JmillsExpensify commentedon Dec 5, 2022
PR is ready to merge. There's one consideration for small screen Android mentioned in the PR, though that's not a blocker. Someone click the
mergebutton and let's close this out!JmillsExpensify commentedon Dec 8, 2022
PR is merged.
JmillsExpensify commentedon Dec 8, 2022
I'm working on a large regression test in the linked issue above. I'm going to hold creating it until we have a broader stream of keyboard cases. Linked PR is stilling waiting to be deployed to staging/production, so I'll continue to keep this issue open in the meantime.
[-]Software keyboard covers part of the submit button on login page[/-][+][HOLD for payment] Software keyboard covers part of the submit button on login page[/+]JmillsExpensify commentedon Dec 10, 2022
I went ahead and paid out C+ for the internal PR review. We'll close this issue when it hits production.
[-][HOLD for payment] Software keyboard covers part of the submit button on login page[/-][+]Software keyboard covers part of the submit button on login page[/+]JmillsExpensify commentedon Dec 12, 2022
Heads up, I'm OOO this week, so let's make sure we close this issue as soon as the PR hits production. C+ has already been paid.
aimane-chnaif commentedon Dec 12, 2022
I am not paid yet for C+ review
tgolen commentedon Dec 13, 2022
@aimane-chnaif I'll look into that and see if I can help make sure you get paid out
puneetlath commentedon Dec 13, 2022
@aimane-chnaif sorry for the confusion. I think @JmillsExpensify probably didn't realize there were two C+ on this one. I sent you a hiring offer.
aimane-chnaif commentedon Dec 13, 2022
@puneetlath thanks. Just to confirm:
I see you offered $500. As for the new rule, internal PR review is compensated as flatten $1000.
But 2 C+ reviews was the reason of halving?
puneetlath commentedon Dec 13, 2022
That was the bounty for this issue at the time, since this pre-dates the increase to $1000.
aimane-chnaif commentedon Dec 13, 2022
Thanks for clarification. Accepted offer
puneetlath commentedon Dec 13, 2022
Thanks @aimane-chnaif !
@tgolen @JmillsExpensify FYI both @rushatgabhane and @aimane-chnaif have been paid now.