You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD][$250] Dev - Getting console warning in android #11733
Console warnings about keyboardAvoidingViewBehavior are present
Workaround:
Unknown
Platform:
Where is this issue occurring?
Android
Version Number: 1.2.12-3 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Activity
melvin-bot commentedon Oct 11, 2022
Triggered auto assignment to @MitchExpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.aimane-chnaif commentedon Oct 12, 2022
Proposal
App/src/pages/home/ReportScreen.js
Line 210 in 299f07b
The issue happens from above line added here
App/src/components/ScreenWrapper/propTypes.js
Line 24 in 299f07b
keyboardAvoidingViewBehaviorprops value is expected one of these 3 but in android it's set to''Solution:
- keyboardAvoidingViewBehavior={Platform.OS === 'android' ? '' : 'padding'}remove this line
By doing this, android
keyboardAvoidingViewBehaviorset toheightand iOSkeyboardAvoidingViewBehaviorkeepspaddingunchanged.The default values are found here
ios:
App/src/components/ScreenWrapper/propTypes.js
Line 39 in 6bd5304
android:
App/src/components/ScreenWrapper/index.android.js
Line 14 in 6bd5304
hungvu193 commentedon Oct 12, 2022
Actually, change the default proptypes can effect other screens.
For this case I think we should change:
App/src/pages/home/ReportScreen.js
Line 210 in 299f07b
into:
After that, the warning will disappear and also it won't effect other screens.
thesahindia commentedon Oct 12, 2022
I vote we close this issue as it's not a big problem and will be fixed after #10648
marcaaron commentedon Oct 12, 2022
Please wait until the issue has been triaged and
Help Wantedlabel added.melvin-bot commentedon Oct 12, 2022
Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.
37 remaining items
Luke9389 commentedon Nov 7, 2022
still on hold
aimane-chnaif commentedon Nov 8, 2022
#11586 is merged already and the current codebase is what I proposed here.
Since this issue no longer happens, can be closed now.
MitchExpensify commentedon Nov 17, 2022
@Luke9389 What do you think about closing this given the above comment?
Luke9389 commentedon Nov 17, 2022
Gotta read this one back over.
Luke9389 commentedon Nov 17, 2022
Yep we can close this now. Thanks @aimane-chnaif.
aneequeahmad commentedon Nov 17, 2022
@MitchExpensify This one is fixed in production, am i eligible for reporting bonus ?
MitchExpensify commentedon Nov 17, 2022
Yes @aneequeahmad, paying now
MitchExpensify commentedon Nov 17, 2022
Mind applying here and I'll issue the reporting bonus? Thanks @aneequeahmad
aneequeahmad commentedon Nov 18, 2022
@MitchExpensify applied thanks
MitchExpensify commentedon Nov 18, 2022
Paid!