Skip to content

[$1000] [HOLD for payment 2022-12-20] BUG: Offline requests are triggered after signing out #11850

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to new.expensify.com.
  2. Enter email. Click Continue.
  3. Enter password. Click Signin.
  4. Press command + option + J to open JS console.
  5. Click Network in JS console.
  6. Turn off your internet connection.
  7. Click three different reports in LHN, and notice API requests are queued.
  8. Open settings page.
  9. Click Sign out.
  10. Turn on your internet connection
  11. Reload the newdot sign in page.
  12. Notice that the requests taken while logged in are triggered in a loop and if you click on any of the requests and they all fail with session expired.

Expected Result:

No requests should be triggered

Actual Result:

Requests taken while signed in are triggered

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS - Could not check API request in app
  • Android - Could not check API request in app
  • Desktop App
  • Mobile Web

Version Number: 1.2.15-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-10-13.at.2.54.15.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @luacmartins
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665694797069499

View all open jobs on GitHub
mweb
Screenshot (245)

Upwork Automation - Do Not Edit

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01eb5d4aa7332964cc
  • Upwork Job ID: 1604963994704998400
  • Last Price Increase: 2022-12-19

Activity

  1. added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Oct 14, 2022
  2. melvin-bot commented on Oct 14, 2022

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Oct 14, 2022
  4. joekaufmanexpensify commented on Oct 14, 2022

    @joekaufmanexpensify
    Contributor

    Having trouble reproducing this. @luacmartins , do I need to have the JS console open prior to logging out?

    2022-10-14_14-54-12 (1)

  5. joekaufmanexpensify commented on Oct 17, 2022

    @joekaufmanexpensify
    Contributor

    Not overdue, will look into more today.

  6. luacmartins commented on Oct 17, 2022

    @luacmartins
    Contributor

    @joekaufmanexpensify I just managed to reproduce again, but this time I had to refresh the page.

    Screen.Recording.2022-10-17.at.10.27.14.AM.mov
  7. mountiny commented on Oct 17, 2022

    @mountiny
    Contributor

    I ma not sure how we would prevent this as logging out will remove the authtoken and make it stale so making the requests after cannot be authenticated (makes sense). What do you think Carlos

  8. luacmartins commented on Oct 17, 2022

    @luacmartins
    Contributor

    I think that we should clear the request queue so that these requests are not triggered at all!

  9. mountiny commented on Oct 17, 2022

    @mountiny
    Contributor

    I think that we should clear the request queue so that these requests are not triggered at all!

    Good, I agree with that, was just confirming, thanks!

  10. 145 remaining items

  11. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 19, 2022
  12. joekaufmanexpensify commented on Dec 19, 2022

    @joekaufmanexpensify
    Contributor

    @Santhosh-Sellavel offer sent for $1,000!

  13. joekaufmanexpensify commented on Dec 20, 2022

    @joekaufmanexpensify
    Contributor

    Still discussing new regression test in Slack.

  14. joekaufmanexpensify commented on Dec 20, 2022

    @joekaufmanexpensify
    Contributor

    @Santhosh-Sellavel bump on accepting the offer in Upwork so we can pay you. Thanks!

  15. Santhosh-Sellavel commented on Dec 21, 2022

    @Santhosh-Sellavel
    Collaborator

    @joekaufmanexpensify Thanks for the bump!

  16. joekaufmanexpensify commented on Dec 21, 2022

    @joekaufmanexpensify
    Contributor

    Of course! Payment sent and contract ended!

  17. joekaufmanexpensify commented on Dec 21, 2022

    @joekaufmanexpensify
    Contributor

    Closed job in upwork!

  18. joekaufmanexpensify commented on Dec 21, 2022

    @joekaufmanexpensify
    Contributor

    Linked new regression test above in BZ checklist.

  19. joekaufmanexpensify commented on Dec 21, 2022

    @joekaufmanexpensify
    Contributor

    Bug is fixed, all necessary payment is issued, and BZ checklist is complete. Closing. Thanks for the work on this one everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions