Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in review
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to new.expensify.com.
- Enter email. Click Continue.
- Enter password. Click Signin.
- Press command + option + J to open JS console.
- Click Network in JS console.
- Turn off your internet connection.
- Click three different reports in LHN, and notice API requests are queued.
- Open settings page.
- Click Sign out.
- Turn on your internet connection
- Reload the newdot sign in page.
- Notice that the requests taken while logged in are triggered in a loop and if you click on any of the requests and they all fail with session expired.
Expected Result:
No requests should be triggered
Actual Result:
Requests taken while signed in are triggered
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS - Could not check API request in app
- Android - Could not check API request in app
- Desktop App
- Mobile Web
Version Number: 1.2.15-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Screen.Recording.2022-10-13.at.2.54.15.PM.mov
Expensify/Expensify Issue URL:
Issue reported by: @luacmartins
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665694797069499
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~017e848943cbf36ad1
- Upwork Job ID: 1599834031670763520
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01eb5d4aa7332964cc
- Upwork Job ID: 1604963994704998400
- Last Price Increase: 2022-12-19
Metadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2EngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in review


Activity
melvin-bot commentedon Oct 14, 2022
Triggered auto assignment to @joekaufmanexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.joekaufmanexpensify commentedon Oct 14, 2022
Having trouble reproducing this. @luacmartins , do I need to have the JS console open prior to logging out?
joekaufmanexpensify commentedon Oct 17, 2022
Not overdue, will look into more today.
luacmartins commentedon Oct 17, 2022
@joekaufmanexpensify I just managed to reproduce again, but this time I had to refresh the page.
Screen.Recording.2022-10-17.at.10.27.14.AM.mov
mountiny commentedon Oct 17, 2022
I ma not sure how we would prevent this as logging out will remove the authtoken and make it stale so making the requests after cannot be authenticated (makes sense). What do you think Carlos
luacmartins commentedon Oct 17, 2022
I think that we should clear the request queue so that these requests are not triggered at all!
mountiny commentedon Oct 17, 2022
Good, I agree with that, was just confirming, thanks!
145 remaining items
joekaufmanexpensify commentedon Dec 19, 2022
@Santhosh-Sellavel offer sent for $1,000!
joekaufmanexpensify commentedon Dec 20, 2022
Still discussing new regression test in Slack.
joekaufmanexpensify commentedon Dec 20, 2022
@Santhosh-Sellavel bump on accepting the offer in Upwork so we can pay you. Thanks!
Santhosh-Sellavel commentedon Dec 21, 2022
@joekaufmanexpensify Thanks for the bump!
joekaufmanexpensify commentedon Dec 21, 2022
Of course! Payment sent and contract ended!
joekaufmanexpensify commentedon Dec 21, 2022
Closed job in upwork!
joekaufmanexpensify commentedon Dec 21, 2022
Linked new regression test above in BZ checklist.
joekaufmanexpensify commentedon Dec 21, 2022
Bug is fixed, all necessary payment is issued, and BZ checklist is complete. Closing. Thanks for the work on this one everyone!