Skip to content

[HOLD for payment 2022-11-24] [$250] Bug: Safari- RHN leaves empty space at the bottom after closing the 2nd tab reported by @Tushu17  #12005

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open new.expensify.com in safari browser
  2. Open another tab
  3. Open settings page in NewDot
  4. Close the other tab

Expected Result:

No changes appear in the NewDot tab

Actual Result:

RHN doesn't resize itself & leave empty space below.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web - Safari - version 16.1

Version Number: 1.2.18-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.29.mp4
Screen.Recording.2022-10-19.at.2.01.11.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666127526070089

View all open jobs on GitHub

Activity

  1. added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Oct 19, 2022
  2. melvin-bot commented on Oct 19, 2022

    @melvin-bot

    Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Oct 19, 2022
  4. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2022
  5. sakluger commented on Oct 20, 2022

    @sakluger
    Contributor

    @kavimuru @Tushu17 I was unable to reproduce in Web Safari in staging (v1.2.18-3) or production (v1.2.17.4). Could you please check to see if this issue can still be reproduced in staging or prod?

  6. Tushu17 commented on Oct 20, 2022

    @Tushu17
    Contributor

    @sakluger Yes, It's still reproducible for me in both staging and production. You can also repro this by:-

    1. Opening safari browser and decrease its window size.
    2. Now go to Expensify website.
    3. Open Settings page
    4. Full screen safari window.
    Screen.Recording.2022-10-20.at.11.50.36.PM.mov
  7. sakluger commented on Oct 24, 2022

    @sakluger
    Contributor

    I'm still unable to reproduce, so I've asked for others to help in Slack.

  8. sakluger commented on Oct 24, 2022

    @sakluger
    Contributor

    @Tushu17 what version of Safari are you using? I'm on Safari Version 16.0.

  9. Tushu17 commented on Oct 25, 2022

    @Tushu17
    Contributor

    @Tushu17 what version of Safari are you using?

    @sakluger I'm using version 16.1 of Safari.

  10. 43 remaining items

  11. melvin-bot commented on Nov 17, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.28-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-11-24. 🎊

  12. changed the title [-][$250] Bug: Safari- RHN leaves empty space at the bottom after closing the 2nd tab reported by @Tushu17 [/-] [+][HOLD for payment 2022-11-24] [$250] Bug: Safari- RHN leaves empty space at the bottom after closing the 2nd tab reported by @Tushu17 [/+] on Nov 17, 2022
  13. sakluger commented on Nov 22, 2022

    @sakluger
    Contributor

    Hi @VikalpP I've accepted your proposal on Upwork.

  14. melvin-bot commented on Nov 28, 2022

    @melvin-bot

    @sakluger, @VikalpP, @chiragsalian, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

  15. VikalpP commented on Nov 28, 2022

    @VikalpP
    Contributor

    I've already requested for payment on upwork -- no response.

  16. sakluger commented on Nov 28, 2022

    @sakluger
    Contributor

    Apologies for the delay, I just returned from the long Thanksgiving holiday weekend. I will review and pay out today as long as everything looks good.

  17. sakluger commented on Nov 28, 2022

    @sakluger
    Contributor

    Hi all, I just noticed that in this PR comment, @aimane-chnaif suggested we revert the PR for this GH issue, but it was never reverted. Was that suggestion to revert incorrect? Before paying out, I want to make sure that the fix for this issue didn't cause any regressions.

  18. chiragsalian commented on Nov 28, 2022

    @chiragsalian
    Contributor

    Yeah, I don't see any revert. I see vikalp's code on our main branch. There is no mention that this caused a regression anywhere so I can only assume it's been stable since it's been live. Feel free to go ahead and process the payment.

  19. sakluger commented on Nov 28, 2022

    @sakluger
    Contributor

    Thanks for checking @chiragsalian! I went ahead and paid out everyone for this job and closed the Upwork post. Finishing up the checklist before closing the issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions