You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-11-24] [$250] Bug: Safari- RHN leaves empty space at the bottom after closing the 2nd tab reported by @Tushu17 #12005
RHN doesn't resize itself & leave empty space below.
Workaround:
unknown
Platform:
Where is this issue occurring?
Web - Safari - version 16.1
Version Number: 1.2.18-1 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
@kavimuru@Tushu17 I was unable to reproduce in Web Safari in staging (v1.2.18-3) or production (v1.2.17.4). Could you please check to see if this issue can still be reproduced in staging or prod?
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.28-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][$250] Bug: Safari- RHN leaves empty space at the bottom after closing the 2nd tab reported by @Tushu17 [/-][+][HOLD for payment 2022-11-24] [$250] Bug: Safari- RHN leaves empty space at the bottom after closing the 2nd tab reported by @Tushu17 [/+]on Nov 17, 2022
Hi all, I just noticed that in this PR comment, @aimane-chnaif suggested we revert the PR for this GH issue, but it was never reverted. Was that suggestion to revert incorrect? Before paying out, I want to make sure that the fix for this issue didn't cause any regressions.
Yeah, I don't see any revert. I see vikalp's code on our main branch. There is no mention that this caused a regression anywhere so I can only assume it's been stable since it's been live. Feel free to go ahead and process the payment.
Thanks for checking @chiragsalian! I went ahead and paid out everyone for this job and closed the Upwork post. Finishing up the checklist before closing the issue here.
Activity
melvin-bot commentedon Oct 19, 2022
Triggered auto assignment to @sakluger (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.sakluger commentedon Oct 20, 2022
@kavimuru @Tushu17 I was unable to reproduce in Web Safari in staging (v1.2.18-3) or production (v1.2.17.4). Could you please check to see if this issue can still be reproduced in staging or prod?
Tushu17 commentedon Oct 20, 2022
@sakluger Yes, It's still reproducible for me in both staging and production. You can also repro this by:-
Screen.Recording.2022-10-20.at.11.50.36.PM.mov
sakluger commentedon Oct 24, 2022
I'm still unable to reproduce, so I've asked for others to help in Slack.
sakluger commentedon Oct 24, 2022
@Tushu17 what version of Safari are you using? I'm on Safari Version 16.0.
Tushu17 commentedon Oct 25, 2022
@sakluger I'm using version 16.1 of Safari.
43 remaining items
melvin-bot commentedon Nov 17, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.28-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-11-24. 🎊
[-][$250] Bug: Safari- RHN leaves empty space at the bottom after closing the 2nd tab reported by @Tushu17 [/-][+][HOLD for payment 2022-11-24] [$250] Bug: Safari- RHN leaves empty space at the bottom after closing the 2nd tab reported by @Tushu17 [/+]sakluger commentedon Nov 22, 2022
Hi @VikalpP I've accepted your proposal on Upwork.
melvin-bot commentedon Nov 28, 2022
@sakluger, @VikalpP, @chiragsalian, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...
VikalpP commentedon Nov 28, 2022
I've already requested for payment on upwork -- no response.
sakluger commentedon Nov 28, 2022
Apologies for the delay, I just returned from the long Thanksgiving holiday weekend. I will review and pay out today as long as everything looks good.
sakluger commentedon Nov 28, 2022
Hi all, I just noticed that in this PR comment, @aimane-chnaif suggested we revert the PR for this GH issue, but it was never reverted. Was that suggestion to revert incorrect? Before paying out, I want to make sure that the fix for this issue didn't cause any regressions.
chiragsalian commentedon Nov 28, 2022
Yeah, I don't see any revert. I see vikalp's code on our main branch. There is no mention that this caused a regression anywhere so I can only assume it's been stable since it's been live. Feel free to go ahead and process the payment.
sakluger commentedon Nov 28, 2022
Thanks for checking @chiragsalian! I went ahead and paid out everyone for this job and closed the Upwork post. Finishing up the checklist before closing the issue here.