Skip to content

[PAID][Regression in PR][$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202  #12066

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings
  2. Go to Profile
  3. Delete profile pic if already exist
  4. Click on avatar
  5. Click on Upload photo
  6. Choose a high resolution photo
  7. Click Save
  8. Go to any workspace
  9. Click Manage members
  10. Remove other members if exist by selecting all and then clicking on remove button
  11. Click on Select all checkbox

Expected Result:

Not able to check Select all checkbox when there is only me on the list

Actual Result:

Able to check Select all checkbox when there is only me on the list

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.18-4
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-10-21.at.9.46.11.PM.mov
Recording.760.mp4

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666371501103159

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Oct 21, 2022
  2. melvin-bot commented on Oct 21, 2022

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Oct 21, 2022
  4. mallenexpensify commented on Oct 21, 2022

    @mallenexpensify
    Contributor

    @adeel0202 @kavimuru , you shouldn't be able to remove the admin of a workspace, right? So that box wouldn't/shouldn't be checked since it's not actionable... right?

    2022-10-21_16-32-48.mp4
  5. kavimuru commented on Oct 21, 2022

    @kavimuru
    Author

    @mallenexpensify Yes, shouldn't be able to select the admin to delete. But it allows to remove and then error message appears. This is only reproducible by following the same steps in the actions performed. Please change the profile image of size 3mb.

  6. mallenexpensify commented on Oct 24, 2022

    @mallenexpensify
    Contributor

    Unable to reproduce on staging/Chrome with my test account. used a 4mb and 5mb test image. Works as expected.

    2022-10-24_07-48-50.mp4

    Tried other setups too - added two people then tried to select all, still no luck.

    Anything else I might be missing? @kavimuru @adeel0202 are you both still able to repro?

  7. kavimuru commented on Oct 24, 2022

    @kavimuru
    Author

    @mallenexpensify I'm still able to reproduce. My profile image size is 3.8mb. Also you should remove the member right after adding profile picture.

    Recording.778.mp4
  8. adeel0202 commented on Oct 24, 2022

    @adeel0202
    Contributor

    I'm also still able to reproduce.

    Also you should remove the member right after adding profile picture.

    yup, you have to perform all the steps in a go and as quickly as possible.
    upload a high res photo > go to any workspace > manage members page > select all > remove all selected members > select all

  9. mallenexpensify commented on Oct 24, 2022

    @mallenexpensify
    Contributor

    Still not able to, tried multiple test accounts too, on staging and production, in chrome and firefox.
    Gonna dish to Engineering to see if they can, since both of you have been able to

  10. 55 remaining items

  11. parasharrajat commented on Nov 17, 2022

    @parasharrajat
    Member

    There is a regression from this issue's PR #12770 .

  12. changed the title [-][HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/-] [+][Regression in PR][HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/+] on Nov 18, 2022
  13. laurenreidexpensify commented on Dec 1, 2022

    @laurenreidexpensify
    Contributor

    @sobitneupane @srikarparsi can you confirm the status of the regression hold on this? Thanks

  14. sobitneupane commented on Dec 1, 2022

    @sobitneupane
    Contributor

    @laurenreidexpensify

    PR was deployed to production 3 days back.
    Issue for regression: #12770

  15. laurenreidexpensify commented on Dec 5, 2022

    @laurenreidexpensify
    Contributor

    Looks like we're at 7 days on the regression being on prod with no further regression reported. Going to proceed to payment here now.

  16. changed the title [-][Regression in PR][HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/-] [+][PAID][Regression in PR][$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/+] on Dec 5, 2022
  17. laurenreidexpensify commented on Dec 5, 2022

    @laurenreidexpensify
    Contributor

    All payments have been issued in Upwork.

    @srikarparsi @sobitneupane can you please add any relevant links here

  18. laurenreidexpensify commented on Dec 5, 2022

    @laurenreidexpensify
    Contributor

    Confirming Regression testing here

  19. srikarparsi commented on Dec 8, 2022

    @srikarparsi
    Contributor

    hey @sobitneupane, do you have the bandwidth to work on the first three steps: #12066 (comment)

  20. sobitneupane commented on Dec 9, 2022

    @sobitneupane
    Contributor

    Updated BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions