You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAID][Regression in PR][$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 #12066
Remove other members if exist by selecting all and then clicking on remove button
Click on Select all checkbox
Expected Result:
Not able to check Select all checkbox when there is only me on the list
Actual Result:
Able to check Select all checkbox when there is only me on the list
Workaround:
unknown
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: 1.2.18-4 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
@adeel0202@kavimuru , you shouldn't be able to remove the admin of a workspace, right? So that box wouldn't/shouldn't be checked since it's not actionable... right?
@mallenexpensify Yes, shouldn't be able to select the admin to delete. But it allows to remove and then error message appears. This is only reproducible by following the same steps in the actions performed. Please change the profile image of size 3mb.
Also you should remove the member right after adding profile picture.
yup, you have to perform all the steps in a go and as quickly as possible.
upload a high res photo > go to any workspace > manage members page > select all > remove all selected members > select all
Still not able to, tried multiple test accounts too, on staging and production, in chrome and firefox.
Gonna dish to Engineering to see if they can, since both of you have been able to
changed the title [-][HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/-][+][Regression in PR][HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/+]on Nov 18, 2022
changed the title [-][Regression in PR][HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/-][+][PAID][Regression in PR][$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/+]on Dec 5, 2022
Updated BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@srikarparsi@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
Not commented. Because I don't think this bug could have been caught in the PR.
[@srikarparsi@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1670562172269399
This type of bug is very difficult to catch. Because it involves two different flows: one uploading high resolution image and other deleting members from workspace.
Activity
melvin-bot commentedon Oct 21, 2022
Triggered auto assignment to @mallenexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.mallenexpensify commentedon Oct 21, 2022
@adeel0202 @kavimuru , you shouldn't be able to remove the admin of a workspace, right? So that box wouldn't/shouldn't be checked since it's not actionable... right?
2022-10-21_16-32-48.mp4
kavimuru commentedon Oct 21, 2022
@mallenexpensify Yes, shouldn't be able to select the admin to delete. But it allows to remove and then error message appears. This is only reproducible by following the same steps in the actions performed. Please change the profile image of size 3mb.
mallenexpensify commentedon Oct 24, 2022
Unable to reproduce on staging/Chrome with my test account. used a 4mb and 5mb test image. Works as expected.
2022-10-24_07-48-50.mp4
Tried other setups too - added two people then tried to select all, still no luck.
Anything else I might be missing? @kavimuru @adeel0202 are you both still able to repro?
kavimuru commentedon Oct 24, 2022
@mallenexpensify I'm still able to reproduce. My profile image size is 3.8mb. Also you should remove the member right after adding profile picture.
Recording.778.mp4
adeel0202 commentedon Oct 24, 2022
I'm also still able to reproduce.
yup, you have to perform all the steps in a go and as quickly as possible.
upload a high res photo > go to any workspace > manage members page > select all > remove all selected members > select all
mallenexpensify commentedon Oct 24, 2022
Still not able to, tried multiple test accounts too, on staging and production, in chrome and firefox.
Gonna dish to Engineering to see if they can, since both of you have been able to
55 remaining items
parasharrajat commentedon Nov 17, 2022
There is a regression from this issue's PR #12770 .
[-][HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/-][+][Regression in PR][HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/+]laurenreidexpensify commentedon Dec 1, 2022
@sobitneupane @srikarparsi can you confirm the status of the regression hold on this? Thanks
sobitneupane commentedon Dec 1, 2022
@laurenreidexpensify
PR was deployed to production 3 days back.
Issue for regression: #12770
laurenreidexpensify commentedon Dec 5, 2022
Looks like we're at 7 days on the regression being on prod with no further regression reported. Going to proceed to payment here now.
[-][Regression in PR][HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/-][+][PAID][Regression in PR][$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202 [/+]laurenreidexpensify commentedon Dec 5, 2022
All payments have been issued in Upwork.
@srikarparsi @sobitneupane can you please add any relevant links here
laurenreidexpensify commentedon Dec 5, 2022
Confirming Regression testing here
srikarparsi commentedon Dec 8, 2022
hey @sobitneupane, do you have the bandwidth to work on the first three steps: #12066 (comment)
sobitneupane commentedon Dec 9, 2022
Updated BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Probably Migrate policy API to remove policy members #10452 as it was the PR which introduces pendingAction in
removeMembersNot commented. Because I don't think this bug could have been caught in the PR.
https://expensify.slack.com/archives/C049HHMV9SM/p1670562172269399
This type of bug is very difficult to catch. Because it involves two different flows: one uploading high resolution image and other deleting members from workspace.