You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-03-14] Implement better default avatars #12259
Just a heads up that I updated the original comment with a new mockup. Rather than build an avatar picker, we can just use random avatars instead as the v1 implementation of this.
For users, we'll use one of 24 random avatars
For workspaces, we'll use the first initial or number from the workspace name, and use that in one of our 16 colorways
The characters, yes. For the default workspace avatars, how do you think we should handle those? We could essentially just create an avatar for each starting letter of the alphabet/numbers, or we could do it dynamically via text. If we go the dynamic route, we'd need to wait until New Kansas is available though.
I looked into implementing this. For the random avatar, it'll be a two-part PR- one in web-static to host the new images, and then one in App (ReportUtils).
I have to look into our system a bit more. But for workspaces, I thought about using an SVG and using fill for the background and then color for the foreground/letter. That would solve needing about 500 files for all the combinations. I'd have to look into how avatars are stored, because I'm pretty sure avatar image types don't allow svgs currently.
Yeah, I was thinking that instead of doing all color combinations with each starting letter, we would just assign one color combo for A, one color combo for B, one color combo for C, etc etc... this way we'd only end up with like 26 alphabetical workspace avatars and then 10 numerical ones?
Agree that I don't think we support SVGs as avatars right now, @NikkiWines looked into this briefly for the new Concierge icon and we ended up going with a PNG instead.
Could I get the files for the default avatars? And then after that, if you want to send the workspace files along with an example letter SVG I could test out the random color idea :)
For sure! For the workspace files, what exactly are you looking for there? Do you want SVGs that are like black/white with just black for the BG and white for the letter? I could give you those for A-Z/0-9 and then maybe you can just change the colors programmatically? Or were you thinking to just have pre-colored SVGs, where A just gets one color pairing, B gets a different one, etc etc?
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.79-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-14. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Activity
melvin-bot commentedon Oct 28, 2022
Everybody was OOO, so I assigned the only eligible person.
shawnborton commentedon Nov 2, 2022
Just a heads up that I updated the original comment with a new mockup. Rather than build an avatar picker, we can just use random avatars instead as the v1 implementation of this.
JmillsExpensify commentedon Nov 2, 2022
Woo! Thanks Shawn. ❤️
grgia commentedon Nov 9, 2022
Do we have the files ready for this?
shawnborton commentedon Nov 9, 2022
The characters, yes. For the default workspace avatars, how do you think we should handle those? We could essentially just create an avatar for each starting letter of the alphabet/numbers, or we could do it dynamically via text. If we go the dynamic route, we'd need to wait until New Kansas is available though.
grgia commentedon Nov 9, 2022
I looked into implementing this. For the random avatar, it'll be a two-part PR- one in web-static to host the new images, and then one in App (ReportUtils).
I have to look into our system a bit more. But for workspaces, I thought about using an SVG and using
fillfor the background and thencolorfor the foreground/letter. That would solve needing about 500 files for all the combinations. I'd have to look into how avatars are stored, because I'm pretty sure avatar image types don't allow svgs currently.shawnborton commentedon Nov 9, 2022
Yeah, I was thinking that instead of doing all color combinations with each starting letter, we would just assign one color combo for A, one color combo for B, one color combo for C, etc etc... this way we'd only end up with like 26 alphabetical workspace avatars and then 10 numerical ones?
Agree that I don't think we support SVGs as avatars right now, @NikkiWines looked into this briefly for the new Concierge icon and we ended up going with a PNG instead.
grgia commentedon Nov 9, 2022
That makes it easy! Although looking at it right now I think the current workspace icon might be an SVG
shawnborton commentedon Nov 9, 2022
Oh sweet, that would be rad.
grgia commentedon Nov 14, 2022
Could I get the files for the default avatars? And then after that, if you want to send the workspace files along with an example letter SVG I could test out the random color idea :)
shawnborton commentedon Nov 15, 2022
For sure! For the workspace files, what exactly are you looking for there? Do you want SVGs that are like black/white with just black for the BG and white for the letter? I could give you those for A-Z/0-9 and then maybe you can just change the colors programmatically? Or were you thinking to just have pre-colored SVGs, where A just gets one color pairing, B gets a different one, etc etc?
56 remaining items
[-]Implement better default avatars[/-][+][HOLD for payment 2023-03-14] Implement better default avatars[/+]MelvinBot commentedon Mar 7, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Mar 7, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.79-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-14. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
mananjadhav commentedon Mar 15, 2023
@trjExpensify Would you be able to help with the payout here?Just checking if it's possible considering everyone is at the conference.
trjExpensify commentedon Mar 15, 2023
Yep, I can help with that. I presume this was for the internal review of the follow-up PR, so $1k yeah?
mananjadhav commentedon Mar 15, 2023
Yes this was an internal PR review.
trjExpensify commentedon Mar 15, 2023
Great! I've sent you an offer for $1,000.
mananjadhav commentedon Mar 15, 2023
Thanks. Accepted @trjExpensify
trjExpensify commentedon Mar 16, 2023
Cool, settled!