Skip to content

[HOLD for payment 2023-03-14] Implement better default avatars #12259

Closed

Description

@shawnborton

Note: This issue is part of the greater Implement Our New Branding in NewDot project.

What is it:

  • Add a wider variety of default avatars in the app for users
  • Use the first initial/number from the workspace name as the default workspace title along with a random color pairing

image

Does it require a mini design doc:
Yes

Design finished:
Yes

cc @GabiHExpensify

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01136d72ed85b4e6cf
  • Upwork Job ID: 1625441221891223552
  • Last Price Increase: 2023-02-14

Activity

  1. melvin-bot commented on Oct 28, 2022

    @melvin-bot

    Everybody was OOO, so I assigned the only eligible person.

  2. self-assigned this
    on Oct 28, 2022
  3. shawnborton commented on Nov 2, 2022

    @shawnborton
    ContributorAuthor

    Just a heads up that I updated the original comment with a new mockup. Rather than build an avatar picker, we can just use random avatars instead as the v1 implementation of this.

    • For users, we'll use one of 24 random avatars
    • For workspaces, we'll use the first initial or number from the workspace name, and use that in one of our 16 colorways
  4. JmillsExpensify commented on Nov 2, 2022

    @JmillsExpensify
    Contributor

    Woo! Thanks Shawn. ❤️

  5. grgia commented on Nov 9, 2022

    @grgia
    Contributor

    Do we have the files ready for this?

  6. shawnborton commented on Nov 9, 2022

    @shawnborton
    ContributorAuthor

    The characters, yes. For the default workspace avatars, how do you think we should handle those? We could essentially just create an avatar for each starting letter of the alphabet/numbers, or we could do it dynamically via text. If we go the dynamic route, we'd need to wait until New Kansas is available though.

  7. grgia commented on Nov 9, 2022

    @grgia
    Contributor

    I looked into implementing this. For the random avatar, it'll be a two-part PR- one in web-static to host the new images, and then one in App (ReportUtils).
    I have to look into our system a bit more. But for workspaces, I thought about using an SVG and using fill for the background and then color for the foreground/letter. That would solve needing about 500 files for all the combinations. I'd have to look into how avatars are stored, because I'm pretty sure avatar image types don't allow svgs currently.

  8. shawnborton commented on Nov 9, 2022

    @shawnborton
    ContributorAuthor

    Yeah, I was thinking that instead of doing all color combinations with each starting letter, we would just assign one color combo for A, one color combo for B, one color combo for C, etc etc... this way we'd only end up with like 26 alphabetical workspace avatars and then 10 numerical ones?

    Agree that I don't think we support SVGs as avatars right now, @NikkiWines looked into this briefly for the new Concierge icon and we ended up going with a PNG instead.

  9. grgia commented on Nov 9, 2022

    @grgia
    Contributor

    That makes it easy! Although looking at it right now I think the current workspace icon might be an SVG

  10. shawnborton commented on Nov 9, 2022

    @shawnborton
    ContributorAuthor

    Oh sweet, that would be rad.

  11. grgia commented on Nov 14, 2022

    @grgia
    Contributor

    Could I get the files for the default avatars? And then after that, if you want to send the workspace files along with an example letter SVG I could test out the random color idea :)

  12. shawnborton commented on Nov 15, 2022

    @shawnborton
    ContributorAuthor

    For sure! For the workspace files, what exactly are you looking for there? Do you want SVGs that are like black/white with just black for the BG and white for the letter? I could give you those for A-Z/0-9 and then maybe you can just change the colors programmatically? Or were you thinking to just have pre-colored SVGs, where A just gets one color pairing, B gets a different one, etc etc?

  13. 56 remaining items

  14. changed the title [-]Implement better default avatars[/-] [+][HOLD for payment 2023-03-14] Implement better default avatars[/+] on Mar 7, 2023
  15. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.79-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-03-14. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  17. mananjadhav commented on Mar 15, 2023

    @mananjadhav
    Collaborator

    @trjExpensify Would you be able to help with the payout here?Just checking if it's possible considering everyone is at the conference.

  18. trjExpensify commented on Mar 15, 2023

    @trjExpensify
    Contributor

    Yep, I can help with that. I presume this was for the internal review of the follow-up PR, so $1k yeah?

  19. mananjadhav commented on Mar 15, 2023

    @mananjadhav
    Collaborator

    presume this was for the internal review of the follow-up PR, so $1k yeah?

    Yes this was an internal PR review.

  20. trjExpensify commented on Mar 15, 2023

    @trjExpensify
    Contributor

    Great! I've sent you an offer for $1,000.

  21. mananjadhav commented on Mar 15, 2023

    @mananjadhav
    Collaborator

    Thanks. Accepted @trjExpensify

  22. trjExpensify commented on Mar 16, 2023

    @trjExpensify
    Contributor

    Cool, settled!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2DesignInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions