You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-12-08] [$1000] Incorrect pasted text on copied HTML snippet reported by @kerupuksambel #12271
Send this HTML snippet to someone : <a href="takia.html">asd</a>
Right click on the message and select the option "Copy to clip board" and paste it to either an external text editor or Expensify textbox
Expected Result:
The pasted text is the same as the copied text
Actual Result:
The pasted text on the external text editor is only asd while the pasted text on the Expensify textbox is [asd](https://staging.new.expensify.com/r/takia.html)
@Christinadobrzyn May I try to elaborate? My step to generate the error is :
Type <a href="takia.html">asd</a> in a chat in staging
Copy the code with highlighting the code and pressing Ctrl+C / Cmd+C
Paste it with Ctrl+V / Cmd + V on your text editor.
The bug is remained the same in my side. I also just realized the difference between copying the code from Copy To Clipboard button and using Ctrl/Cmd + C.
changed the title [-][$1000] Incorrect pasted text on copied HTML snippet reported by @kerupuksambel[/-][+][HOLD for payment 2022-12-08] [$1000] Incorrect pasted text on copied HTML snippet reported by @kerupuksambel[/+]on Dec 1, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia / @danieldoglas] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia / @danieldoglas] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Christinadobrzyn] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here Slack chat about this here
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here Slack chat about this here
Activity
melvin-bot commentedon Oct 28, 2022
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Nov 1, 2022
@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Christinadobrzyn commentedon Nov 2, 2022
Sorry I was ooo, I can't replicate this. Here's what I tried:
<a href="takia.html">asd</a>in a chat in stagingSide note, I can see this message in my notifications
Christinadobrzyn commentedon Nov 2, 2022
@kavimuru can you try to reproduce this again to see what we are doing differently? Feel free to assign this back to me if you can reproduce again.
kerupuksambel commentedon Nov 2, 2022
@Christinadobrzyn May I try to elaborate? My step to generate the error is :
<a href="takia.html">asd</a>in a chat in stagingThe bug is remained the same in my side. I also just realized the difference between copying the code from Copy To Clipboard button and using Ctrl/Cmd + C.
melvin-bot commentedon Nov 7, 2022
@kavimuru Huh... This is 4 days overdue. Who can take care of this?
55 remaining items
[-][$1000] Incorrect pasted text on copied HTML snippet reported by @kerupuksambel[/-][+][HOLD for payment 2022-12-08] [$1000] Incorrect pasted text on copied HTML snippet reported by @kerupuksambel[/+]melvin-bot commentedon Dec 1, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-12-08. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Dec 1, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
thesahindia commentedon Dec 1, 2022
As mentioned by @b1tjoy, it was a regression from #11905
thesahindia commentedon Dec 9, 2022
@Christinadobrzyn, this is ready for payment
Christinadobrzyn commentedon Dec 15, 2022
So sorry for the payment delay, I wasn't sure if there was a regression and I was ooo for a bit. Paid and closed the job.
@b1tjoy $1000 for the fix & $500 bonus (PR in 3 days)
@thesahindia $1000 as C+ & $500 bonus (PR in 3 days)
@kerupuksambel $250 for reporting
Christinadobrzyn commentedon Dec 19, 2022
@thesahindia @danieldoglas can you please complete the checkboxes here and feel close this GH when you're done!
#12271 (comment)
thesahindia commentedon Dec 19, 2022
#11905
#11905 (comment)
https://expensify.slack.com/archives/C049HHMV9SM/p1671474832197629
Need help with this one @danieldoglas
danieldoglas commentedon Jan 2, 2023
Closing this since regression test was created already