Skip to content

[HOLD for payment 2022-12-08] [$1000] Incorrect pasted text on copied HTML snippet reported by @kerupuksambel #12271

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open staging.new.expensify.com
  2. Send this HTML snippet to someone : <a href="takia.html">asd</a>
  3. Right click on the message and select the option "Copy to clip board" and paste it to either an external text editor or Expensify textbox

Expected Result:

The pasted text is the same as the copied text

Actual Result:

The pasted text on the external text editor is only asd while the pasted text on the Expensify textbox is [asd](https://staging.new.expensify.com/r/takia.html)

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.21-4

Reproducible in staging?: y

Reproducible in production?: y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Wrong.Snippet.mp4
Recording.812.mp4

Expensify/Expensify Issue URL:

Issue reported by: @kerupuksambel

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666969406840619

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2022
  2. melvin-bot commented on Oct 28, 2022

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Nov 1, 2022

    @melvin-bot

    @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  4. Christinadobrzyn commented on Nov 2, 2022

    @Christinadobrzyn
    Contributor

    Sorry I was ooo, I can't replicate this. Here's what I tried:

    1. Copy/paste <a href="takia.html">asd</a> in a chat in staging
    2. Click the Copy to Clipboard icon
    3. Open TextEdit and paste

    2022-11-02_09-33-19 (1)

    Side note, I can see this message in my notifications

    image

  5. Christinadobrzyn commented on Nov 2, 2022

    @Christinadobrzyn
    Contributor

    @kavimuru can you try to reproduce this again to see what we are doing differently? Feel free to assign this back to me if you can reproduce again.

  6. kerupuksambel commented on Nov 2, 2022

    @kerupuksambel

    @Christinadobrzyn May I try to elaborate? My step to generate the error is :

    1. Type <a href="takia.html">asd</a> in a chat in staging
    2. Copy the code with highlighting the code and pressing Ctrl+C / Cmd+C
    3. Paste it with Ctrl+V / Cmd + V on your text editor.

    The bug is remained the same in my side. I also just realized the difference between copying the code from Copy To Clipboard button and using Ctrl/Cmd + C.

    wronggg

  7. melvin-bot commented on Nov 7, 2022

    @melvin-bot

    @kavimuru Huh... This is 4 days overdue. Who can take care of this?

  8. removed their assignment
    on Nov 7, 2022
  9. 55 remaining items

  10. changed the title [-][$1000] Incorrect pasted text on copied HTML snippet reported by @kerupuksambel[/-] [+][HOLD for payment 2022-12-08] [$1000] Incorrect pasted text on copied HTML snippet reported by @kerupuksambel[/+] on Dec 1, 2022
  11. melvin-bot commented on Dec 1, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-08. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Dec 1, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thesahindia / @danieldoglas] The PR that introduced the bug has been identified. Link to the PR:
    • [@thesahindia / @danieldoglas] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@thesahindia / @danieldoglas] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Christinadobrzyn] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here Slack chat about this here
  13. thesahindia commented on Dec 1, 2022

    @thesahindia
    Member

    The PR that introduced the bug has been identified. Link to the PR:

    As mentioned by @b1tjoy, it was a regression from #11905

  14. thesahindia commented on Dec 9, 2022

    @thesahindia
    Member

    @Christinadobrzyn, this is ready for payment

  15. Christinadobrzyn commented on Dec 15, 2022

    @Christinadobrzyn
    Contributor

    So sorry for the payment delay, I wasn't sure if there was a regression and I was ooo for a bit. Paid and closed the job.

    @b1tjoy $1000 for the fix & $500 bonus (PR in 3 days)
    @thesahindia $1000 as C+ & $500 bonus (PR in 3 days)
    @kerupuksambel $250 for reporting

  16. Christinadobrzyn commented on Dec 19, 2022

    @Christinadobrzyn
    Contributor

    @thesahindia @danieldoglas can you please complete the checkboxes here and feel close this GH when you're done!

    #12271 (comment)

  17. removed their assignment
    on Dec 19, 2022
  18. thesahindia commented on Dec 19, 2022

    @thesahindia
    Member

    The PR that introduced the bug has been identified. Link to the PR:

    #11905

    The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #11905 (comment)

    A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    https://expensify.slack.com/archives/C049HHMV9SM/p1671474832197629

    A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here Slack chat about this here

    Need help with this one @danieldoglas

  19. danieldoglas commented on Jan 2, 2023

    @danieldoglas
    Contributor

    Closing this since regression test was created already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions